All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Lamanna <jlamanna@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] drivers/scsi/advansys.c: Convert pci_find_device()
Date: Fri, 08 Jul 2005 18:04:05 +0000	[thread overview]
Message-ID: <aa4c40ff05070811046bada462@mail.gmail.com> (raw)
In-Reply-To: <aa4c40ff0507071414328c64ad@mail.gmail.com>

On 7/8/05, Greg KH <greg@kroah.com> wrote:
[snip]
> Why not just move this out of the if statement as you are doing it
> either way?

Depending on whether the board is a "wide" or "narrow" board, the dev
struct is stored in a different field of the union (adv_dvc_cfg vs.
asc_dvc_cfg - not much difference in names there, easy to miss)

 
> Also, this driver doesn't even work, see the big #warning at the top of
> it.  You might want to ask the linux-scsi list if it's obsolete.

Ah, apparently I'm blind.
I guess this was the first driver I stumbled upon needing the conversion.
I'll check around about that.
I'll also see if there are any non-broken/warned drivers that need
this fix that I can tackle.

Thanks.

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

      parent reply	other threads:[~2005-07-08 18:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-07 21:14 [KJ] [PATCH] drivers/scsi/advansys.c: Convert pci_find_device() to James Lamanna
2005-07-08 17:19 ` [KJ] [PATCH] drivers/scsi/advansys.c: Convert pci_find_device() Greg KH
2005-07-08 18:04 ` James Lamanna [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa4c40ff05070811046bada462@mail.gmail.com \
    --to=jlamanna@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.