All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
	Hannes Reinecke <hare@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: Block layer state diagrams
Date: Fri, 28 Oct 2016 09:45:14 -0600	[thread overview]
Message-ID: <aa53ddef-e359-e085-79a1-cce9ef74994a@fb.com> (raw)
In-Reply-To: <702a719e-d979-8a38-c434-55f607c21f40@sandisk.com>

On 10/27/2016 04:37 PM, Bart Van Assche wrote:
> On 10/26/2016 10:45 PM, Hannes Reinecke wrote:
>> On 10/26/2016 10:21 PM, Bart Van Assche wrote:
>>> Some time ago I created the attached state diagrams for myself to avoid
>>> that I would have to reread the entire block layer core source code if
>>> it has been a while since I had a look at it. Do you think it would be
>>> useful to add these diagrams somewhere in the Documentation directory?
>>>
>> Can you add a step for the mapping between software and
>> hardware queues?
>> Also the actual submission to the LLDD (in step 'executing') could do
>> with a bit more emphasis.
>> And maybe the fontsize could be a tad smaller; currently it's hard to
>> figure out which label goes where, expecially in the bottom half.
>
> Thanks Hannes for the review. How about the attached second version of
> these diagrams?

I think they are a little confusing. Some of it is specific to non-fs
requests, yet you have the plugging path in there as well. Was the
intent to just show the PC path?

-- 
Jens Axboe


  reply	other threads:[~2016-10-28 15:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 20:21 Block layer state diagrams Bart Van Assche
2016-10-27  5:45 ` Hannes Reinecke
2016-10-27 22:37   ` Bart Van Assche
2016-10-28 15:45     ` Jens Axboe [this message]
2016-10-28 16:06       ` Bart Van Assche
2016-10-28 16:24         ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa53ddef-e359-e085-79a1-cce9ef74994a@fb.com \
    --to=axboe@fb.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.