From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 597CA41CB5E for ; Fri, 4 Sep 2026 16:40:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788540007; cv=none; b=JTkYq+vuDfyqRQGYH7awoDlMUB2nYMAVgSSpUBFmDwCsFjpQffRUK5B9PD54Atlwh7ZAapdizDtDHBMVGjPSn6kgUYsiTHlBJvX/qygB4JyhanDbGGMBuP5aMilm00SMDR4URX0tA5UH5uj1QwcA9TKr5ErzYF6PKJqZfyKHYDw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788540007; c=relaxed/simple; bh=KDKDoia3tZ/8GlEdcnS8kF69qQWCs5q0VtOQXevHuWA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=D8UlrAWQFOy6lrqFv9KK6drI1p3qGwUpNKhPct83/30cx/30h+K5CcPcBDFbWyvIubZkQgu97TCYwv7Ou28iP9zT+B/EwmKg9Vr/4LqiHlSsUi0Twk++sStipa3KWLsOG93ovEx2d6CRZ0mPCdpSd1YaoF9BTKBeIbonIQHhKp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SLwwSUUY; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SLwwSUUY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60A7F1F00A3D; Fri, 4 Sep 2026 16:40:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788540006; bh=ZOHofc99W4KM2l71gip6g0XNjCnZuK5U+pykgEU7J74=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=SLwwSUUYypsnSgFP1yBUypXMJ+JGCk9Onvz2UgKDg+/Hy8GU1ROscsMy284RaSxcf nfuoOz74CjoiOZHUuMRTqEs4chuAWoormEsNJLxAv6pQwgUIbWufN43pU503BosMHm j71X8HjmmlDafZe5HiAUGB7RDyse1yk3tTzajWvMenimTFSbrIwxfy72AaMaUZWyzF e0H2KvY7Yf4nXQ2OgESw73WqV7g9K0V1rkrC8DwiMll4VCtZjIydD4rdTjtGcaN5M1 3RMP6Qv9QjEZSVLWHY8BLsWLE20KnGfHRb/kSUHGKH3t1hFVDMxdCrKWi/B8xoSLoV JFJBRNsWlpMXQ== Message-ID: Date: Fri, 4 Sep 2026 18:40:02 +0200 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH mptcp-next 2/2] selftests: mptcp: convert iptables to nftables for mptcp_join.sh Content-Language: fr To: Hangbin Liu Cc: MPTCP Linux References: <20260902-mptcp_nft-v1-0-559caa16f410@kylinos.cn> <20260902-mptcp_nft-v1-2-559caa16f410@kylinos.cn> <513e6559-a06a-45d8-a8b7-72b3a1a77e71@kernel.org> <6c9dd599-e9d2-470f-bc7f-2af2e9d003b6@kernel.org> From: Matthieu Baerts Autocrypt: addr=matttbe@kernel.org; keydata= xsFNBFXj+ekBEADxVr99p2guPcqHFeI/JcFxls6KibzyZD5TQTyfuYlzEp7C7A9swoK5iCvf YBNdx5Xl74NLSgx6y/1NiMQGuKeu+2BmtnkiGxBNanfXcnl4L4Lzz+iXBvvbtCbynnnqDDqU c7SPFMpMesgpcu1xFt0F6bcxE+0ojRtSCZ5HDElKlHJNYtD1uwY4UYVGWUGCF/+cY1YLmtfb WdNb/SFo+Mp0HItfBC12qtDIXYvbfNUGVnA5jXeWMEyYhSNktLnpDL2gBUCsdbkov5VjiOX7 CRTkX0UgNWRjyFZwThaZADEvAOo12M5uSBk7h07yJ97gqvBtcx45IsJwfUJE4hy8qZqsA62A nTRflBvp647IXAiCcwWsEgE5AXKwA3aL6dcpVR17JXJ6nwHHnslVi8WesiqzUI9sbO/hXeXw TDSB+YhErbNOxvHqCzZEnGAAFf6ges26fRVyuU119AzO40sjdLV0l6LE7GshddyazWZf0iac nEhX9NKxGnuhMu5SXmo2poIQttJuYAvTVUNwQVEx/0yY5xmiuyqvXa+XT7NKJkOZSiAPlNt6 VffjgOP62S7M9wDShUghN3F7CPOrrRsOHWO/l6I/qJdUMW+MHSFYPfYiFXoLUZyPvNVCYSgs 3oQaFhHapq1f345XBtfG3fOYp1K2wTXd4ThFraTLl8PHxCn4ywARAQABzSRNYXR0aGlldSBC YWVydHMgPG1hdHR0YmVAa2VybmVsLm9yZz7CwZEEEwEIADsCGwMFCwkIBwIGFQoJCAsCBBYC AwECHgECF4AWIQToy4X3aHcFem4n93r2t4JPQmmgcwUCZUDpDAIZAQAKCRD2t4JPQmmgcz33 EACjROM3nj9FGclR5AlyPUbAq/txEX7E0EFQCDtdLPrjBcLAoaYJIQUV8IDCcPjZMJy2ADp7 /zSwYba2rE2C9vRgjXZJNt21mySvKnnkPbNQGkNRl3TZAinO1Ddq3fp2c/GmYaW1NWFSfOmw MvB5CJaN0UK5l0/drnaA6Hxsu62V5UnpvxWgexqDuo0wfpEeP1PEqMNzyiVPvJ8bJxgM8qoC cpXLp1Rq/jq7pbUycY8GeYw2j+FVZJHlhL0w0Zm9CFHThHxRAm1tsIPc+oTorx7haXP+nN0J iqBXVAxLK2KxrHtMygim50xk2QpUotWYfZpRRv8dMygEPIB3f1Vi5JMwP4M47NZNdpqVkHrm jvcNuLfDgf/vqUvuXs2eA2/BkIHcOuAAbsvreX1WX1rTHmx5ud3OhsWQQRVL2rt+0p1DpROI 3Ob8F78W5rKr4HYvjX2Inpy3WahAm7FzUY184OyfPO/2zadKCqg8n01mWA9PXxs84bFEV2mP VzC5j6K8U3RNA6cb9bpE5bzXut6T2gxj6j+7TsgMQFhbyH/tZgpDjWvAiPZHb3sV29t8XaOF BwzqiI2AEkiWMySiHwCCMsIH9WUH7r7vpwROko89Tk+InpEbiphPjd7qAkyJ+tNIEWd1+MlX ZPtOaFLVHhLQ3PLFLkrU3+Yi3tXqpvLE3gO3LM7BTQRV4/npARAA5+u/Sx1n9anIqcgHpA7l 5SUCP1e/qF7n5DK8LiM10gYglgY0XHOBi0S7vHppH8hrtpizx+7t5DBdPJgVtR6SilyK0/mp 9nWHDhc9rwU3KmHYgFFsnX58eEmZxz2qsIY8juFor5r7kpcM5dRR9aB+HjlOOJJgyDxcJTwM 1ey4L/79P72wuXRhMibN14SX6TZzf+/XIOrM6TsULVJEIv1+NdczQbs6pBTpEK/G2apME7vf mjTsZU26Ezn+LDMX16lHTmIJi7Hlh7eifCGGM+g/AlDV6aWKFS+sBbwy+YoS0Zc3Yz8zrdbi Kzn3kbKd+99//mysSVsHaekQYyVvO0KD2KPKBs1S/ImrBb6XecqxGy/y/3HWHdngGEY2v2IP Qox7mAPznyKyXEfG+0rrVseZSEssKmY01IsgwwbmN9ZcqUKYNhjv67WMX7tNwiVbSrGLZoqf Xlgw4aAdnIMQyTW8nE6hH/Iwqay4S2str4HZtWwyWLitk7N+e+vxuK5qto4AxtB7VdimvKUs x6kQO5F3YWcC3vCXCgPwyV8133+fIR2L81R1L1q3swaEuh95vWj6iskxeNWSTyFAVKYYVskG V+OTtB71P1XCnb6AJCW9cKpC25+zxQqD2Zy0dK3u2RuKErajKBa/YWzuSaKAOkneFxG3LJIv Hl7iqPF+JDCjB5sAEQEAAcLBXwQYAQIACQUCVeP56QIbDAAKCRD2t4JPQmmgc5VnD/9YgbCr HR1FbMbm7td54UrYvZV/i7m3dIQNXK2e+Cbv5PXf19ce3XluaE+wA8D+vnIW5mbAAiojt3Mb 6p0WJS3QzbObzHNgAp3zy/L4lXwc6WW5vnpWAzqXFHP8D9PTpqvBALbXqL06smP47JqbyQxj Xf7D2rrPeIqbYmVY9da1KzMOVf3gReazYa89zZSdVkMojfWsbq05zwYU+SCWS3NiyF6QghbW voxbFwX1i/0xRwJiX9NNbRj1huVKQuS4W7rbWA87TrVQPXUAdkyd7FRYICNW+0gddysIwPoa KrLfx3Ba6Rpx0JznbrVOtXlihjl4KV8mtOPjYDY9u+8x412xXnlGl6AC4HLu2F3ECkamY4G6 UxejX+E6vW6Xe4n7H+rEX5UFgPRdYkS1TA/X3nMen9bouxNsvIJv7C6adZmMHqu/2azX7S7I vrxxySzOw9GxjoVTuzWMKWpDGP8n71IFeOot8JuPZtJ8omz+DZel+WCNZMVdVNLPOd5frqOv mpz0VhFAlNTjU1Vy0CnuxX3AM51J8dpdNyG0S8rADh6C8AKCDOfUstpq28/6oTaQv7QZdge0 JY6dglzGKnCi/zsmp2+1w559frz4+IC7j/igvJGX4KDDKUs0mlld8J2u2sBXv7CGxdzQoHaz lzVbFe7fduHbABmYz9cefQpO7wDE/Q== Organization: NGI0 Core In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi Hangbin, On 04/09/2026 10:01, Hangbin Liu wrote: > On Thu, Sep 03, 2026 at 11:28:28AM +0200, Matthieu Baerts wrote: >> Hi Hangbin, >> >> On 03/09/2026 04:02, Hangbin Liu wrote: >>> Hi Matthieu, >>> >>> Sorry, My mbsync has some delays and I post v2 too quick before catching >>> your feedback. >> >> No problem. >> >> Just in case, maybe korgalore can help? >> >> https://people.kernel.org/monsieuricon/tracking-kernel-development-with-korgalore > > Thanks, learned a new tool. > >>>> If you don't need this one (or any set in helpers), don't set it/them, >>>> and don't use a global variable. Or reset it in init_partial, but prefer >>>> using local variable with a limited scope. >>> >>> Yes, we don't need the handle in other place, which I will remove them. >>> But for endpoint_tests(), after adding rules in reset_with_tcp_filter, >>> we need to remove the rule outside. I will reset it after each test. >> >> Perhaps you could flush the whole table instead? But if it makes more >> sense to assign this variable, fine by me. > > Yes, if not in purpose, I feel flush the whole table is dangerous. > Some rules may still in using in later testing. Indeed. But in our case, each subtest uses a dedicated netns. Plus only some tests add Netfilter rules. At the end, it is clearer to delete a specific rule, but I think that makes sense only if the nft_handle var is set locally, and used a few lines below. If a global nft_handle var is used, that doesn't seem clear, and I think it would be clearer/easier to: - either delete a specific rule (but I don't think that's supported) - get the handle from the test and use it to delete the rule - or flush the table. So up to you, but probably best to avoid using nft_handle as global var. >>> Thanks for the notes. I used to rely on `b4 auto-to-cc` too much... >> >> Most of the time, that's fine. It's just for some subsubtrees where >> (urgent & simple) fixes can go to the parent tree (netdev here) >> directly, but the rest can go only to the subsubtree ML. >> >> BTW, if you are on top of our export(-net) (or for-review(-net)) branch, >> there is a .b4-config: you just need to use 'b4 send' then :) > > Thanks. I am working on top of the export branch. I ran into a small issue > while using b4. The export branch is not fast‑forwardable. I used > `git reset --hard` to fall back to the top merge commit, then ran > `git pull` to fetch the latest changes. > > However, I cannot perform a reset on the b4 branch, and git rebase also failed. > These steps have blocked me a little. I have to manually recreate the b4 branch, > or perhaps avoid using b4 when working on mptcp changes. You need to use `|git rebase --onto` instead, e.g. git fetch origin # adapt here and below if needed git rebase --onto origin/export "$(b4 prep --show-info base-commit)" Can you check if it works for you, please? (so I can update the wiki page if needed) The alternative is to use `for-review`, with a continuous history, see: https://github.com/multipath-tcp/mptcp_net-next/wiki/Git-Branches | Cheers, Matt -- Sponsored by the NGI0 Core fund.