From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E125F3C244 for ; Mon, 9 Mar 2026 12:22:29 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.1249394.1546855 (Exim 4.92) (envelope-from ) id 1vzZcp-0003bw-LU; Mon, 09 Mar 2026 12:22:19 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 1249394.1546855; Mon, 09 Mar 2026 12:22:19 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vzZcp-0003bp-Gk; Mon, 09 Mar 2026 12:22:19 +0000 Received: by outflank-mailman (input) for mailman id 1249394; Mon, 09 Mar 2026 12:22:18 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1vzZco-0003bj-56 for xen-devel@lists.xenproject.org; Mon, 09 Mar 2026 12:22:18 +0000 Received: from mail132-19.atl131.mandrillapp.com (mail132-19.atl131.mandrillapp.com [198.2.132.19]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9711b72a-1bb2-11f1-9ccf-f158ae23cfc8; Mon, 09 Mar 2026 13:22:08 +0100 (CET) Received: from pmta09.mandrill.prod.atl01.rsglab.com (localhost [127.0.0.1]) by mail132-19.atl131.mandrillapp.com (Mailchimp) with ESMTP id 4fTx326qbkz2lL for ; Mon, 9 Mar 2026 12:22:06 +0000 (GMT) Received: from [37.26.189.201] by mandrillapp.com id 638f3f823d7f4ab28270cf3473175c76; Mon, 09 Mar 2026 12:22:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9711b72a-1bb2-11f1-9ccf-f158ae23cfc8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mandrillapp.com; s=mte1; t=1773058927; x=1773328927; bh=pzRefWKHPO4gtPDK77mGxGQotz5Vl0Qyd4vFEZa7/Gk=; h=From:Subject:To:Cc:Message-Id:References:In-Reply-To:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=h5HANp9yM3I2+mqmE13/b7WJAI6z+2Osg38VIC3WcuQuGniRsk3eNugV4GJeBrX4n 7LIUkNNHC0vyCwf/RnoQ+AQacgA0CXTdz8Qr2wdG8zcEZe79nG+n4Y0F9LLMxJSj7Q Mc4WS5QinrVUgapQU14QeS0HcaYJq/PePZf+0VhxePFFc4tVv5bH+3qijnBwCbl0zu wNxP6jUWAIP/6FmWI24n1pp1gdz/O3Gfz4erZfR3WZYg41KSt9Dc5Qnh8gdk1E9L5U wqNd0jsMKJOsl27Q3OmqEiGjDQBqMFkPDRZQV+0dF0KV1Cl2SL0BfO3WBiYl5l7TGE rvdXYGhPWsdiA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vates.tech; s=mte1; t=1773058927; x=1773319427; i=anthony.perard@vates.tech; bh=pzRefWKHPO4gtPDK77mGxGQotz5Vl0Qyd4vFEZa7/Gk=; h=From:Subject:To:Cc:Message-Id:References:In-Reply-To:Feedback-ID: Date:MIME-Version:Content-Type:Content-Transfer-Encoding:CC:Date: Subject:From; b=h/bygIiy1vv6mW5R3i8adcMxUnvv3MpjZ12soLwjk2tZelPqOvuNurLLvfv/x2gJz thwOxa/c2lLdGUzB9o9FK3ne9jowZaqjuEJtz+Th5s+67PYID/qcxPxoGbPRv0JL5s NZvBeFGkHRqdrxAizHrUk/VA57/njMJARJsLCI9WCpkdd7Yaq7m1upY2NCOIBA4VbJ v+cYh/xbmOee2Wi9XthF4/yQjfLaBxHurzxKg3wGSMAzQ2HRB066mYjBwX4Ql+BYjW v3pbJihYu364q2oKygi2pmBCgH3Btg7WNgMiJB/SCmvucXjb091ok9JMfYjKd5b6Yv VdFA6Q3uJxzQw== From: "Anthony PERARD" Subject: =?utf-8?Q?Re:=20[PATCH=20v6]=20xen/domain:=20introduce=20DOMID=5FANY?= X-Bm-Disclaimer: Yes X-Bm-Milter-Handled: 4ffbd6c1-ee69-4e1b-aabd-f977039bd3e2 X-Bm-Transport-Timestamp: 1773058924994 To: dmukhin@ford.com Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com, jbeulich@suse.com, julien@xen.org, michal.orzel@amd.com, roger.pau@citrix.com, sstabellini@kernel.org Message-Id: References: <20260307025451.3148078-2-dmukhin@ford.com> In-Reply-To: <20260307025451.3148078-2-dmukhin@ford.com> X-Native-Encoded: 1 X-Report-Abuse: =?UTF-8?Q?Please=20forward=20a=20copy=20of=20this=20message,=20including=20all=20headers,=20to=20abuse@mandrill.com.=20You=20can=20also=20report=20abuse=20here:=20https://mandrillapp.com/contact/abuse=3Fid=3D30504962.638f3f823d7f4ab28270cf3473175c76?= X-Mandrill-User: md_30504962 Feedback-ID: 30504962:30504962.20260309:md Date: Mon, 09 Mar 2026 12:22:06 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On Fri, Mar 06, 2026 at 06:54:52PM -0800, dmukhin@ford.com wrote: > diff --git a/tools/libs/light/libxl_create.c b/tools/libs/light/libxl_create.c > index bfc9149096a3..79af2958d170 100644 > --- a/tools/libs/light/libxl_create.c > +++ b/tools/libs/light/libxl_create.c > @@ -666,7 +666,7 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config, > } > > for (;;) { > - uint32_t local_domid; > + uint32_t local_domid = DOMID_INVALID; Surely, this change is unnecessary? > bool recent; > > if (info->domid == RANDOM_DOMID) { > @@ -681,8 +681,10 @@ int libxl__domain_make(libxl__gc *gc, libxl_domain_config *d_config, > continue; > > local_domid = v; > + } else if (libxl_domid_valid_guest(local_domid)) { You meant to check `info->domid`, right? > + local_domid = info->domid; > } else { > - local_domid = info->domid; /* May not be valid */ > + local_domid = DOMID_ANY; > } Cheers, -- Anthony Perard | Vates XCP-ng Developer XCP-ng & Xen Orchestra - Vates solutions web: https://vates.tech