From: pheragu@codeaurora.org
To: marc.zyngier@arm.com, Linux Kernel <linux-kernel@vger.kernel.org>,
Linux-arm Msm <linux-arm-msm@vger.kernel.org>
Cc: psodagud@codeaurora.org, Tsoni <tsoni@codeaurora.org>,
rananta@codeaurora.org, mnalajal@codeaurora.org
Subject: Warning seen when removing a module using irqdomain framework
Date: Tue, 23 Jul 2019 14:52:34 -0700 [thread overview]
Message-ID: <aa6a66a7671f12f19d0364755e76de0d@codeaurora.org> (raw)
Hi,
I have been working on a interrupt controller driver that uses tree
based mapping for its domain (irq_domain_add_tree(..)).
If I understand correctly, the clients get a mapping when they call
platform_get_irq(..).
However, after these clients are removed (rmmod), when I try to remove
the interrupt controller driver where it calls irq_domain_remove(..), I
hit this warning from kernel/kernel/irq/irqdomain.c::
irq_domain_remove(..)
[WARN_ON(!radix_tree_empty(&domain->revmap_tree));]-
WARNING: CPU: 0 PID: 238 at /kernel/kernel/irq/irqdomain.c:246
irq_domain_remove+0x84/0x98
Also, I see that the requested IRQs by the clients are still present (in
/proc/interrupts) even after they had been removed.
Hence, I just wanted to know how to handle this warning. Should the
client clean up by calling irq_dispose_mapping(..) or is it the
responsibility of the interrupt controller driver to dispose the
mappings one by one?
Regards,
Prakruthi Deepak Heragu
next reply other threads:[~2019-07-23 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 21:52 pheragu [this message]
2019-07-24 6:51 ` Warning seen when removing a module using irqdomain framework Marc Zyngier
2019-07-25 21:41 ` pheragu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa6a66a7671f12f19d0364755e76de0d@codeaurora.org \
--to=pheragu@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mnalajal@codeaurora.org \
--cc=psodagud@codeaurora.org \
--cc=rananta@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.