From: Damien Le Moal <dlemoal@kernel.org>
To: Yu Kuai <yukuai1@huaweicloud.com>,
hch@infradead.org, colyli@kernel.org, hare@suse.de,
tieren@fnnas.com, axboe@kernel.dk, tj@kernel.org,
josef@toxicpanda.com, song@kernel.org, kmo@daterainc.com,
satyat@google.com, ebiggers@google.com, neil@brown.name,
akpm@linux-foundation.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, linux-raid@vger.kernel.org,
yukuai3@huawei.com, yi.zhang@huawei.com, yangerkun@huawei.com,
johnny.chenyi@huawei.com
Subject: Re: [PATCH RFC v3 06/15] md/raid0: convert raid0_handle_discard() to use bio_submit_split_bioset()
Date: Mon, 1 Sep 2025 15:37:25 +0900 [thread overview]
Message-ID: <aa6b1a62-787e-4365-aca5-d03c6b94545f@kernel.org> (raw)
In-Reply-To: <20250901033220.42982-7-yukuai1@huaweicloud.com>
On 9/1/25 12:32 PM, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@huawei.com>
>
> Unify bio split code, and prepare to fix disordered split IO
Missing the period at the end of the above sentence.
>
> Noted commit 319ff40a5427 ("md/raid0: Fix performance regression for large
> sequential writes") already fix disordered split IO by converting bio to
> underlying disks before submit_bio_noacct(), with the respect
> md_submit_bio() already split by sectors, and raid0_make_request() will
> split at most once for unaligned IO. This is a bit hacky and we'll convert
> this to solution in general later.
I do not see how this is relevant to this patch. The patch is a simple
straightforward conversion of hard-coded BIO split to using
bio_submit_split_bioset(). So I would just say that.
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
With the above addressed, this looks OK to me.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-09-01 6:40 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 3:32 [PATCH RFC v3 00/15] block: fix disordered IO in the case recursive split Yu Kuai
2025-09-01 3:32 ` [PATCH RFC v3 01/15] block: cleanup bio_issue Yu Kuai
2025-09-01 3:43 ` Damien Le Moal
2025-09-01 6:22 ` Yu Kuai
2025-09-03 13:23 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 02/15] block: add QUEUE_FLAG_BIO_ISSUE Yu Kuai
2025-09-02 17:05 ` Bart Van Assche
2025-09-03 0:54 ` Yu Kuai
2025-09-03 13:24 ` Christoph Hellwig
2025-09-03 16:54 ` Yu Kuai
2025-09-04 2:44 ` Yu Kuai
2025-09-04 5:09 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 03/15] md: fix mssing blktrace bio split events Yu Kuai
2025-09-01 6:30 ` Damien Le Moal
2025-09-01 7:53 ` Yu Kuai
2025-09-03 13:25 ` Christoph Hellwig
2025-09-04 0:58 ` Yu Kuai
2025-09-01 3:32 ` [PATCH RFC v3 04/15] blk-crypto: fix missing processing for split bio Yu Kuai
2025-09-01 6:31 ` Damien Le Moal
2025-09-03 13:26 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 05/15] block: factor out a helper bio_submit_split_bioset() Yu Kuai
2025-09-01 6:34 ` Damien Le Moal
2025-09-02 17:12 ` Bart Van Assche
2025-09-03 13:28 ` Christoph Hellwig
2025-09-03 13:28 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 06/15] md/raid0: convert raid0_handle_discard() to use bio_submit_split_bioset() Yu Kuai
2025-09-01 6:37 ` Damien Le Moal [this message]
2025-09-01 7:57 ` Yu Kuai
2025-09-03 13:29 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 07/15] md/raid1: convert " Yu Kuai
2025-09-01 6:43 ` Damien Le Moal
2025-09-01 8:03 ` Yu Kuai
2025-09-03 13:30 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 08/15] md/raid10: add a new r10bio flag R10BIO_Returned Yu Kuai
2025-09-01 3:32 ` [PATCH RFC v3 09/15] md/raid10: convert read/write to use bio_submit_split_bioset() Yu Kuai
2025-09-01 3:32 ` [PATCH RFC v3 10/15] md/raid5: convert " Yu Kuai
2025-09-01 3:32 ` [PATCH RFC v3 11/15] md/md-linear: " Yu Kuai
2025-09-02 3:00 ` kernel test robot
2025-09-03 17:43 ` Bart Van Assche
2025-09-04 0:50 ` Yu Kuai
2025-09-01 3:32 ` [PATCH RFC v3 12/15] blk-crypto: " Yu Kuai
2025-09-03 13:31 ` Christoph Hellwig
2025-09-01 3:32 ` [PATCH RFC v3 13/15] block: skip unnecessary checks for split bio Yu Kuai
2025-09-03 13:33 ` Christoph Hellwig
2025-09-03 17:00 ` Yu Kuai
2025-09-01 3:32 ` [PATCH RFC v3 14/15] block: fix disordered IO in the case recursive split Yu Kuai
2025-09-02 17:20 ` Bart Van Assche
2025-09-03 1:00 ` Yu Kuai
2025-09-03 1:12 ` Bart Van Assche
2025-09-03 1:41 ` Yu Kuai
2025-09-03 13:34 ` Christoph Hellwig
2025-09-03 16:59 ` Yu Kuai
2025-09-03 17:52 ` Bart Van Assche
2025-09-01 3:32 ` [PATCH RFC v3 15/15] md/raid0: convert raid0_make_request() to use bio_submit_split_bioset() Yu Kuai
2025-09-01 14:09 ` [PATCH RFC v3 00/15] block: fix disordered IO in the case recursive split Bart Van Assche
2025-09-02 1:50 ` Yu Kuai
2025-09-02 8:04 ` Yu Kuai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa6b1a62-787e-4365-aca5-d03c6b94545f@kernel.org \
--to=dlemoal@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=colyli@kernel.org \
--cc=ebiggers@google.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=johnny.chenyi@huawei.com \
--cc=josef@toxicpanda.com \
--cc=kmo@daterainc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neil@brown.name \
--cc=satyat@google.com \
--cc=song@kernel.org \
--cc=tieren@fnnas.com \
--cc=tj@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.