From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB996C43334 for ; Wed, 1 Jun 2022 16:03:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aDJgpm9Bf5Z5UD/AgH0bTjDbHj5fr997oaYrTv9b7FY=; b=Q/mlkKDfmtfLxO eWEd0/g5FcVoT+06Wo90vR+nxRsf8aSsIWDH3/ir4YsvfWL0/iRw5aO2UAni1GrVN/s3ITZO5QV+o +Ysl0m2eJTm6Ws29ZdMvHal6aiVEhuXiloNZIaE9rxcBZzCtXm6WS/Bzge3n7HrepP/gNUFv/6CEB 4eirofwLXDnWIGCQPU9GhvIEzr0tQdBqJme7aRa2h/iPeSeWVY7tN2vuxWmcR6aB4pNaQYDi17nds HQFg9fDgVBFBViAV2/BOAOxApIA7dcuxmYP+bTy1Snz63587KQiN42sLFrA8YcaG8Z6/lRuBipJQL vJLUxnvpLGwyKAybolIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwQoS-00H0uE-EP; Wed, 01 Jun 2022 16:03:12 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwQoF-00H0r2-NT; Wed, 01 Jun 2022 16:03:01 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: benjamin.gaignard) with ESMTPSA id 2B4D71F4104F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1654099375; bh=QstXEK7vK9peaXuxwekF4t4rKyDGtTDzVurNPkvZNRU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bdRflAAGzQHFImM59JNtJ14nwKlXDWazj5QOV2ETaiLTpb2k/9J8u3r9Q5bGn8Qdw FC4bX0OMU0Y6K5p4xrIjBMciBTuirqvcXSNPkQx/lKv9+lVnim8QB4OUl9/E0/glqi 64l71Rs9K5i+dVo8LibUxoP0iwXOYpuooJ1hpeXLtWvw3R/PYHL7keG0PZvOWka0BS j+BkhVmKdBGpV07VDbzUzsflGoJZ1vgTOM0EFHWKSbp5NXogW58iSE4+ZcMIglwIX9 PfH0zADgzTol8Agsap2/mYLdR3/YjcSPDAjolLhoN0r6520Yt1CUp44gr0+Xt0kC4Q rLucgpnxOH9sA== Message-ID: Date: Wed, 1 Jun 2022 18:02:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v6 09/17] media: uapi: HEVC: Define V4L2_CID_STATELESS_HEVC_SLICE_PARAMS as a dynamic array Content-Language: en-US To: =?UTF-8?Q?Jernej_=c5=a0krabec?= , mchehab@kernel.org, hverkuil@xs4all.nl, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, samuel@sholland.org, nicolas.dufresne@collabora.com, andrzej.p@collabora.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com References: <20220527143134.3360174-1-benjamin.gaignard@collabora.com> <20220527143134.3360174-10-benjamin.gaignard@collabora.com> <2630478.mvXUDI8C0e@kista> <8069971.T7Z3S40VBb@kista> From: Benjamin Gaignard In-Reply-To: <8069971.T7Z3S40VBb@kista> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_090300_072651_2FA724D2 X-CRM114-Status: GOOD ( 18.59 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org CkxlIDAxLzA2LzIwMjIgw6AgMTc6NDMsIEplcm5laiDFoGtyYWJlYyBhIMOpY3JpdMKgOgo+IERu ZSBuZWRlbGphLCAyOS4gbWFqIDIwMjIgb2IgMTE6MTk6MTIgQ0VTVCBqZSBKZXJuZWogxaBrcmFi ZWMgbmFwaXNhbChhKToKPj4gRG5lIHBldGVrLCAyNy4gbWFqIDIwMjIgb2IgMTY6MzE6MjYgQ0VT VCBqZSBCZW5qYW1pbiBHYWlnbmFyZCBuYXBpc2FsKGEpOgo+Pj4gTWFrZSBleHBsaWNpdCB0aGF0 IFY0TDJfQ0lEX1NUQVRFTEVTU19IRVZDX1NMSUNFX1BBUkFNUyBjb250cm9sIGlzCj4+PiBhIGR5 bmFtaWMgYXJyYXkgY29udHJvbCB0eXBlLgo+Pj4gU29tZSBkcml2ZXJzIG1heSBiZSBhYmxlIHRv IHJlY2VpdmUgbXVsdGlwbGUgc2xpY2VzIGluIG9uZSBjb250cm9sCj4+PiB0byBpbXByb3ZlIGRl Y29kaW5nIHBlcmZvcm1hbmNlLgo+Pj4KPj4+IERlZmluZSB0aGUgbWF4IHNpemUgb2YgdGhlIGR5 bmFtaWMgdGhhdCBjYW4gZHJpdmVyIGNhbiBzZXQgaW4gLmRpbXMgPSB7fS4KPj4+Cj4+PiBTaWdu ZWQtb2ZmLWJ5OiBCZW5qYW1pbiBHYWlnbmFyZCA8YmVuamFtaW4uZ2FpZ25hcmRAY29sbGFib3Jh LmNvbT4KPj4+IC0tLQo+Pj4gdmVyc2lvbiA2Ogo+Pj4gLSBTZXQgVjRMMl9DVFJMX0ZMQUdfRFlO QU1JQ19BUlJBWSBmbGFnIGF1dG9tYXRpY2FsbHkgd2hlbiB1c2luZwo+Pj4gICAgVjRMMl9DSURf U1RBVEVMRVNTX0hFVkNfU0xJQ0VfUEFSQU1TIGNvbnRyb2wuCj4+PiAtIEFkZCBhIGRlZmluZSBm b3IgbWF4IHNsaWNlcyBjb3VudAo+Pj4KPj4+ICAgRG9jdW1lbnRhdGlvbi91c2Vyc3BhY2UtYXBp L21lZGlhL3Y0bC9leHQtY3RybHMtY29kZWMucnN0IHwgMiArKwo+Pj4gICBkcml2ZXJzL21lZGlh L3Y0bDItY29yZS92NGwyLWN0cmxzLWRlZnMuYyAgICAgICAgICAgICAgICAgfCAxICsKPj4+ICAg aW5jbHVkZS9tZWRpYS9oZXZjLWN0cmxzLmggICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHwgNSArKysrKwo+Pj4gICAzIGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKQo+Pj4KPj4+ IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL3VzZXJzcGFjZS1hcGkvbWVkaWEvdjRsL2V4dC1j dHJscy1jb2RlYy5yc3QgYi8KPj4gRG9jdW1lbnRhdGlvbi91c2Vyc3BhY2UtYXBpL21lZGlhL3Y0 bC9leHQtY3RybHMtY29kZWMucnN0Cj4+PiBpbmRleCAwNmI5NjdkZTE0MGMuLjA3OTZiMTU2M2Rh YSAxMDA2NDQKPj4+IC0tLSBhL0RvY3VtZW50YXRpb24vdXNlcnNwYWNlLWFwaS9tZWRpYS92NGwv ZXh0LWN0cmxzLWNvZGVjLnJzdAo+Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi91c2Vyc3BhY2UtYXBp L21lZGlhL3Y0bC9leHQtY3RybHMtY29kZWMucnN0Cj4+PiBAQCAtMjk4Niw2ICsyOTg2LDggQEAg ZW51bSB2NGwyX21wZWdfdmlkZW9faGV2Y19zaXplX29mX2xlbmd0aF9maWVsZCAtCj4+PiAgICAg ICBUaGVzZSBiaXRzdHJlYW0gcGFyYW1ldGVycyBhcmUgZGVmaW5lZCBhY2NvcmRpbmcgdG8gOnJl ZjpgaGV2Y2AuCj4+PiAgICAgICBUaGV5IGFyZSBkZXNjcmliZWQgaW4gc2VjdGlvbiA3LjQuNyAi R2VuZXJhbCBzbGljZSBzZWdtZW50IGhlYWRlcgo+Pj4gICAgICAgc2VtYW50aWNzIiBvZiB0aGUg c3BlY2lmaWNhdGlvbi4KPj4+ICsgICAgVGhpcyBjb250cm9sIGlzIGEgZHluYW1pY2FsbHkgc2l6 ZWQgMS1kaW1lbnNpb25hbCBhcnJheSwKPj4+ICsgICAgVjRMMl9DVFJMX0ZMQUdfRFlOQU1JQ19B UlJBWSBmbGFnIG11c3QgYmUgc2V0IHdoZW4gdXNpbmcgaXQuCj4+PiAgIAo+Pj4gICAuLiBjOnR5 cGU6OiB2NGwyX2N0cmxfaGV2Y19zbGljZV9wYXJhbXMKPj4+ICAgCj4+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9tZWRpYS92NGwyLWNvcmUvdjRsMi1jdHJscy1kZWZzLmMgYi9kcml2ZXJzL21lZGlh Lwo+IHY0bDItCj4+IGNvcmUvdjRsMi1jdHJscy1kZWZzLmMKPj4+IGluZGV4IDlmNTU1MDNjZDNk Ni4uZDU5NGVmYmNiYjkzIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9tZWRpYS92NGwyLWNvcmUv djRsMi1jdHJscy1kZWZzLmMKPj4+ICsrKyBiL2RyaXZlcnMvbWVkaWEvdjRsMi1jb3JlL3Y0bDIt Y3RybHMtZGVmcy5jCj4+PiBAQCAtMTUxMCw2ICsxNTEwLDcgQEAgdm9pZCB2NGwyX2N0cmxfZmls bCh1MzIgaWQsIGNvbnN0IGNoYXIgKipuYW1lLCBlbnVtCj4+IHY0bDJfY3RybF90eXBlICp0eXBl LAo+Pj4gICAJCWJyZWFrOwo+Pj4gICAJY2FzZSBWNEwyX0NJRF9TVEFURUxFU1NfSEVWQ19TTElD RV9QQVJBTVM6Cj4+PiAgIAkJKnR5cGUgPSBWNEwyX0NUUkxfVFlQRV9IRVZDX1NMSUNFX1BBUkFN UzsKPj4+ICsJCSpmbGFncyB8PSBWNEwyX0NUUkxfRkxBR19EWU5BTUlDX0FSUkFZOwo+PiBUaGlz IGNoYW5nZSBicmVha3MgQ2VkcnVzLiBJJ2xsIGNoZWNrIHdoYXQgbmVlZHMgdG8gYmUgY2hhbmdl ZC4KPiBQbGVhc2UgaW5jbHVkZSB0aGUgY2hhbmdlIGJlbGxvdyB0byBrZWVwIENlZHJ1cyB3b3Jr aW5nLiBJJ2xsIGV4cGFuZCBzdXBwb3J0Cj4gZm9yIG1vcmUgc2xpY2VzIGxhdGVyLgoKVGhhdCB3 aWxsIGJlIGluIHZlcnNpb24gNy4gVGhhbmtzLgpJIHdpbGwgd2FpdCBmb3IgbW9yZSByZXZpZXdz IG9uIHRoZSBvdGhlcnMgcGF0Y2hlcyBiZWZvcmUgc2VuZCBpdC4KClJlZ2FyZHMsCkJlbmphbWlu Cgo+Cj4gICBCZXN0IHJlZ2FyZHMsCj4gICBKZXJuZWoKPgo+IC0tLSBhL2RyaXZlcnMvc3RhZ2lu Zy9tZWRpYS9zdW54aS9jZWRydXMvY2VkcnVzLmMKPiArKysgYi9kcml2ZXJzL3N0YWdpbmcvbWVk aWEvc3VueGkvY2VkcnVzL2NlZHJ1cy5jCj4gQEAgLTE3OCw2ICsxNzgsNyBAQCBzdGF0aWMgY29u c3Qgc3RydWN0IGNlZHJ1c19jb250cm9sIGNlZHJ1c19jb250cm9sc1tdID0gewo+ICAgICAgICAg IHsKPiAgICAgICAgICAgICAgICAgIC5jZmcgPSB7Cj4gICAgICAgICAgICAgICAgICAgICAgICAg IC5pZCAgICAgPSBWNEwyX0NJRF9TVEFURUxFU1NfSEVWQ19TTElDRV9QQVJBTVMsCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgLmRpbXMgICA9IHsgMSB9LAo+ICAgICAgICAgICAgICAgICAgfSwK PiAgICAgICAgICAgICAgICAgIC5jb2RlYyAgICAgICAgICA9IENFRFJVU19DT0RFQ19IMjY1LAo+ ICAgICAgICAgIH0sCj4gICAKPj4+ICAgCQlicmVhazsKPj4+ICAgCWNhc2UgVjRMMl9DSURfU1RB VEVMRVNTX0hFVkNfU0NBTElOR19NQVRSSVg6Cj4+PiAgIAkJKnR5cGUgPSBWNEwyX0NUUkxfVFlQ RV9IRVZDX1NDQUxJTkdfTUFUUklYOwo+Pj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbWVkaWEvaGV2 Yy1jdHJscy5oIGIvaW5jbHVkZS9tZWRpYS9oZXZjLWN0cmxzLmgKPj4+IGluZGV4IDBkYmQ1ZDY4 MWMyOC4uMTQwMTUxNjA5Yzk2IDEwMDY0NAo+Pj4gLS0tIGEvaW5jbHVkZS9tZWRpYS9oZXZjLWN0 cmxzLmgKPj4+ICsrKyBiL2luY2x1ZGUvbWVkaWEvaGV2Yy1jdHJscy5oCj4+PiBAQCAtMzExLDkg KzMxMSwxNCBAQCBzdHJ1Y3QgdjRsMl9oZXZjX3ByZWRfd2VpZ2h0X3RhYmxlIHsKPj4+ICAgI2Rl ZmluZQo+IFY0TDJfSEVWQ19TTElDRV9QQVJBTVNfRkxBR19TTElDRV9MT09QX0ZJTFRFUl9BQ1JP U1NfU0xJQ0VTX0VOQUJMRUQKPj4gKDFVTEwgPDwgOCkKPj4+ICAgI2RlZmluZSBWNEwyX0hFVkNf U0xJQ0VfUEFSQU1TX0ZMQUdfREVQRU5ERU5UX1NMSUNFX1NFR01FTlQJKDFVTEwgPDwKPj4gOSkK Pj4+ICAgCj4+PiArI2RlZmluZSBWNEwyX0hFVkNfU0xJQ0VfTUFYX0NPVU5UCTYwMAo+Pj4gKwo+ Pj4gICAvKioKPj4+ICAgICogdjRsMl9jdHJsX2hldmNfc2xpY2VfcGFyYW1zIC0gSEVWQyBzbGlj ZSBwYXJhbWV0ZXJzCj4+PiAgICAqCj4+PiArICogVGhpcyBjb250cm9sIGlzIGEgZHluYW1pY2Fs bHkgc2l6ZWQgMS1kaW1lbnNpb25hbCBhcnJheSwKPj4+ICsgKiBWNEwyX0NUUkxfRkxBR19EWU5B TUlDX0FSUkFZIGZsYWcgbXVzdCBiZSBzZXQgd2hlbiB1c2luZyBpdC4KPj4+ICsgKgo+Pj4gICAg KiBAYml0X3NpemU6IHNpemUgKGluIGJpdHMpIG9mIHRoZSBjdXJyZW50IHNsaWNlIGRhdGEKPj4+ ICAgICogQGRhdGFfYml0X29mZnNldDogb2Zmc2V0IChpbiBiaXRzKSB0byB0aGUgdmlkZW8gZGF0 YSBpbiB0aGUgY3VycmVudAo+IHNsaWNlCj4+IGRhdGEKPj4+ICAgICogQG5hbF91bml0X3R5cGU6 IHNwZWNpZmllcyB0aGUgY29kaW5nIHR5cGUgb2YgdGhlIHNsaWNlIChCLCBQIG9yIEkpCj4+PiAt LSAKPj4+IDIuMzIuMAo+Pj4KPj4+Cj4+Cj4+Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcgbGlzdApMaW51eC1y b2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95B2B2562; Wed, 1 Jun 2022 16:03:03 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: benjamin.gaignard) with ESMTPSA id 2B4D71F4104F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1654099375; bh=QstXEK7vK9peaXuxwekF4t4rKyDGtTDzVurNPkvZNRU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bdRflAAGzQHFImM59JNtJ14nwKlXDWazj5QOV2ETaiLTpb2k/9J8u3r9Q5bGn8Qdw FC4bX0OMU0Y6K5p4xrIjBMciBTuirqvcXSNPkQx/lKv9+lVnim8QB4OUl9/E0/glqi 64l71Rs9K5i+dVo8LibUxoP0iwXOYpuooJ1hpeXLtWvw3R/PYHL7keG0PZvOWka0BS j+BkhVmKdBGpV07VDbzUzsflGoJZ1vgTOM0EFHWKSbp5NXogW58iSE4+ZcMIglwIX9 PfH0zADgzTol8Agsap2/mYLdR3/YjcSPDAjolLhoN0r6520Yt1CUp44gr0+Xt0kC4Q rLucgpnxOH9sA== Message-ID: Date: Wed, 1 Jun 2022 18:02:52 +0200 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v6 09/17] media: uapi: HEVC: Define V4L2_CID_STATELESS_HEVC_SLICE_PARAMS as a dynamic array Content-Language: en-US To: =?UTF-8?Q?Jernej_=c5=a0krabec?= , mchehab@kernel.org, hverkuil@xs4all.nl, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, samuel@sholland.org, nicolas.dufresne@collabora.com, andrzej.p@collabora.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com References: <20220527143134.3360174-1-benjamin.gaignard@collabora.com> <20220527143134.3360174-10-benjamin.gaignard@collabora.com> <2630478.mvXUDI8C0e@kista> <8069971.T7Z3S40VBb@kista> From: Benjamin Gaignard In-Reply-To: <8069971.T7Z3S40VBb@kista> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Le 01/06/2022 à 17:43, Jernej Škrabec a écrit : > Dne nedelja, 29. maj 2022 ob 11:19:12 CEST je Jernej Škrabec napisal(a): >> Dne petek, 27. maj 2022 ob 16:31:26 CEST je Benjamin Gaignard napisal(a): >>> Make explicit that V4L2_CID_STATELESS_HEVC_SLICE_PARAMS control is >>> a dynamic array control type. >>> Some drivers may be able to receive multiple slices in one control >>> to improve decoding performance. >>> >>> Define the max size of the dynamic that can driver can set in .dims = {}. >>> >>> Signed-off-by: Benjamin Gaignard >>> --- >>> version 6: >>> - Set V4L2_CTRL_FLAG_DYNAMIC_ARRAY flag automatically when using >>> V4L2_CID_STATELESS_HEVC_SLICE_PARAMS control. >>> - Add a define for max slices count >>> >>> Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 2 ++ >>> drivers/media/v4l2-core/v4l2-ctrls-defs.c | 1 + >>> include/media/hevc-ctrls.h | 5 +++++ >>> 3 files changed, 8 insertions(+) >>> >>> diff --git a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst b/ >> Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >>> index 06b967de140c..0796b1563daa 100644 >>> --- a/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >>> +++ b/Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst >>> @@ -2986,6 +2986,8 @@ enum v4l2_mpeg_video_hevc_size_of_length_field - >>> These bitstream parameters are defined according to :ref:`hevc`. >>> They are described in section 7.4.7 "General slice segment header >>> semantics" of the specification. >>> + This control is a dynamically sized 1-dimensional array, >>> + V4L2_CTRL_FLAG_DYNAMIC_ARRAY flag must be set when using it. >>> >>> .. c:type:: v4l2_ctrl_hevc_slice_params >>> >>> diff --git a/drivers/media/v4l2-core/v4l2-ctrls-defs.c b/drivers/media/ > v4l2- >> core/v4l2-ctrls-defs.c >>> index 9f55503cd3d6..d594efbcbb93 100644 >>> --- a/drivers/media/v4l2-core/v4l2-ctrls-defs.c >>> +++ b/drivers/media/v4l2-core/v4l2-ctrls-defs.c >>> @@ -1510,6 +1510,7 @@ void v4l2_ctrl_fill(u32 id, const char **name, enum >> v4l2_ctrl_type *type, >>> break; >>> case V4L2_CID_STATELESS_HEVC_SLICE_PARAMS: >>> *type = V4L2_CTRL_TYPE_HEVC_SLICE_PARAMS; >>> + *flags |= V4L2_CTRL_FLAG_DYNAMIC_ARRAY; >> This change breaks Cedrus. I'll check what needs to be changed. > Please include the change bellow to keep Cedrus working. I'll expand support > for more slices later. That will be in version 7. Thanks. I will wait for more reviews on the others patches before send it. Regards, Benjamin > > Best regards, > Jernej > > --- a/drivers/staging/media/sunxi/cedrus/cedrus.c > +++ b/drivers/staging/media/sunxi/cedrus/cedrus.c > @@ -178,6 +178,7 @@ static const struct cedrus_control cedrus_controls[] = { > { > .cfg = { > .id = V4L2_CID_STATELESS_HEVC_SLICE_PARAMS, > + .dims = { 1 }, > }, > .codec = CEDRUS_CODEC_H265, > }, > >>> break; >>> case V4L2_CID_STATELESS_HEVC_SCALING_MATRIX: >>> *type = V4L2_CTRL_TYPE_HEVC_SCALING_MATRIX; >>> diff --git a/include/media/hevc-ctrls.h b/include/media/hevc-ctrls.h >>> index 0dbd5d681c28..140151609c96 100644 >>> --- a/include/media/hevc-ctrls.h >>> +++ b/include/media/hevc-ctrls.h >>> @@ -311,9 +311,14 @@ struct v4l2_hevc_pred_weight_table { >>> #define > V4L2_HEVC_SLICE_PARAMS_FLAG_SLICE_LOOP_FILTER_ACROSS_SLICES_ENABLED >> (1ULL << 8) >>> #define V4L2_HEVC_SLICE_PARAMS_FLAG_DEPENDENT_SLICE_SEGMENT (1ULL << >> 9) >>> >>> +#define V4L2_HEVC_SLICE_MAX_COUNT 600 >>> + >>> /** >>> * v4l2_ctrl_hevc_slice_params - HEVC slice parameters >>> * >>> + * This control is a dynamically sized 1-dimensional array, >>> + * V4L2_CTRL_FLAG_DYNAMIC_ARRAY flag must be set when using it. >>> + * >>> * @bit_size: size (in bits) of the current slice data >>> * @data_bit_offset: offset (in bits) to the video data in the current > slice >> data >>> * @nal_unit_type: specifies the coding type of the slice (B, P or I) >>> -- >>> 2.32.0 >>> >>> >> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE1C3C43334 for ; Wed, 1 Jun 2022 16:04:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1NkF6FOtRVhEvslqOBfy/gn/jqhWjsr4lMl7S5+YmDE=; b=wceMjQMBr+IXeF CivYmqbPGGNDRw2tAwDE9Z0ces4BsntLCHx36YGhBbBpQdWAuaajCHlw4klHvuFfu+kaiF8/bCy6q AxgLkJ2Ff9Dd53D7EsdWT0rDXZVhH8kdjRvdd+2EnD4OAaGmJxR4B2NjtHEZVHS0NX+Igd7l3YNOA 7qmA2frItGXeiz146y9r1mqgfVrRewJMBXwO9NkGG30Ahkoe8zo1DYBV2U7TKdX3L3KTvw8HdFTJi rALq7XalMDIdAPPlIzcmOiGs0ee2q1L6BFA6GdmNbkq0fqsOp3PpGkO3r3RyxaHLGXJ+yaByK2mI1 g1FVB/tvpl7pcYGcOC/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwQoK-00H0sX-D7; Wed, 01 Jun 2022 16:03:04 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nwQoF-00H0r2-NT; Wed, 01 Jun 2022 16:03:01 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: benjamin.gaignard) with ESMTPSA id 2B4D71F4104F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1654099375; bh=QstXEK7vK9peaXuxwekF4t4rKyDGtTDzVurNPkvZNRU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bdRflAAGzQHFImM59JNtJ14nwKlXDWazj5QOV2ETaiLTpb2k/9J8u3r9Q5bGn8Qdw FC4bX0OMU0Y6K5p4xrIjBMciBTuirqvcXSNPkQx/lKv9+lVnim8QB4OUl9/E0/glqi 64l71Rs9K5i+dVo8LibUxoP0iwXOYpuooJ1hpeXLtWvw3R/PYHL7keG0PZvOWka0BS j+BkhVmKdBGpV07VDbzUzsflGoJZ1vgTOM0EFHWKSbp5NXogW58iSE4+ZcMIglwIX9 PfH0zADgzTol8Agsap2/mYLdR3/YjcSPDAjolLhoN0r6520Yt1CUp44gr0+Xt0kC4Q rLucgpnxOH9sA== Message-ID: Date: Wed, 1 Jun 2022 18:02:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v6 09/17] media: uapi: HEVC: Define V4L2_CID_STATELESS_HEVC_SLICE_PARAMS as a dynamic array Content-Language: en-US To: =?UTF-8?Q?Jernej_=c5=a0krabec?= , mchehab@kernel.org, hverkuil@xs4all.nl, ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de, gregkh@linuxfoundation.org, mripard@kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, samuel@sholland.org, nicolas.dufresne@collabora.com, andrzej.p@collabora.com Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, kernel@collabora.com References: <20220527143134.3360174-1-benjamin.gaignard@collabora.com> <20220527143134.3360174-10-benjamin.gaignard@collabora.com> <2630478.mvXUDI8C0e@kista> <8069971.T7Z3S40VBb@kista> From: Benjamin Gaignard In-Reply-To: <8069971.T7Z3S40VBb@kista> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220601_090300_072651_2FA724D2 X-CRM114-Status: GOOD ( 18.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CkxlIDAxLzA2LzIwMjIgw6AgMTc6NDMsIEplcm5laiDFoGtyYWJlYyBhIMOpY3JpdMKgOgo+IERu ZSBuZWRlbGphLCAyOS4gbWFqIDIwMjIgb2IgMTE6MTk6MTIgQ0VTVCBqZSBKZXJuZWogxaBrcmFi ZWMgbmFwaXNhbChhKToKPj4gRG5lIHBldGVrLCAyNy4gbWFqIDIwMjIgb2IgMTY6MzE6MjYgQ0VT VCBqZSBCZW5qYW1pbiBHYWlnbmFyZCBuYXBpc2FsKGEpOgo+Pj4gTWFrZSBleHBsaWNpdCB0aGF0 IFY0TDJfQ0lEX1NUQVRFTEVTU19IRVZDX1NMSUNFX1BBUkFNUyBjb250cm9sIGlzCj4+PiBhIGR5 bmFtaWMgYXJyYXkgY29udHJvbCB0eXBlLgo+Pj4gU29tZSBkcml2ZXJzIG1heSBiZSBhYmxlIHRv IHJlY2VpdmUgbXVsdGlwbGUgc2xpY2VzIGluIG9uZSBjb250cm9sCj4+PiB0byBpbXByb3ZlIGRl Y29kaW5nIHBlcmZvcm1hbmNlLgo+Pj4KPj4+IERlZmluZSB0aGUgbWF4IHNpemUgb2YgdGhlIGR5 bmFtaWMgdGhhdCBjYW4gZHJpdmVyIGNhbiBzZXQgaW4gLmRpbXMgPSB7fS4KPj4+Cj4+PiBTaWdu ZWQtb2ZmLWJ5OiBCZW5qYW1pbiBHYWlnbmFyZCA8YmVuamFtaW4uZ2FpZ25hcmRAY29sbGFib3Jh LmNvbT4KPj4+IC0tLQo+Pj4gdmVyc2lvbiA2Ogo+Pj4gLSBTZXQgVjRMMl9DVFJMX0ZMQUdfRFlO QU1JQ19BUlJBWSBmbGFnIGF1dG9tYXRpY2FsbHkgd2hlbiB1c2luZwo+Pj4gICAgVjRMMl9DSURf U1RBVEVMRVNTX0hFVkNfU0xJQ0VfUEFSQU1TIGNvbnRyb2wuCj4+PiAtIEFkZCBhIGRlZmluZSBm b3IgbWF4IHNsaWNlcyBjb3VudAo+Pj4KPj4+ICAgRG9jdW1lbnRhdGlvbi91c2Vyc3BhY2UtYXBp L21lZGlhL3Y0bC9leHQtY3RybHMtY29kZWMucnN0IHwgMiArKwo+Pj4gICBkcml2ZXJzL21lZGlh L3Y0bDItY29yZS92NGwyLWN0cmxzLWRlZnMuYyAgICAgICAgICAgICAgICAgfCAxICsKPj4+ICAg aW5jbHVkZS9tZWRpYS9oZXZjLWN0cmxzLmggICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IHwgNSArKysrKwo+Pj4gICAzIGZpbGVzIGNoYW5nZWQsIDggaW5zZXJ0aW9ucygrKQo+Pj4KPj4+ IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL3VzZXJzcGFjZS1hcGkvbWVkaWEvdjRsL2V4dC1j dHJscy1jb2RlYy5yc3QgYi8KPj4gRG9jdW1lbnRhdGlvbi91c2Vyc3BhY2UtYXBpL21lZGlhL3Y0 bC9leHQtY3RybHMtY29kZWMucnN0Cj4+PiBpbmRleCAwNmI5NjdkZTE0MGMuLjA3OTZiMTU2M2Rh YSAxMDA2NDQKPj4+IC0tLSBhL0RvY3VtZW50YXRpb24vdXNlcnNwYWNlLWFwaS9tZWRpYS92NGwv ZXh0LWN0cmxzLWNvZGVjLnJzdAo+Pj4gKysrIGIvRG9jdW1lbnRhdGlvbi91c2Vyc3BhY2UtYXBp L21lZGlhL3Y0bC9leHQtY3RybHMtY29kZWMucnN0Cj4+PiBAQCAtMjk4Niw2ICsyOTg2LDggQEAg ZW51bSB2NGwyX21wZWdfdmlkZW9faGV2Y19zaXplX29mX2xlbmd0aF9maWVsZCAtCj4+PiAgICAg ICBUaGVzZSBiaXRzdHJlYW0gcGFyYW1ldGVycyBhcmUgZGVmaW5lZCBhY2NvcmRpbmcgdG8gOnJl ZjpgaGV2Y2AuCj4+PiAgICAgICBUaGV5IGFyZSBkZXNjcmliZWQgaW4gc2VjdGlvbiA3LjQuNyAi R2VuZXJhbCBzbGljZSBzZWdtZW50IGhlYWRlcgo+Pj4gICAgICAgc2VtYW50aWNzIiBvZiB0aGUg c3BlY2lmaWNhdGlvbi4KPj4+ICsgICAgVGhpcyBjb250cm9sIGlzIGEgZHluYW1pY2FsbHkgc2l6 ZWQgMS1kaW1lbnNpb25hbCBhcnJheSwKPj4+ICsgICAgVjRMMl9DVFJMX0ZMQUdfRFlOQU1JQ19B UlJBWSBmbGFnIG11c3QgYmUgc2V0IHdoZW4gdXNpbmcgaXQuCj4+PiAgIAo+Pj4gICAuLiBjOnR5 cGU6OiB2NGwyX2N0cmxfaGV2Y19zbGljZV9wYXJhbXMKPj4+ICAgCj4+PiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9tZWRpYS92NGwyLWNvcmUvdjRsMi1jdHJscy1kZWZzLmMgYi9kcml2ZXJzL21lZGlh Lwo+IHY0bDItCj4+IGNvcmUvdjRsMi1jdHJscy1kZWZzLmMKPj4+IGluZGV4IDlmNTU1MDNjZDNk Ni4uZDU5NGVmYmNiYjkzIDEwMDY0NAo+Pj4gLS0tIGEvZHJpdmVycy9tZWRpYS92NGwyLWNvcmUv djRsMi1jdHJscy1kZWZzLmMKPj4+ICsrKyBiL2RyaXZlcnMvbWVkaWEvdjRsMi1jb3JlL3Y0bDIt Y3RybHMtZGVmcy5jCj4+PiBAQCAtMTUxMCw2ICsxNTEwLDcgQEAgdm9pZCB2NGwyX2N0cmxfZmls bCh1MzIgaWQsIGNvbnN0IGNoYXIgKipuYW1lLCBlbnVtCj4+IHY0bDJfY3RybF90eXBlICp0eXBl LAo+Pj4gICAJCWJyZWFrOwo+Pj4gICAJY2FzZSBWNEwyX0NJRF9TVEFURUxFU1NfSEVWQ19TTElD RV9QQVJBTVM6Cj4+PiAgIAkJKnR5cGUgPSBWNEwyX0NUUkxfVFlQRV9IRVZDX1NMSUNFX1BBUkFN UzsKPj4+ICsJCSpmbGFncyB8PSBWNEwyX0NUUkxfRkxBR19EWU5BTUlDX0FSUkFZOwo+PiBUaGlz IGNoYW5nZSBicmVha3MgQ2VkcnVzLiBJJ2xsIGNoZWNrIHdoYXQgbmVlZHMgdG8gYmUgY2hhbmdl ZC4KPiBQbGVhc2UgaW5jbHVkZSB0aGUgY2hhbmdlIGJlbGxvdyB0byBrZWVwIENlZHJ1cyB3b3Jr aW5nLiBJJ2xsIGV4cGFuZCBzdXBwb3J0Cj4gZm9yIG1vcmUgc2xpY2VzIGxhdGVyLgoKVGhhdCB3 aWxsIGJlIGluIHZlcnNpb24gNy4gVGhhbmtzLgpJIHdpbGwgd2FpdCBmb3IgbW9yZSByZXZpZXdz IG9uIHRoZSBvdGhlcnMgcGF0Y2hlcyBiZWZvcmUgc2VuZCBpdC4KClJlZ2FyZHMsCkJlbmphbWlu Cgo+Cj4gICBCZXN0IHJlZ2FyZHMsCj4gICBKZXJuZWoKPgo+IC0tLSBhL2RyaXZlcnMvc3RhZ2lu Zy9tZWRpYS9zdW54aS9jZWRydXMvY2VkcnVzLmMKPiArKysgYi9kcml2ZXJzL3N0YWdpbmcvbWVk aWEvc3VueGkvY2VkcnVzL2NlZHJ1cy5jCj4gQEAgLTE3OCw2ICsxNzgsNyBAQCBzdGF0aWMgY29u c3Qgc3RydWN0IGNlZHJ1c19jb250cm9sIGNlZHJ1c19jb250cm9sc1tdID0gewo+ICAgICAgICAg IHsKPiAgICAgICAgICAgICAgICAgIC5jZmcgPSB7Cj4gICAgICAgICAgICAgICAgICAgICAgICAg IC5pZCAgICAgPSBWNEwyX0NJRF9TVEFURUxFU1NfSEVWQ19TTElDRV9QQVJBTVMsCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgLmRpbXMgICA9IHsgMSB9LAo+ICAgICAgICAgICAgICAgICAgfSwK PiAgICAgICAgICAgICAgICAgIC5jb2RlYyAgICAgICAgICA9IENFRFJVU19DT0RFQ19IMjY1LAo+ ICAgICAgICAgIH0sCj4gICAKPj4+ICAgCQlicmVhazsKPj4+ICAgCWNhc2UgVjRMMl9DSURfU1RB VEVMRVNTX0hFVkNfU0NBTElOR19NQVRSSVg6Cj4+PiAgIAkJKnR5cGUgPSBWNEwyX0NUUkxfVFlQ RV9IRVZDX1NDQUxJTkdfTUFUUklYOwo+Pj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbWVkaWEvaGV2 Yy1jdHJscy5oIGIvaW5jbHVkZS9tZWRpYS9oZXZjLWN0cmxzLmgKPj4+IGluZGV4IDBkYmQ1ZDY4 MWMyOC4uMTQwMTUxNjA5Yzk2IDEwMDY0NAo+Pj4gLS0tIGEvaW5jbHVkZS9tZWRpYS9oZXZjLWN0 cmxzLmgKPj4+ICsrKyBiL2luY2x1ZGUvbWVkaWEvaGV2Yy1jdHJscy5oCj4+PiBAQCAtMzExLDkg KzMxMSwxNCBAQCBzdHJ1Y3QgdjRsMl9oZXZjX3ByZWRfd2VpZ2h0X3RhYmxlIHsKPj4+ICAgI2Rl ZmluZQo+IFY0TDJfSEVWQ19TTElDRV9QQVJBTVNfRkxBR19TTElDRV9MT09QX0ZJTFRFUl9BQ1JP U1NfU0xJQ0VTX0VOQUJMRUQKPj4gKDFVTEwgPDwgOCkKPj4+ICAgI2RlZmluZSBWNEwyX0hFVkNf U0xJQ0VfUEFSQU1TX0ZMQUdfREVQRU5ERU5UX1NMSUNFX1NFR01FTlQJKDFVTEwgPDwKPj4gOSkK Pj4+ICAgCj4+PiArI2RlZmluZSBWNEwyX0hFVkNfU0xJQ0VfTUFYX0NPVU5UCTYwMAo+Pj4gKwo+ Pj4gICAvKioKPj4+ICAgICogdjRsMl9jdHJsX2hldmNfc2xpY2VfcGFyYW1zIC0gSEVWQyBzbGlj ZSBwYXJhbWV0ZXJzCj4+PiAgICAqCj4+PiArICogVGhpcyBjb250cm9sIGlzIGEgZHluYW1pY2Fs bHkgc2l6ZWQgMS1kaW1lbnNpb25hbCBhcnJheSwKPj4+ICsgKiBWNEwyX0NUUkxfRkxBR19EWU5B TUlDX0FSUkFZIGZsYWcgbXVzdCBiZSBzZXQgd2hlbiB1c2luZyBpdC4KPj4+ICsgKgo+Pj4gICAg KiBAYml0X3NpemU6IHNpemUgKGluIGJpdHMpIG9mIHRoZSBjdXJyZW50IHNsaWNlIGRhdGEKPj4+ ICAgICogQGRhdGFfYml0X29mZnNldDogb2Zmc2V0IChpbiBiaXRzKSB0byB0aGUgdmlkZW8gZGF0 YSBpbiB0aGUgY3VycmVudAo+IHNsaWNlCj4+IGRhdGEKPj4+ICAgICogQG5hbF91bml0X3R5cGU6 IHNwZWNpZmllcyB0aGUgY29kaW5nIHR5cGUgb2YgdGhlIHNsaWNlIChCLCBQIG9yIEkpCj4+PiAt LSAKPj4+IDIuMzIuMAo+Pj4KPj4+Cj4+Cj4+Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4 LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK