From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Saenz Julienne Date: Fri, 21 Feb 2020 11:57:06 +0100 Subject: [PATCH] net: bcmgenet: Don't set ID_MODE_DIS when not using RGMII In-Reply-To: <95fa3b2e-b317-fe1f-37af-4a44560e1f10@gmail.com> References: <20200220163630.29806-1-nsaenzjulienne@suse.de> <95fa3b2e-b317-fe1f-37af-4a44560e1f10@gmail.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Florian, On Thu, 2020-02-20 at 11:05 -0800, Florian Fainelli wrote: > On 2/20/20 8:36 AM, Nicolas Saenz Julienne wrote: > > As per Linux's driver, ID_MODE_DIS is only set when the PHY interface is > > RGMII. Don't enable it for the rest of setups. > > > > This has been seen to misconfigure RPi4's PHY when booting Linux. > > > > Signed-off-by: Nicolas Saenz Julienne > > Does the failure look like the following: you have a driver for the > Broadcom PHY used on the Pi4 in u-boot, and the phy_dev->interface value > is being used to configure the Ethernet PHY chip in a certain way. > > Later when you boot Linux, you do not have CONFIG_BROADCOM_PHY enabled > so the Generic PHY driver gets used instead, and there is a disagreement > between the AMAC and PHY as to whom should be adding the delays? I added an explanation to Matthias' response. I think it fits yours, modulo my limited knowledge in the area :) > At any rate: > > Reviewed-by: Florian Fainelli Thanks! Regards, Nicolas -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: This is a digitally signed message part URL: