From: Brian Masney <bmasney@redhat.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: Simplify clk_is_match()
Date: Mon, 9 Mar 2026 11:13:00 -0400 [thread overview]
Message-ID: <aa7jfB2I0veouYTe@redhat.com> (raw)
In-Reply-To: <703be6fe95cad2e738c712877fcdaa63a7809802.1772705499.git.geert+renesas@glider.be>
On Thu, Mar 05, 2026 at 11:12:33AM +0100, Geert Uytterhoeven wrote:
> Linux style is to handle early-on failure. Inverting the first
> condition lets us simplify the second, and improves readability.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Brian Masney <bmasney@redhat.com>
Stephen: There are 8 places in clk_test.c where clk_is_match() is
called, so I feel we should be good testing coverage wise.
next prev parent reply other threads:[~2026-03-09 15:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-05 10:12 [PATCH] clk: Simplify clk_is_match() Geert Uytterhoeven
2026-03-09 15:13 ` Brian Masney [this message]
2026-03-24 0:19 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa7jfB2I0veouYTe@redhat.com \
--to=bmasney@redhat.com \
--cc=geert+renesas@glider.be \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.