From: Can Guo <cang@codeaurora.org>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, Bart Van Assche <bvanassche@acm.org>,
yongmyung lee <ymhungry.lee@samsung.com>,
Daejun Park <daejun7.park@samsung.com>,
alim.akhtar@samsung.com, asutoshd@codeaurora.org,
Zang Leigang <zangleigang@hisilicon.com>,
Avi Shchislowski <Avi.Shchislowski@wdc.com>,
Bean Huo <beanhuo@micron.com>,
stanley.chu@mediatek.com
Subject: Re: [PATCH v5 03/10] scsi: ufshpb: Add region's reads counter
Date: Mon, 15 Mar 2021 17:31:10 +0800 [thread overview]
Message-ID: <aa82d7011c102b5d0991cad8908ac9ee@codeaurora.org> (raw)
In-Reply-To: <DM6PR04MB6575A58446F1EB9ABDFBB7A6FC6C9@DM6PR04MB6575.namprd04.prod.outlook.com>
On 2021-03-15 17:20, Avri Altman wrote:
>> > +
>> > + if (hpb->is_hcm) {
>> > + spin_lock_irqsave(&rgn->rgn_lock, flags);
>>
>> rgn_lock is never used in IRQ contexts, so no need of irqsave and
>> irqrestore everywhere, which can impact performance. Please correct
>> me if I am wrong.
> Thanks. Will do.
>
>>
>> Meanwhile, have you ever initialized the rgn_lock before use it???
> Yep - forgot to do that here (but not in gs20 and mi10). Thanks.
You mean you didn't test this specific series before upload?
I haven't moved to the test stage, but this will definitely
cause you error...
Can Guo.
>
> Thanks,
> Avri
>
>>
>> Thanks,
>> Can Guo.
>>
>> > + rgn->reads = 0;
>> > + spin_unlock_irqrestore(&rgn->rgn_lock, flags);
>> > + }
>> > +
>> > return 0;
>> > }
>> >
>> > if (!ufshpb_is_support_chunk(hpb, transfer_len))
>> > return 0;
>> >
>> > + if (hpb->is_hcm) {
>> > + bool activate = false;
>> > + /*
>> > + * in host control mode, reads are the main source for
>> > + * activation trials.
>> > + */
>> > + spin_lock_irqsave(&rgn->rgn_lock, flags);
>> > + rgn->reads++;
>> > + if (rgn->reads == ACTIVATION_THRESHOLD)
>> > + activate = true;
>> > + spin_unlock_irqrestore(&rgn->rgn_lock, flags);
>> > + if (activate) {
>> > + spin_lock_irqsave(&hpb->rsp_list_lock, flags);
>> > + ufshpb_update_active_info(hpb, rgn_idx, srgn_idx);
>> > + hpb->stats.rb_active_cnt++;
>> > + spin_unlock_irqrestore(&hpb->rsp_list_lock, flags);
>> > + dev_dbg(&hpb->sdev_ufs_lu->sdev_dev,
>> > + "activate region %d-%d\n", rgn_idx, srgn_idx);
>> > + }
>> > +
>> > + /* keep those counters normalized */
>> > + if (rgn->reads > hpb->entries_per_srgn)
>> > + schedule_work(&hpb->ufshpb_normalization_work);
>> > + }
>> > +
>> > spin_lock_irqsave(&hpb->rgn_state_lock, flags);
>> > if (ufshpb_test_ppn_dirty(hpb, rgn_idx, srgn_idx, srgn_offset,
>> > transfer_len)) {
>> > @@ -745,21 +794,6 @@ static int ufshpb_clear_dirty_bitmap(struct
>> > ufshpb_lu *hpb,
>> > return 0;
>> > }
>> >
>> > -static void ufshpb_update_active_info(struct ufshpb_lu *hpb, int
>> > rgn_idx,
>> > - int srgn_idx)
>> > -{
>> > - struct ufshpb_region *rgn;
>> > - struct ufshpb_subregion *srgn;
>> > -
>> > - rgn = hpb->rgn_tbl + rgn_idx;
>> > - srgn = rgn->srgn_tbl + srgn_idx;
>> > -
>> > - list_del_init(&rgn->list_inact_rgn);
>> > -
>> > - if (list_empty(&srgn->list_act_srgn))
>> > - list_add_tail(&srgn->list_act_srgn, &hpb->lh_act_srgn);
>> > -}
>> > -
>> > static void ufshpb_update_inactive_info(struct ufshpb_lu *hpb, int
>> > rgn_idx)
>> > {
>> > struct ufshpb_region *rgn;
>> > @@ -1079,6 +1113,14 @@ static void __ufshpb_evict_region(struct
>> > ufshpb_lu *hpb,
>> >
>> > ufshpb_cleanup_lru_info(lru_info, rgn);
>> >
>> > + if (hpb->is_hcm) {
>> > + unsigned long flags;
>> > +
>> > + spin_lock_irqsave(&rgn->rgn_lock, flags);
>> > + rgn->reads = 0;
>> > + spin_unlock_irqrestore(&rgn->rgn_lock, flags);
>> > + }
>> > +
>> > for_each_sub_region(rgn, srgn_idx, srgn)
>> > ufshpb_purge_active_subregion(hpb, srgn);
>> > }
>> > @@ -1523,6 +1565,31 @@ static void
>> > ufshpb_run_inactive_region_list(struct ufshpb_lu *hpb)
>> > spin_unlock_irqrestore(&hpb->rsp_list_lock, flags);
>> > }
>> >
>> > +static void ufshpb_normalization_work_handler(struct work_struct
>> > *work)
>> > +{
>> > + struct ufshpb_lu *hpb;
>> > + int rgn_idx;
>> > + unsigned long flags;
>> > +
>> > + hpb = container_of(work, struct ufshpb_lu,
>> > ufshpb_normalization_work);
>> > +
>> > + for (rgn_idx = 0; rgn_idx < hpb->rgns_per_lu; rgn_idx++) {
>> > + struct ufshpb_region *rgn = hpb->rgn_tbl + rgn_idx;
>> > +
>> > + spin_lock_irqsave(&rgn->rgn_lock, flags);
>> > + rgn->reads = (rgn->reads >> 1);
>> > + spin_unlock_irqrestore(&rgn->rgn_lock, flags);
>> > +
>> > + if (rgn->rgn_state != HPB_RGN_ACTIVE || rgn->reads)
>> > + continue;
>> > +
>> > + /* if region is active but has no reads - inactivate it */
>> > + spin_lock(&hpb->rsp_list_lock);
>> > + ufshpb_update_inactive_info(hpb, rgn->rgn_idx);
>> > + spin_unlock(&hpb->rsp_list_lock);
>> > + }
>> > +}
>> > +
>> > static void ufshpb_map_work_handler(struct work_struct *work)
>> > {
>> > struct ufshpb_lu *hpb = container_of(work, struct ufshpb_lu,
>> > map_work);
>> > @@ -1913,6 +1980,9 @@ static int ufshpb_lu_hpb_init(struct ufs_hba
>> > *hba, struct ufshpb_lu *hpb)
>> > INIT_LIST_HEAD(&hpb->list_hpb_lu);
>> >
>> > INIT_WORK(&hpb->map_work, ufshpb_map_work_handler);
>> > + if (hpb->is_hcm)
>> > + INIT_WORK(&hpb->ufshpb_normalization_work,
>> > + ufshpb_normalization_work_handler);
>> >
>> > hpb->map_req_cache = kmem_cache_create("ufshpb_req_cache",
>> > sizeof(struct ufshpb_req), 0, 0, NULL);
>> > @@ -2012,6 +2082,8 @@ static void ufshpb_discard_rsp_lists(struct
>> > ufshpb_lu *hpb)
>> >
>> > static void ufshpb_cancel_jobs(struct ufshpb_lu *hpb)
>> > {
>> > + if (hpb->is_hcm)
>> > + cancel_work_sync(&hpb->ufshpb_normalization_work);
>> > cancel_work_sync(&hpb->map_work);
>> > }
>> >
>> > diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
>> > index 8119b1a3d1e5..bd4308010466 100644
>> > --- a/drivers/scsi/ufs/ufshpb.h
>> > +++ b/drivers/scsi/ufs/ufshpb.h
>> > @@ -121,6 +121,10 @@ struct ufshpb_region {
>> > struct list_head list_lru_rgn;
>> > unsigned long rgn_flags;
>> > #define RGN_FLAG_DIRTY 0
>> > +
>> > + /* region reads - for host mode */
>> > + spinlock_t rgn_lock;
>> > + unsigned int reads;
>> > };
>> >
>> > #define for_each_sub_region(rgn, i, srgn) \
>> > @@ -211,6 +215,7 @@ struct ufshpb_lu {
>> >
>> > /* for selecting victim */
>> > struct victim_select_info lru_info;
>> > + struct work_struct ufshpb_normalization_work;
>> >
>> > /* pinned region information */
>> > u32 lu_pinned_start;
next prev parent reply other threads:[~2021-03-15 9:32 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 13:24 [PATCH v5 00/10] Add Host control mode to HPB Avri Altman
2021-03-02 13:24 ` [PATCH v5 01/10] scsi: ufshpb: Cache HPB Control mode on init Avri Altman
2021-03-02 13:24 ` [PATCH v5 02/10] scsi: ufshpb: Add host control mode support to rsp_upiu Avri Altman
2021-03-02 13:24 ` [PATCH v5 03/10] scsi: ufshpb: Add region's reads counter Avri Altman
2021-03-11 7:52 ` Can Guo
2021-03-11 8:04 ` Avri Altman
2021-03-11 8:07 ` Can Guo
2021-03-15 3:16 ` Can Guo
2021-03-15 9:20 ` Avri Altman
2021-03-15 9:31 ` Can Guo [this message]
2021-03-17 9:19 ` Avri Altman
2021-03-15 8:40 ` Can Guo
2021-03-15 9:22 ` Avri Altman
2021-03-02 13:24 ` [PATCH v5 04/10] scsi: ufshpb: Make eviction depends on region's reads Avri Altman
2021-03-11 7:53 ` Can Guo
2021-03-11 8:06 ` Avri Altman
2021-03-15 8:30 ` Can Guo
2021-03-16 8:34 ` Avri Altman
2021-03-02 13:24 ` [PATCH v5 05/10] scsi: ufshpb: Region inactivation in host mode Avri Altman
2021-03-11 8:20 ` Can Guo
2021-03-11 9:03 ` Avri Altman
2021-03-15 4:02 ` Can Guo
2021-03-15 7:33 ` Can Guo
2021-03-16 8:30 ` Avri Altman
2021-03-17 1:23 ` Can Guo
2021-03-17 2:28 ` Daejun Park
2021-03-17 4:41 ` Can Guo
2021-03-17 5:19 ` Daejun Park
2021-03-17 5:34 ` Can Guo
2021-03-17 5:42 ` Daejun Park
2021-03-17 7:59 ` Avri Altman
2021-03-02 13:24 ` [PATCH v5 06/10] scsi: ufshpb: Add hpb dev reset response Avri Altman
2021-03-15 1:34 ` Can Guo
2021-03-15 6:40 ` Can Guo
2021-03-15 7:42 ` Avri Altman
2021-03-17 10:56 ` Can Guo
2021-03-17 11:23 ` Avri Altman
2021-03-17 12:12 ` Can Guo
2021-03-17 12:22 ` Avri Altman
2021-03-17 13:50 ` Can Guo
2021-03-17 14:22 ` Avri Altman
2021-03-17 14:36 ` Can Guo
2021-03-17 15:46 ` Avri Altman
2021-03-18 1:00 ` Can Guo
2021-03-18 8:04 ` Avri Altman
2021-03-02 13:25 ` [PATCH v5 07/10] scsi: ufshpb: Add "Cold" regions timer Avri Altman
2021-03-15 1:37 ` Can Guo
2021-03-15 7:54 ` Avri Altman
2021-03-15 9:36 ` Can Guo
2021-03-16 9:21 ` Avri Altman
2021-03-17 2:45 ` Can Guo
2021-03-17 7:55 ` Avri Altman
2021-06-01 16:22 ` Bart Van Assche
2021-03-02 13:25 ` [PATCH v5 08/10] scsi: ufshpb: Limit the number of inflight map requests Avri Altman
2021-03-15 8:31 ` Can Guo
2021-03-16 8:32 ` Avri Altman
2021-03-02 13:25 ` [PATCH v5 09/10] scsi: ufshpb: Add support for host control mode Avri Altman
2021-03-02 13:25 ` [PATCH v5 10/10] scsi: ufshpb: Make host mode parameters configurable Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa82d7011c102b5d0991cad8908ac9ee@codeaurora.org \
--to=cang@codeaurora.org \
--cc=Avi.Shchislowski@wdc.com \
--cc=Avri.Altman@wdc.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=daejun7.park@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=ymhungry.lee@samsung.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.