From: Jens Axboe <axboe@fb.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org, jbacik@fb.com
Subject: Re: [PATCH 1/2] blk-mq: get rid of manual run of queue with __blk_mq_run_hw_queue()
Date: Thu, 22 Sep 2016 14:29:42 -0600 [thread overview]
Message-ID: <aa85fbc5-e803-5488-48ad-20cd3b7bcc45@fb.com> (raw)
In-Reply-To: <20160922185603.GA32468@infradead.org>
On 09/22/2016 12:56 PM, Christoph Hellwig wrote:
> Ok, I looked into this a bit more, and while I'm still fine with the
> patch I think it's only half of what we should do here. There really
> is no point in doing the first non-blocking path in blk_mq_map_request
> either as bt_get itself already does the non-blocking pass, and also
> runs the queue when scheduling in the later loop as well. So to get
> towards what I had in my tree we also need something like this:
Good point, I'll apply this one as well.
--
Jens Axboe
next prev parent reply other threads:[~2016-09-22 20:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 14:52 [PATCH 0/2]: Add option for async ->queue_rq Jens Axboe
2016-09-22 14:52 ` [PATCH 1/2] blk-mq: get rid of manual run of queue with __blk_mq_run_hw_queue() Jens Axboe
2016-09-22 14:56 ` Christoph Hellwig
2016-09-22 18:56 ` Christoph Hellwig
2016-09-22 20:29 ` Jens Axboe [this message]
2016-09-23 21:59 ` Sagi Grimberg
2016-09-23 21:56 ` Sagi Grimberg
2016-09-22 14:53 ` [PATCH 2/2] blk-mq: add flag for drivers wanting blocking ->queue_rq() Jens Axboe
2016-09-22 14:59 ` Christoph Hellwig
2016-09-22 15:03 ` Jens Axboe
2016-09-22 15:12 ` Christoph Hellwig
2016-09-22 15:17 ` Jens Axboe
2016-09-23 1:43 ` Ming Lei
2016-09-23 2:44 ` Josef Bacik
2016-09-23 1:35 ` Ming Lei
2016-09-22 15:04 ` Josef Bacik
2016-09-22 18:01 ` [PATCH 0/2]: Add option for async ->queue_rq Josef Bacik
2016-09-28 0:25 ` Bart Van Assche
2016-09-28 16:43 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa85fbc5-e803-5488-48ad-20cd3b7bcc45@fb.com \
--to=axboe@fb.com \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=jbacik@fb.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.