All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Kexin Sun <kexinsun@smail.nju.edu.cn>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, julia.lawall@inria.fr,
	xutong.ma@inria.fr, yunbolyu@smu.edu.sg, ratnadiraw@smu.edu.sg
Subject: Re: [PATCH net-next v2] net/hsr: update outdated comments
Date: Thu, 26 Feb 2026 13:33:12 +0000	[thread overview]
Message-ID: <aaBLmF9w7jf8pqTT@horms.kernel.org> (raw)
In-Reply-To: <20260225145159.2953-1-kexinsun@smail.nju.edu.cn>

On Wed, Feb 25, 2026 at 10:51:59PM +0800, Kexin Sun wrote:
> The function hsr_rcv() was renamed hsr_handle_frame() and moved to
> net/hsr/hsr_slave.c by commit 81ba6afd6e64 ("net/hsr: Switch from
> dev_add_pack() to netdev_rx_handler_register()").
> 
> Update all remaining references in the comments accordingly.
> 
> Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
> ---
> Hi Simon,
> 
> Regarding your question about how these were found: we are building a 
> research prototype for identifying and fixing dangling method references 
> in comments. Generally, we use Coccinelle to check for dangling references 
> and DeepSeek-V3.2 to generate the fixes. 
> 
> Since it is still a work-in-progress, we haven't settled on a proper tool 
> name yet. Therefore, I chose to omit the `Assisted-by:` tag in this v2 
> patch for now. Do you have any suggestions on what would be appropriate 
> to use in this situation?

Hi Kexin,

I think many people are experimenting.
And likewise, the use of Assisted-by is evolving.

My reading of [1] is that an Assisted-by tag is appropriate here.
I would suggest:

Assisted-by: deepseek-v3.2 coccinelle

or

Assisted-by: unnamed:deepseek-v3.2 coccinelle

[1] https://docs.kernel.org/process/coding-assistants.html


Overall, this now looks good to me.
Thanks for the update.

Reviewed-by: Simon Horman <horms@kernel.org>

  reply	other threads:[~2026-02-26 13:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 14:51 [PATCH net-next v2] net/hsr: update outdated comments Kexin Sun
2026-02-26 13:33 ` Simon Horman [this message]
2026-02-28  1:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaBLmF9w7jf8pqTT@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=julia.lawall@inria.fr \
    --cc=kexinsun@smail.nju.edu.cn \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ratnadiraw@smu.edu.sg \
    --cc=xutong.ma@inria.fr \
    --cc=yunbolyu@smu.edu.sg \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.