All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>, "Kevin Wolf" <kwolf@redhat.com>
Subject: Re: [PATCH] configure: allow PyPI access for python 'tooling' dependencies
Date: Thu, 26 Feb 2026 13:46:45 +0000	[thread overview]
Message-ID: <aaBOxS7bCODGq4Ry@redhat.com> (raw)
In-Reply-To: <20260225191255.955585-1-jsnow@redhat.com>

On Wed, Feb 25, 2026 at 02:12:55PM -0500, John Snow wrote:
> We actually do not allow our meson requirements to be fetched online
> because we strictly prefer the vendored version. Move the tooling group
> installation to a different invocation that does allow PyPI to be
> accessed when configure is run without explicitly disabling PyPI access.
> 
> This will allow QEMU to download and install python3-wheel for you if
> you don't have it in your host environment.

IOW, with this patch the behaviour is now:

  * Host  python3-wheel -> already works
  * No python3-wheel -> auto downloads
  * No python3-wheel && --disable-downloads -> fail

previously the 2nd case there was behaving the same as the
3rd  which was wrong.

> 
> Reported-by: Kevin Wolf <kwolf@redhat.com>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  configure | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com       ~~        https://hachyderm.io/@berrange :|
|: https://libvirt.org          ~~          https://entangle-photo.org :|
|: https://pixelfed.art/berrange   ~~    https://fstop138.berrange.com :|



  parent reply	other threads:[~2026-02-26 13:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-25 19:12 [PATCH] configure: allow PyPI access for python 'tooling' dependencies John Snow
2026-02-26  8:08 ` Thomas Huth
2026-02-26 13:46 ` Daniel P. Berrangé [this message]
2026-02-26 17:52   ` Peter Maydell
2026-02-26 20:45     ` John Snow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaBOxS7bCODGq4Ry@redhat.com \
    --to=berrange@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.