From: Christoph Hellwig <hch@infradead.org>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH v2 5/7] block: allow submitting all zone writes from a single context
Date: Thu, 26 Feb 2026 08:16:44 -0800 [thread overview]
Message-ID: <aaBx7GMLpFGjON_a@infradead.org> (raw)
In-Reply-To: <20260226041024.2154806-6-dlemoal@kernel.org>
On Thu, Feb 26, 2026 at 01:10:22PM +0900, Damien Le Moal wrote:
> limits the maximum size of commands to a small value, e.g. HBAs
> controlled with the mpi3mr driver limit commands to a maximum of 1 MiB.
> In such case, the write throughput gains are over 40%.
Nice numbers! Although it's a bit sad that HBA capabilities are
actually degrading with new products.
> +static ssize_t queue_zoned_qd1_writes_store(struct gendisk *disk,
> + const char *page, size_t count)
> +{
> + struct request_queue *q = disk->queue;
> + unsigned long qd1_writes;
> + unsigned int memflags;
> + ssize_t ret;
> +
> + if (!blk_queue_is_zoned(q))
> + return -EOPNOTSUPP;
I think with the attr visibility check the non-zoned case here can't
actually happen.
Otherwise this looks beautiful, thanks!
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2026-02-26 16:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 4:10 [PATCH v2 0/7] Improve zoned (SMR) HDD write throughput Damien Le Moal
2026-02-26 4:10 ` [PATCH v2 1/7] block: fix zone write plug removal Damien Le Moal
2026-02-26 16:10 ` Christoph Hellwig
2026-02-26 22:44 ` Damien Le Moal
2026-02-26 4:10 ` [PATCH v2 2/7] block: fix zone write plugs refcount handling in disk_zone_wplug_schedule_bio_work() Damien Le Moal
2026-02-26 16:11 ` Christoph Hellwig
2026-02-27 7:12 ` Johannes Thumshirn
2026-02-26 4:10 ` [PATCH v2 3/7] block: remove disk_zone_is_full() Damien Le Moal
2026-02-26 16:11 ` Christoph Hellwig
2026-02-26 4:10 ` [PATCH v2 4/7] block: rename struct gendisk zone_wplugs_lock field Damien Le Moal
2026-02-26 16:12 ` Christoph Hellwig
2026-02-26 4:10 ` [PATCH v2 5/7] block: allow submitting all zone writes from a single context Damien Le Moal
2026-02-26 16:16 ` Christoph Hellwig [this message]
2026-02-26 4:10 ` [PATCH v2 6/7] block: default to QD=1 writes for blk-mq rotational zoned devices Damien Le Moal
2026-02-26 16:16 ` Christoph Hellwig
2026-02-26 4:10 ` [PATCH v2 7/7] Documentation: ABI: stable: document the zoned_qd1_writes attribute Damien Le Moal
2026-02-26 16:17 ` Christoph Hellwig
2026-02-26 22:17 ` [PATCH v2 0/7] Improve zoned (SMR) HDD write throughput Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaBx7GMLpFGjON_a@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.