From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 811ADFD9E0A for ; Thu, 26 Feb 2026 19:55:48 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vvhRp-0000SJ-C3; Thu, 26 Feb 2026 14:54:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvhRo-0000Rp-EQ for qemu-devel@nongnu.org; Thu, 26 Feb 2026 14:54:56 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vvhRl-0005xu-NQ for qemu-devel@nongnu.org; Thu, 26 Feb 2026 14:54:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772135692; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UZwFYM1VwpEvCzdR6UKTKUeexLcCzCYwziU5Mgqdn9w=; b=PDhMYbHqEYqrTyMFsM+JrSyc7ekMFPmV0HYp14D3ibbo8hNeTJb2bXn8JuGyDYbTiBtyPu oCm0CmDp6kK0zp5dlY5iw6W4xKu4LDluPVZ0CtLP+p3/Kc60T7jJ60d+RyVQGqBut4JHcW RTEh2f7HpDJ6J7sFOv+8vjQ7bmwh4G4= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-7naXFBxwMwS8Af3sj0f8kg-1; Thu, 26 Feb 2026 14:54:49 -0500 X-MC-Unique: 7naXFBxwMwS8Af3sj0f8kg-1 X-Mimecast-MFC-AGG-ID: 7naXFBxwMwS8Af3sj0f8kg_1772135688 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4980718003FC; Thu, 26 Feb 2026 19:54:48 +0000 (UTC) Received: from redhat.com (unknown [10.44.33.49]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E655219560B5; Thu, 26 Feb 2026 19:54:46 +0000 (UTC) Date: Thu, 26 Feb 2026 20:54:44 +0100 From: Kevin Wolf To: Hanna Czenczek Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Brian Song Subject: Re: [PATCH v4 00/24] export/fuse: Use coroutines and multi-threading Message-ID: References: <20260218132633.29748-1-hreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260218132633.29748-1-hreitz@redhat.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.306, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.668, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 18.02.2026 um 14:26 hat Hanna Czenczek geschrieben: > Hi, > > This series: > - Fixes some bugs/minor inconveniences, > - Removes libfuse from the request processing path, > - Make the FUSE export use coroutines for request handling, > > More detail on the v1 cover letter: > https://lists.nongnu.org/archive/html/qemu-block/2025-03/msg00359.html > > v2 cover letter: > https://lists.nongnu.org/archive/html/qemu-block/2025-06/msg00040.html > > v3 cover letter: > https://lists.nongnu.org/archive/html/qemu-block/2025-07/msg00005.html > > > I noticed some performance differences vs. my previous benchmarks; > notably, performance didn’t improve with the introduction of coroutines > much (except for random read performance). However, when I run the same > benchmarks on the old branch again, I see no performance improvement > either. Something about my host system must have changed. Reviewed-by: Kevin Wolf I had very few minor comments. Let me know if you'd like to have these points changed while I apply the series. Kevin