From: Yujie Liu <yujie.liu@intel.com>
To: <phasta@kernel.org>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Kenneth Feng" <kenneth.feng@amd.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Patrik Jakobsson" <patrik.r.jakobsson@gmail.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Pierre-Eric Pelloux-Prayer" <pierre-eric.pelloux-prayer@amd.com>,
"Srinivasan Shanmugam" <srinivasan.shanmugam@amd.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@igalia.com>,
"Sunil Khatri" <sunil.khatri@amd.com>,
"Lijo Lazar" <lijo.lazar@amd.com>,
"Asad Kamal" <asad.kamal@amd.com>,
"Yang Wang" <kevinyang.wang@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"Tao Zhou" <tao.zhou1@amd.com>,
"Gangliang Xie" <ganglxie@amd.com>,
"Candice Li" <candice.li@amd.com>,
"YiPeng Chai" <YiPeng.Chai@amd.com>,
"Matthew Auld" <matthew.auld@intel.com>,
"Luben Tuikov" <luben.tuikov@amd.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Michał Winiarski" <michal.winiarski@intel.com>,
"Michal Wajdeczko" <michal.wajdeczko@intel.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 2/7] drm/scheduler: fix kernel-doc warning for drm_sched_job_done()
Date: Fri, 27 Feb 2026 16:02:53 +0800 [thread overview]
Message-ID: <aaFPrclndiWsW33h@X299> (raw)
In-Reply-To: <baa2d0b7c15687e153cac6d00c546a547feb2340.camel@mailbox.org>
On Fri, Feb 27, 2026 at 07:47:42AM +0100, Philipp Stanner wrote:
> On Thu, 2026-02-26 at 11:00 +0800, Yujie Liu wrote:
> > Warning: drivers/gpu/drm/scheduler/sched_main.c:367 function parameter 'result' not described in 'drm_sched_job_done'
> >
> > Fixes: 539f9ee4b52a ("drm/scheduler: properly forward fence errors")
> > Signed-off-by: Yujie Liu <yujie.liu@intel.com>
>
> Thanks for fixing this!
>
> Acked-by: Philipp Stanner <phasta@kernel.org>
Hi Philipp,
Thanks for reviewing this.
Following Christian's suggestion to split this set into individual
patches for different subsystem branches, I've sent a v2 at [1] with
less audience. Sorry for bothering too many people on these minor
kernel-doc fixes.
[1] https://lore.kernel.org/all/20260227061052.1752354-1-yujie.liu@intel.com/
>
> > ---
> > drivers/gpu/drm/scheduler/sched_main.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> > index e6ee35406165..fe4c1017734b 100644
> > --- a/drivers/gpu/drm/scheduler/sched_main.c
> > +++ b/drivers/gpu/drm/scheduler/sched_main.c
> > @@ -361,6 +361,7 @@ static void drm_sched_run_free_queue(struct drm_gpu_scheduler *sched)
> > /**
> > * drm_sched_job_done - complete a job
> > * @s_job: pointer to the job which is done
> > + * @result: 0 on success; -errno on failure
>
> nit: shouldn't it be -ERRNO? But idk.
Thanks, indeed it should be capital letters. Will respin a v3 with you
CC'd.
>
> > *
> > * Finish the job's fence and resubmit the work items.
> > */
>
next prev parent reply other threads:[~2026-02-27 9:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 3:00 [PATCH 0/7] drm: fix some kernel-doc warnings Yujie Liu
2026-02-26 3:00 ` [PATCH 1/7] drm/gpusvm: fix kernel-doc warning for drm_gpusvm_pages_valid_unlocked() Yujie Liu
2026-02-26 3:06 ` Matthew Brost
2026-02-26 5:56 ` Yujie Liu
2026-02-26 11:39 ` Christian König
2026-02-27 2:08 ` Yujie Liu
2026-02-26 3:00 ` [PATCH 2/7] drm/scheduler: fix kernel-doc warning for drm_sched_job_done() Yujie Liu
2026-02-27 6:47 ` Philipp Stanner
2026-02-27 8:02 ` Yujie Liu [this message]
2026-02-26 3:00 ` [PATCH 3/7] drm/gma500: fix kernel-doc warning for framebuffer init/create functions Yujie Liu
2026-02-26 3:00 ` [PATCH 4/7] drm/amdgpu: fix kernel-doc warning for amdgpu_ttm_alloc_mmio_remap_bo() Yujie Liu
2026-02-26 16:52 ` Alex Deucher
2026-02-26 3:00 ` [PATCH 5/7] drm/xe/pf: fix kernel-doc warning for SR-IOV VF restore function Yujie Liu
2026-02-26 11:36 ` Michal Wajdeczko
2026-02-26 3:00 ` [PATCH 6/7] drm/amd/pm: fix kernel-doc warning for smu_msg_v1_send_msg() Yujie Liu
2026-02-26 16:54 ` Alex Deucher
2026-02-26 3:00 ` [PATCH 7/7] drm/amd/ras: fix kernel-doc warning for ras_eeprom_append() Yujie Liu
2026-02-26 16:53 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaFPrclndiWsW33h@X299 \
--to=yujie.liu@intel.com \
--cc=Hawking.Zhang@amd.com \
--cc=YiPeng.Chai@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=asad.kamal@amd.com \
--cc=candice.li@amd.com \
--cc=christian.koenig@amd.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=ganglxie@amd.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=kenneth.feng@amd.com \
--cc=kevinyang.wang@amd.com \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luben.tuikov@amd.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.auld@intel.com \
--cc=matthew.brost@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=michal.winiarski@intel.com \
--cc=mripard@kernel.org \
--cc=patrik.r.jakobsson@gmail.com \
--cc=phasta@kernel.org \
--cc=pierre-eric.pelloux-prayer@amd.com \
--cc=rodrigo.vivi@intel.com \
--cc=simona@ffwll.ch \
--cc=srinivasan.shanmugam@amd.com \
--cc=sunil.khatri@amd.com \
--cc=tao.zhou1@amd.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tvrtko.ursulin@igalia.com \
--cc=tzimmermann@suse.de \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.