From: Jim MacArthur <jim.macarthur@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v3 2/2] gdbstub: Generate a single gdbstub-xml.c / gdb_static_features[]
Date: Fri, 27 Feb 2026 11:46:14 +0000 [thread overview]
Message-ID: <aaGEBp6IMZwEllOW@linaro.org> (raw)
In-Reply-To: <20260227101040.70763-3-philmd@linaro.org>
On Fri, Feb 27, 2026 at 11:10:39AM +0100, Philippe Mathieu-Daudé wrote:
> gdb_static_features[] only contains strings, nothing target-specific.
> Instead of generating one file per target, generate a single file
> with a single gdb_static_features[] array.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> meson.build | 10 ----------
> stubs/gdbstub.c => gdbstub/gdb-xml-stub.c | 0
> gdbstub/meson.build | 19 +++++++++++++++++++
> stubs/meson.build | 2 --
> 4 files changed, 19 insertions(+), 12 deletions(-)
> rename stubs/gdbstub.c => gdbstub/gdb-xml-stub.c (100%)
>
LGTM
Reviewed-by: Jim MacArthur <jim.macarthur@linaro.org>
prev parent reply other threads:[~2026-02-27 11:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 10:10 [PATCH v3 0/2] gdbstub: Generate a single gdbstub-xml.c / gdb_static_features[] Philippe Mathieu-Daudé
2026-02-27 10:10 ` [PATCH v3 1/2] meson: Restrict gdbstub to user/system builds Philippe Mathieu-Daudé
2026-02-27 11:45 ` Jim MacArthur
2026-02-27 10:10 ` [PATCH v3 2/2] gdbstub: Generate a single gdbstub-xml.c / gdb_static_features[] Philippe Mathieu-Daudé
2026-02-27 11:46 ` Jim MacArthur [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaGEBp6IMZwEllOW@linaro.org \
--to=jim.macarthur@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.