From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 767D52C2349; Fri, 27 Feb 2026 17:09:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772212149; cv=none; b=QzyRxgQq8+1LRnpUA1xv/BnKd8WBvLen01X2KVcUNb3ErajryD2etj5HleYGOqwtQAT/8+aWAoR/R8luAOXtrCbMniFf6gnMIbaVYgNCYOCN+teD3MT4f+rr7DP8lwCCH34Mu46/3WxmPTRkuTLUhyaBJpXdu0G29dwyoZG/Ess= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772212149; c=relaxed/simple; bh=1KAqzA+8uV1poJl6va51WArWnnZz8PlW6lqjGx93yZU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pi8aciYOs1ElnnbW3fPBsCxn3kFiJSSsi0uP2PJKZcwE8iQ9+F+pdjxwIv/eXWBcDm7BbACUwuGWq84XbGagbpsEHLrJGLcIhJJIZ79GsZbqmW4+0RBNpNXDrntQFDJmnxPeNasE4L97xnpGsVI8lSApD8LmFyYuwOtZY5o19Qo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=s5vrgOoN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="s5vrgOoN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E11CDC116C6; Fri, 27 Feb 2026 17:09:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772212149; bh=1KAqzA+8uV1poJl6va51WArWnnZz8PlW6lqjGx93yZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s5vrgOoNFZRn6r17oo6ZnPu4in2RySHro2gEKyq2gHCFPo4mT0vGT7VDHABNFfVqD tJ4JeqsEhmVthfTExHl81tgvd8Ur4u/twkqpqcshWu27PdyFIEm3NAH8sGMOTeifPU 0mhp2U/4nKAiu4lKnaCHIsju/4ilXiaxfDhlfUliXz3v0rXIAXSGBmejwoAlMNthEC pP2FS9kU4PspfktVWDf/xLrlHia4TFOAEkOnK2b1HOoC6whKVKIeLUSZp0YkVes4xY WGO5kAzj8oKF+hLVg9OcrtkiEBntZ2/yojytgq4vTU/n3Z/ilBBMbRNK7VsYBHNBe8 6knRk8HXDdbdA== Date: Fri, 27 Feb 2026 07:09:07 -1000 From: Tejun Heo To: Alice Ryhl Cc: Miguel Ojeda , Lai Jiangshan , Gary Guo , =?iso-8859-1?Q?Bj=F6rn?= Roy Baron , Andreas Hindborg , Trevor Gross , Danilo Krummrich , Daniel Almeida , John Hubbard , Philipp Stanner , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Boqun Feng , Benno Lossin , Tamir Duberstein , stable@vger.kernel.org Subject: Re: [PATCH v3 1/2] rust: workqueue: restrict delayed work to global wqs Message-ID: References: <20260227-create-workqueue-v3-0-87de133f7849@google.com> <20260227-create-workqueue-v3-1-87de133f7849@google.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260227-create-workqueue-v3-1-87de133f7849@google.com> On Fri, Feb 27, 2026 at 02:53:20PM +0000, Alice Ryhl wrote: > When a workqueue is shut down, delayed work that is pending but not > scheduled does not get properly cleaned up, so it's not safe to use > `enqueue_delayed` on a workqueue that might be destroyed. To fix this, > restricted `enqueue_delayed` to static queues. C being C, we've been just chalking this up as "user error", but please feel free to add per-workqueue percpu ref for pending delayed work items if that'd help. That shouldn't be noticeably expensive and should help straighten this out for rust hopefully. Thanks. -- tejun