From: Cristian Marussi <cristian.marussi@arm.com>
To: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
Cc: Sudeep Holla <sudeep.holla@kernel.org>,
Cristian Marussi <cristian.marussi@arm.com>,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Peng Fan <peng.fan@nxp.com>
Subject: Re: [PATCH] firmware: arm_scmi: base: Simplify protocol list size calculation
Date: Sat, 28 Feb 2026 10:03:59 +0000 [thread overview]
Message-ID: <aaK9jwtyJHoa0F2t@pluto> (raw)
In-Reply-To: <20260228-scmi-check-v1-1-4935b58bb2db@nxp.com>
On Sat, Feb 28, 2026 at 11:37:33AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Replace the open-coded round-up calculation with the kernel's round_up()
> helper function for better readability.
>
> The original expression:
> (1 + (loop_num_ret - 1) / sizeof(u32)) * sizeof(u32)
>
Thanks for this.
LGTM.
Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
Cristian
next prev parent reply other threads:[~2026-02-28 10:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 3:37 [PATCH] firmware: arm_scmi: base: Simplify protocol list size calculation Peng Fan (OSS)
2026-02-28 10:03 ` Cristian Marussi [this message]
2026-03-09 9:12 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaK9jwtyJHoa0F2t@pluto \
--to=cristian.marussi@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peng.fan@oss.nxp.com \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.