From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ethan Tidmore <ethantidmore06@gmail.com>
Cc: Patrick Rudolph <patrick.rudolph@9elements.com>,
Linus Walleij <linusw@kernel.org>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: cy8c95x0: Use proper error code
Date: Sat, 28 Feb 2026 12:13:19 +0200 [thread overview]
Message-ID: <aaK_v2sSCRe9CVYL@ashevche-desk.local> (raw)
In-Reply-To: <20260228020538.1103307-1-ethantidmore06@gmail.com>
On Fri, Feb 27, 2026 at 08:05:38PM -0600, Ethan Tidmore wrote:
> The function cy8c95x0_irq_pending() returns type bool not an error code.
>
> Use error code -EIO if cy8c95x0_irq_pending() fails.
>
> Detected by Smatch:
> drivers/pinctrl/pinctrl-cy8c95x0.c:1303 cy8c95x0_irq_setup() warn:
> passing positive error code '1' to 'dev_err_probe'
I sent already a patch and the code is -EBUSY, because if we ever get non-zero
here, it means that IO was fine, the interrupt status was not cleared.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-28 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 2:05 [PATCH] pinctrl: cy8c95x0: Use proper error code Ethan Tidmore
2026-02-28 10:13 ` Andy Shevchenko [this message]
2026-02-28 14:48 ` Ethan Tidmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaK_v2sSCRe9CVYL@ashevche-desk.local \
--to=andriy.shevchenko@linux.intel.com \
--cc=ethantidmore06@gmail.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patrick.rudolph@9elements.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.