From: Dan Carpenter <dan.carpenter@linaro.org>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Pratyush Yadav <pratyush@kernel.org>, kernel-janitors@vger.kernel.org
Subject: [bug report] tests/liveupdate: add in-kernel liveupdate test
Date: Sat, 28 Feb 2026 14:48:21 +0300 [thread overview]
Message-ID: <aaLWBYzuFg3ZuVmP@stanley.mountain> (raw)
[ Smatch checking is paused while we raise funding. #SadFace
https://lore.kernel.org/all/aTaiGSbWZ9DJaGo7@stanley.mountain/ -dan ]
Hello Pasha Tatashin,
Commit f653ff7af969 ("tests/liveupdate: add in-kernel liveupdate
test") from Dec 18, 2025 (linux-next), leads to the following Smatch
static checker warning:
lib/tests/liveupdate.c:130 liveupdate_test_register()
warn: passing zero to 'ERR_PTR'
lib/tests/liveupdate.c
112 void liveupdate_test_register(struct liveupdate_file_handler *fh)
113 {
114 int err, i;
115
116 liveupdate_test_init();
117
118 for (i = 0; i < TEST_NFLBS; i++) {
119 struct liveupdate_flb *flb = &test_flbs[i];
120
121 err = liveupdate_register_flb(fh, flb);
122 if (err) {
123 pr_err("Failed to register %s %pe\n",
124 flb->compatible, ERR_PTR(err));
125 }
126 }
127
128 err = liveupdate_register_flb(fh, &test_flbs[0]);
129 if (!err || err != -EEXIST) {
^^
|| vs && bug. This error messages will always be printed.
--> 130 pr_err("Failed: %s should be already registered, but got err: %pe\n",
131 test_flbs[0].compatible, ERR_PTR(err));
132 }
133
134 pr_info("Registered %d FLBs with file handler: [%s]\n",
135 TEST_NFLBS, fh->compatible);
136 }
regards,
dan carpenter
next reply other threads:[~2026-02-28 11:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 11:48 Dan Carpenter [this message]
2026-03-13 12:10 ` [bug report] tests/liveupdate: add in-kernel liveupdate test Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaLWBYzuFg3ZuVmP@stanley.mountain \
--to=dan.carpenter@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=pasha.tatashin@soleen.com \
--cc=pratyush@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.