From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4930547CC79; Sat, 28 Feb 2026 15:39:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772293173; cv=none; b=BOAfSPwmC3l6QQCSvV0+OPvDy3P4cGe/JERzEXL9fvlebWcpb0EEtCzgEg+RdixYxqwtB6+TPcztj/TWhceXsBnHYYmY68XMMQlA9ZIsrDnPIdWpTcCdqNKF2A+hbPrG48LqsxLsB5ECT6ShGB8jOKO1eLdBpienIxVKfWwf5+o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772293173; c=relaxed/simple; bh=vqH8JWH1At3E8561EseqXCazTNcoT1de3KQQuaU8A/0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sAApDFo18siANlh/MyTHhhwr2GBAb33GBE1nE1TyW7NyHqJCHoqVWYRyEbuy925M9wa+atW6up8/DS7MdGSdliAF9dr8o6dVrgoZ3CPW+1c9IPjg7Uti1q9zV+/YEyolybC8/Nts7sjSDAE9E8QpiD/yYC1oDCiV00r5oJZDEGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AACHvJVz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AACHvJVz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFA20C116D0; Sat, 28 Feb 2026 15:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1772293173; bh=vqH8JWH1At3E8561EseqXCazTNcoT1de3KQQuaU8A/0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AACHvJVzA+Jga9tGqlfzv658x0+XqTPiW67T0XpVwhiO4YInKYWTW/YtNXW75DSkN abCUMwIKb14QBdevDsIAt+cOWh4mSF4PNoRmkjcI8jcFLUqz8JoAW8/lpovmTjSs04 tudQayp45tgDraGMfarJ8Jzciplp0zM4O7w77eLtOiI7FUUSQw7r+7NYJ3VXKG2fIQ gOnco69qooQN0Mt9aooR57PvzdO9n9oTJvKXLjrgnUVd2AMP2iEG/eWzocMHHGls85 6ZZoAQRk5MJ6kcCDoMTfo9avZRfVaZuAElN92gJqW2abPGGj9SIgBIHF82kG8s6Ykh 0zlP0I9ymeAQA== Date: Sat, 28 Feb 2026 10:39:31 -0500 From: Sasha Levin To: "Rafael J. Wysocki" Cc: Athul Krishna , Greg Kroah-Hartman , "rafael.j.wysocki@intel.com" , "superm1@kernel.org" , "bp@alien8.de" , ACPI Devel Maling List , "linux-kernel@vger.kernel.org" Subject: Re: [REGRESSION] Suspend broken on 6.19.4 Message-ID: References: Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Feb 28, 2026 at 02:58:54PM +0100, Rafael J. Wysocki wrote: >On Sat, Feb 28, 2026 at 2:51 PM Rafael J. Wysocki wrote: >> >> On Sat, Feb 28, 2026 at 1:40 PM Athul Krishna >> wrote: >> > >> > Device: Asus Zephyrus G14 (GA402RJ) >> > CPU: Ryzen 7 6700H >> > iGPU: Radeon 680M >> > >> > Problem: Suspend broken on 6.19.4. On closing the lid or systemctl suspend, screen turns off but device does not fully power down. >> > No obvious errors in dmesg except: >> > [ 219.151441] amd_pmc AMDI0007:00: Last suspend didn't reach deepest state >> > [ 219.164301] ACPI: EC: interrupt unblocked >> > >> > Bisected: >> > commit 6cfed39c2ce64ac024bbde458a9727105e0b8c66 >> > Author: Rafael J. Wysocki >> > Date: Tue Dec 23 18:09:11 2025 +0800 >> > >> > ACPI: processor: Update cpuidle driver check in __acpi_processor_start() >> > >> > [ Upstream commit 0089ce1c056aee547115bdc25c223f8f88c08498 ] >> > >> > Commit 7a8c994cbb2d ("ACPI: processor: idle: Optimize ACPI idle >> > driver registration") moved the ACPI idle driver registration to >> > acpi_processor_driver_init() and acpi_processor_power_init() does >> > not register an idle driver any more. >> > >> > Accordingly, the cpuidle driver check in __acpi_processor_start() needs >> > to be updated to avoid calling acpi_processor_power_init() without a >> > cpuidle driver, in which case the registration of the cpuidle device >> > in that function would lead to a NULL pointer dereference in >> > __cpuidle_register_device(). >> > >> > Fixes: 7a8c994cbb2d ("ACPI: processor: idle: Optimize ACPI idle driver registration") >> > Signed-off-by: Rafael J. Wysocki >> > Reviewed-by: Mario Limonciello (AMD) >> > Tested-by: Borislav Petkov (AMD) >> > Link: https://patch.msgid.link/20251223100914.2407069-4-lihuisong@huawei.com >> > Signed-off-by: Rafael J. Wysocki >> > Signed-off-by: Sasha Levin >> > >> > Reverting the commit or downgrading to 6.19.3 resolves the issue. >> > Attached dmesg and lspci. >> >> Is this problem also present in 7.0-rc1? > >To my eyes, this commit shouldn't have been backported to 6.19.y >because the one fixed by it was reverted in the meantime and only >re-added in 7.0-rc1. > >Sasha, Greg, how do I request dropping this one from -stable? Now reverted, thanks :) -- Thanks, Sasha