All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: FUJITA Tomonori <tomo@aliasing.net>,
	a.hindborg@kernel.org, boqun.feng@gmail.com,
	 fujita.tomonori@gmail.com, frederic@kernel.org,
	lyude@redhat.com,  tglx@kernel.org, anna-maria@linutronix.de,
	jstultz@google.com,  sboyd@kernel.org, ojeda@kernel.org,
	gary@garyguo.net,  bjorn3_gh@protonmail.com, lossin@kernel.org,
	tmgross@umich.edu,  dakr@kernel.org,
	rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rust: hrtimer: add active() method to query timer state
Date: Sun, 1 Mar 2026 11:31:40 +0000	[thread overview]
Message-ID: <aaQjnM3XbaolKcvo@google.com> (raw)
In-Reply-To: <CANiq72=Y5aHc+jQc2Z5R7gxQj4oyKKKuPuuR9Uzx_LR8Ph84gw@mail.gmail.com>

On Sat, Feb 28, 2026 at 04:04:27AM +0100, Miguel Ojeda wrote:
> On Sat, Feb 28, 2026 at 3:23 AM FUJITA Tomonori <tomo@aliasing.net> wrote:
> >
> > Should we use intra-doc links for true/flase? Currently, rust/kernel
> > doesn't seem to use them. Seems that Rust std library isn't consistent
> > on this either.
> 
> Maybe... It doesn't matter much either way, obviously.
> 
> For simplicity/consistency with other "trivial" items, it may be
> better. On the other hand, it is more painful to type and takes 2
> characters.
> 
> This is the entry I have so far for this in my to-be-sent guidelines
> "rules" list:
> 
> - Use intra-doc links wherever the link would work (i.e. if ``rustdoc``
>   can resolve it), unless doing so would be unreasonably complex or
>   verbose. In such a case, use a simple code span instead.
> 
>   Do so even for trivial types and constants, such as ``i32`` and
>   ``true``, as well as for ``Self``.
> 
>   .. code-block:: rust
> 
>     /// Returns a new [`Foo`].
> 
>   Avoid:
> 
>   .. code-block:: rust
> 
>     /// Returns a new `Foo`.

I'm not convinced by that. I don't think it's useful for `true` or
`Self` to be links in most cases.

Alice

  parent reply	other threads:[~2026-03-01 11:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-15 20:29 [PATCH] rust: hrtimer: add active() method to query timer state Andreas Hindborg
2026-02-15 20:59 ` Miguel Ojeda
2026-02-28  2:22   ` FUJITA Tomonori
2026-02-28  3:04     ` Miguel Ojeda
2026-02-28  4:57       ` FUJITA Tomonori
2026-03-01 11:31       ` Alice Ryhl [this message]
2026-02-27 14:23 ` Gary Guo
2026-02-28  4:57 ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaQjnM3XbaolKcvo@google.com \
    --to=aliceryhl@google.com \
    --cc=a.hindborg@kernel.org \
    --cc=anna-maria@linutronix.de \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=dakr@kernel.org \
    --cc=frederic@kernel.org \
    --cc=fujita.tomonori@gmail.com \
    --cc=gary@garyguo.net \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=lyude@redhat.com \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tglx@kernel.org \
    --cc=tmgross@umich.edu \
    --cc=tomo@aliasing.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.