All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francesco Valla <francesco@valla.it>
To: adrian.freihofer@gmail.com
Cc: openembedded-core@lists.openembedded.org,
	 Adrian Freihofer <adrian.freihofer@siemens.com>,
	Marek Vasut <marek.vasut@mailbox.org>,
	 Michael Opdenacker <michael.opdenacker@rootcommit.com>
Subject: Re: [OE-core] [PATCH 1/2] oe-selftest: fitimage: allow relaxed node checks
Date: Sun, 1 Mar 2026 20:31:49 +0100	[thread overview]
Message-ID: <aaSTTCPX4GCOFi3f@bywater> (raw)
In-Reply-To: <b2014f3b751aebe76d976352a9aab371564c5a9a.camel@gmail.com>

Hi Adrian,

On Sun, Mar 01, 2026 at 03:20:55PM +0100, adrian.freihofer@gmail.com wrote:
> Hi Francesco
> 
> Thank you for the nice patches. Also thank you for separating this
> change into a separate patch to make it more obvious that this is
> potentially a bit controversial.
> 
> This looks like a risky change to me. Having a variable set to None by
> accident is a common error which the test should catch. Just allowing
> that is probably not the right approach.
> 

I agree with you TBH.

> Is it really not possible to make the tests providing the correct
> reference values in the dict which compared against the output?
> 

After some more thinking, I think I got the way in which
uboot-config.bbclass (which was recently reworked to support flags on
UBOOT_CONFIG_* variables) is approaching the matter. I'll rework the
test approach and send a v2.

> Regards,
> Adrian
> 

Thank you!

Regards,
Francesco



  reply	other threads:[~2026-03-01 19:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 23:37 [PATCH 0/2] fitimage: add ability to include arbitrary loadables Francesco Valla
2026-02-27 23:37 ` [PATCH 1/2] oe-selftest: fitimage: allow relaxed node checks Francesco Valla
2026-03-01 14:20   ` [OE-core] " adrian.freihofer
2026-03-01 19:31     ` Francesco Valla [this message]
2026-02-27 23:37 ` [PATCH 2/2] kernel-fit-image: support arbitrary loadables Francesco Valla
2026-03-01 14:29   ` [OE-core] " adrian.freihofer
2026-03-01 10:44 ` [PATCH 0/2] fitimage: add ability to include " Michael Opdenacker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaSTTCPX4GCOFi3f@bywater \
    --to=francesco@valla.it \
    --cc=adrian.freihofer@gmail.com \
    --cc=adrian.freihofer@siemens.com \
    --cc=marek.vasut@mailbox.org \
    --cc=michael.opdenacker@rootcommit.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.