From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Josh Law <hlcj1234567@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Josh Law <objecting@objecting.org>
Subject: Re: [PATCH 2/2] lib: glob: replace bitwise OR with logical operation on boolean
Date: Mon, 2 Mar 2026 11:02:57 +0800 [thread overview]
Message-ID: <aaT94cjUleIyvJ_u@google.com> (raw)
In-Reply-To: <aaT8a2nDb2xIHBD4@google.com>
On Mon, Mar 02, 2026 at 10:56:47AM +0800, Kuan-Wei Chiu wrote:
> Hi Josh,
>
> On Sun, Mar 01, 2026 at 03:21:42PM +0000, Josh Law wrote:
> > Using bitwise OR (|=) on a boolean variable is valid C, but replacing it with a direct logical assignment makes the intent clearer and appeases strict static analysis tools.
> >
> > Signed-off-by: Josh Law <objecting@objecting.org>
>
> checkpath.pl reported the following warnings:
>
> WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
> #81:
> Using bitwise OR (|=) on a boolean variable is valid C, but replacing it with a direct logical assignment makes the intent clearer and appeases strict static analysis tools.
>
> WARNING: From:/Signed-off-by: email address mismatch: 'From: Josh Law <hlcj1234567@gmail.com>' != 'Signed-off-by: Josh Law <objecting@objecting.org>'
>
> total: 0 errors, 2 warnings, 0 checks, 9 lines checked
>
BTW, both of your patches does not apply cleanly.
Regards,
Kuan-Wei
next prev parent reply other threads:[~2026-03-02 3:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 15:21 [PATCH 1/2] lib: glob: add explicit include for export.h Josh Law
2026-03-01 15:21 ` [PATCH 2/2] lib: glob: replace bitwise OR with logical operation on boolean Josh Law
2026-03-01 19:25 ` Andrew Morton
2026-03-01 19:40 ` Josh Law
2026-03-01 19:43 ` Andrew Morton
2026-03-01 22:05 ` David Laight
2026-03-02 2:56 ` Kuan-Wei Chiu
2026-03-02 3:02 ` Kuan-Wei Chiu [this message]
2026-03-02 7:11 ` Josh Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaT94cjUleIyvJ_u@google.com \
--to=visitorckw@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hlcj1234567@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=objecting@objecting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.