From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Archit Anant <architanant5@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, lars@metafoo.de,
Michael.Hennerich@analog.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: adc: ad799x: convert to fully managed resources
Date: Mon, 2 Mar 2026 10:09:16 +0200 [thread overview]
Message-ID: <aaVFrLVNNmbFSXBH@ashevche-desk.local> (raw)
In-Reply-To: <20260302052559.19494-1-architanant5@gmail.com>
On Mon, Mar 02, 2026 at 10:55:59AM +0530, Archit Anant wrote:
> Refactor the driver to use device-managed allocations and actions,
> allowing for the complete removal of the ad799x_remove() function
> and simplifying the error paths in probe().
>
> Key changes:
> - Replace the dynamic rx_buf allocation with a fixed-size, DMA-safe
> buffer using IIO_DECLARE_DMA_BUFFER_WITH_TS() in the state struct.
> This avoids memory leaks during scan mode updates and removes the
> need for manual kfree().
> - Cache the VCC and VREF voltages in the state structure during probe()
> to avoid querying the regulator API during fast-path read_raw() calls.
> - Use devm_add_action_or_reset() to register regulator_disable()
> callbacks for both VCC and VREF regulators.
> - Convert iio_triggered_buffer_setup() and iio_device_register() to
> their devm_ variants, ensuring safe, reverse-order unwinding.
Seems like a series squashed into a single patch, please resplit.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-02 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 5:25 [PATCH v2] iio: adc: ad799x: convert to fully managed resources Archit Anant
2026-03-02 8:09 ` Andy Shevchenko [this message]
2026-03-02 15:06 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaVFrLVNNmbFSXBH@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=architanant5@gmail.com \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.