All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Josh Law <hlcj1234567@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Josh Law <objecting@objecting.org>
Subject: Re: [PATCH] staging: axis-fifo: remove redundant goto end
Date: Mon, 2 Mar 2026 12:17:14 +0300	[thread overview]
Message-ID: <aaVVmuFE_Hu28RZX@stanley.mountain> (raw)
In-Reply-To: <20260301005019.2510157-1-objecting@objecting.org>

On Sun, Mar 01, 2026 at 12:50:19AM +0000, Josh Law wrote:
> Signed-off-by: Josh Law <objecting@objecting.org>
> ---
>  drivers/staging/axis-fifo/axis-fifo.c | 17 ++++++++---------
>  1 file changed, 8 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index aac2c58ef9b3..d83a0fd5b231 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -395,22 +395,22 @@ static int axis_fifo_parse_dt(struct axis_fifo *fifo)
>  				   &value);
>  	if (ret) {
>  		dev_err(fifo->dt_device, "missing xlnx,axi-str-rxd-tdata-width property\n");
> -		goto end;
> +		return ret;
>  	} else if (value != 32) {
>  		dev_err(fifo->dt_device, "xlnx,axi-str-rxd-tdata-width only supports 32 bits\n");
>  		ret = -EIO;
> -		goto end;
> +		return ret;

Just return -EIO.

regards,
dan carpenter


  reply	other threads:[~2026-03-02  9:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-01  0:50 [PATCH] staging: axis-fifo: remove redundant goto end Josh Law
2026-03-02  9:17 ` Dan Carpenter [this message]
2026-03-09 16:09 ` Greg Kroah-Hartman
2026-03-09 16:12   ` Josh Law
2026-03-09 16:14     ` Josh Law
2026-03-09 16:57       ` Greg Kroah-Hartman
2026-03-09 16:59         ` Josh Law
2026-03-09 17:02           ` Greg Kroah-Hartman
2026-03-09 17:04             ` Josh Law
2026-03-09 17:06               ` Greg Kroah-Hartman
2026-03-09 17:09                 ` Josh Law
2026-03-09 17:22                   ` Josh Law
2026-03-09 22:00                     ` Dan Carpenter
2026-03-09 22:02                       ` Josh Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaVVmuFE_Hu28RZX@stanley.mountain \
    --to=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hlcj1234567@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=objecting@objecting.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.