From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sean Chang <seanwascoding@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Chuck Lever <chuck.lever@oracle.com>,
David Laight <david.laight.linux@gmail.com>,
nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
trond.myklebust@hammerspace.com, anna@kernel.org,
netdev@vger.kernel.org, linux-nfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] net: macb: use ethtool_sprintf to fill ethtool stats strings
Date: Mon, 2 Mar 2026 14:24:21 +0100 [thread overview]
Message-ID: <aaWPhXrcthze_ZxE@black.igk.intel.com> (raw)
In-Reply-To: <20260228180821.811683-3-seanwascoding@gmail.com>
On Sun, Mar 01, 2026 at 02:08:21AM +0800, Sean Chang wrote:
> The RISC-V toolchain triggers a stringop-truncation warning when using
> snprintf() with a fixed ETH_GSTRING_LEN (32 bytes) buffer.
>
> Convert the driver to use the modern ethtool_sprintf() API from
> linux/ethtool.h. This removes the need for manual snprintf() and
> memcpy() calls, handles the 32-byte padding automatically, and
> simplifies the logic by removing manual pointer arithmetic.
This can go separately from patch 1. Dunno why this is a series...
And this one LGTM,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-03-02 13:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-28 18:08 [PATCH v5 0/2] Fix compiler warnings/errors in SUNRPC and MACB Sean Chang
2026-02-28 18:08 ` [PATCH v5 1/2] sunrpc: simplify dfprintk macros and fix nfsd build error Sean Chang
2026-02-28 22:59 ` kernel test robot
2026-03-01 0:10 ` kernel test robot
2026-03-01 0:31 ` kernel test robot
2026-03-02 9:40 ` Geert Uytterhoeven
2026-03-02 13:13 ` Sean Chang
2026-03-02 13:15 ` Geert Uytterhoeven
2026-03-02 13:21 ` Andy Shevchenko
2026-02-28 18:08 ` [PATCH v5 2/2] net: macb: use ethtool_sprintf to fill ethtool stats strings Sean Chang
2026-03-02 13:24 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaWPhXrcthze_ZxE@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andrew@lunn.ch \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=david.laight.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=seanwascoding@gmail.com \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.