All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baoquan He <bhe@redhat.com>
To: Barry Song <21cnbao@gmail.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, chrisl@kernel.org,
	kasong@tencent.com, shikemeng@huaweicloud.com, nphamcs@gmail.com,
	youngjun.park@lge.com
Subject: Re: [PATCH 1/3] mm/swap: rename mm/page_io.c to mm/swap_io.c
Date: Mon, 2 Mar 2026 21:25:18 +0800	[thread overview]
Message-ID: <aaWPvlK-cHBlnvH4@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CAGsJ_4zBG96YbL7YpZMyLUsNOc6WRCZgntx0mSvJjZvhturoyw@mail.gmail.com>

On 03/02/26 at 06:56pm, Barry Song wrote:
> On Mon, Mar 2, 2026 at 6:40 PM Baoquan He <bhe@redhat.com> wrote:
> >
> > Codes in mm/page_io.c are only related to swap io, it has
> > nothing to do with other page io.
> 

Thanks for quick and careful reviewing on this patchset, Barry.

> That is true. Meanwhile, swap.c and swap.h contain a fair
> amount of non-swap-related code, such as lru_xxx and even
> file-related functions like deactivate_file_folio().
> 
> Perhaps we should consider moving these to more
> appropriate locations.

Yeah, agree. I will see if anyone else want to do the tidying up,
otherwise I can do it later.

> 
> >
> > Rename it to avoid confusion.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> 
> Reviewed-by: Barry Song <baohua@kernel.org>
> 



  reply	other threads:[~2026-03-02 13:25 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02 10:40 [PATCH 0/3] mm/swap: use swap_ops to register swap device's methods Baoquan He
2026-03-02 10:40 ` [PATCH 1/3] mm/swap: rename mm/page_io.c to mm/swap_io.c Baoquan He
2026-03-02 10:56   ` Barry Song
2026-03-02 13:25     ` Baoquan He [this message]
2026-03-02 21:12   ` Nhat Pham
2026-03-03  7:24     ` Baoquan He
2026-03-04  6:40   ` Kairui Song
2026-03-02 10:40 ` [PATCH 2/3] mm/swap: use swap_ops to register swap device's methods Baoquan He
2026-03-02 11:11   ` Barry Song
2026-03-02 14:47     ` Baoquan He
2026-03-02 19:28     ` Chris Li
2026-03-02 12:20   ` YoungJun Park
2026-03-02 14:09   ` YoungJun Park
2026-03-02 19:35     ` Chris Li
2026-03-03  7:14       ` Baoquan He
2026-03-02 14:53   ` Usama Arif
2026-03-03 10:41     ` Baoquan He
2026-03-02 21:21   ` Nhat Pham
2026-03-03  3:01     ` Baoquan He
2026-03-02 10:40 ` [PATCH 3/3] mm/swap_io.c: rename swap_writepage_* to swap_write_folio_* Baoquan He
2026-03-02 11:28   ` Barry Song
2026-03-02 21:11   ` Nhat Pham
2026-03-02 14:43 ` [PATCH 0/3] mm/swap: use swap_ops to register swap device's methods YoungJun Park
2026-03-05  5:18   ` Baoquan He
2026-03-05  8:09     ` YoungJun Park

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaWPvlK-cHBlnvH4@MiWiFi-R3L-srv \
    --to=bhe@redhat.com \
    --cc=21cnbao@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=chrisl@kernel.org \
    --cc=kasong@tencent.com \
    --cc=linux-mm@kvack.org \
    --cc=nphamcs@gmail.com \
    --cc=shikemeng@huaweicloud.com \
    --cc=youngjun.park@lge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.