From: Peter Xu <peterx@redhat.com>
To: Lukas Straub <lukasstraub2@web.de>
Cc: qemu-devel@nongnu.org, Fabiano Rosas <farosas@suse.de>,
Zhang Chen <zhangckid@gmail.com>,
Hailiang Zhang <zhanghailiang@xfusion.com>,
Li Zhijian <lizhijian@fujitsu.com>
Subject: Re: [PATCH v11 19/21] colo: Use file lock in primary_vm_do_failover()
Date: Mon, 2 Mar 2026 15:06:55 -0500 [thread overview]
Message-ID: <aaXt36L664YyBz63@x1.local> (raw)
In-Reply-To: <20260302-colo_unit_test_multifd-v11-19-d653fb3b1d80@web.de>
On Mon, Mar 02, 2026 at 12:45:34PM +0100, Lukas Straub wrote:
> Take the file lock since s->to_dst_file and s->rp_state.from_dst_file
> may be changed in the migration thread.
>
> Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2026-03-02 20:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 11:43 [PATCH v11 00/21] migration: Add COLO multifd support and COLO migration unit test Lukas Straub
2026-03-02 11:43 ` [PATCH v11 01/21] MAINTAINERS: Add myself as maintainer for COLO migration framework Lukas Straub
2026-03-02 11:43 ` [PATCH v11 02/21] MAINTAINERS: Remove Hailiang Zhang from " Lukas Straub
2026-03-10 11:33 ` Lukas Straub
2026-03-02 11:43 ` [PATCH v11 03/21] colo: Setup ram cache in normal migration path Lukas Straub
2026-03-02 11:43 ` [PATCH v11 04/21] colo: Replace migration_incoming_colo_enabled() with migrate_colo() Lukas Straub
2026-03-02 11:43 ` [PATCH v11 05/21] colo: Remove ENABLE_COLO savevm command and mark it as deprecated Lukas Straub
2026-03-02 11:43 ` [PATCH v11 06/21] ram: Remove colo special-casing Lukas Straub
2026-03-02 11:43 ` [PATCH v11 07/21] multifd: Move ram state receive into multifd_ram_state_recv() Lukas Straub
2026-03-02 11:43 ` [PATCH v11 08/21] multifd: Add COLO support Lukas Straub
2026-03-02 11:43 ` [PATCH v11 09/21] Call colo_release_ram_cache() after multifd threads terminate Lukas Straub
2026-03-02 11:45 ` [PATCH v11 10/21] colo: Fix crash during device vmstate load Lukas Straub
2026-03-02 11:45 ` [PATCH v11 11/21] colo: Hold the BQL while sending ram state Lukas Straub
2026-03-02 11:45 ` [PATCH v11 12/21] colo: Do not hold the BQL while receiving " Lukas Straub
2026-03-02 11:45 ` [PATCH v11 13/21] migration-test: Add COLO migration unit test Lukas Straub
2026-03-10 14:47 ` Arun Menon
2026-03-10 15:29 ` Lukas Straub
2026-03-10 17:42 ` Arun Menon
2026-03-19 22:40 ` Lukas Straub
2026-03-02 11:45 ` [PATCH v11 14/21] Convert colo main documentation to restructuredText Lukas Straub
2026-03-02 11:45 ` [PATCH v11 15/21] qemu-colo.rst: Miscellaneous changes Lukas Straub
2026-03-02 11:45 ` [PATCH v11 16/21] qemu-colo.rst: Add my copyright Lukas Straub
2026-03-02 11:45 ` [PATCH v11 17/21] qemu-colo.rst: Simplify the block replication setup Lukas Straub
2026-03-02 11:45 ` [PATCH v11 18/21] multifd: Fix hang if send thread errors during sync Lukas Straub
2026-03-02 11:45 ` [PATCH v11 19/21] colo: Use file lock in primary_vm_do_failover() Lukas Straub
2026-03-02 20:06 ` Peter Xu [this message]
2026-03-02 11:45 ` [PATCH v11 20/21] migration: Keep s->rp_state.from_dst_file open until migration ends Lukas Straub
2026-03-02 20:07 ` Peter Xu
2026-03-02 11:45 ` [PATCH v11 21/21] colo: Reuse the return path from migration on primary and secondary side Lukas Straub
2026-03-02 20:11 ` Peter Xu
2026-03-06 12:53 ` [PATCH v11 00/21] migration: Add COLO multifd support and COLO migration unit test Lukas Straub
2026-03-06 13:07 ` Fabiano Rosas
-- strict thread matches above, loose matches on Subject: below --
2026-03-02 10:19 Lukas Straub
2026-03-02 10:20 ` [PATCH v11 19/21] colo: Use file lock in primary_vm_do_failover() Lukas Straub
2026-03-02 10:13 [PATCH v11 00/21] migration: Add COLO multifd support and COLO migration unit test Lukas Straub
2026-03-02 10:13 ` [PATCH v11 19/21] colo: Use file lock in primary_vm_do_failover() Lukas Straub
2026-03-01 21:37 [PATCH v11 00/21] migration: Add COLO multifd support and COLO migration unit test Lukas Straub
2026-03-01 21:37 ` [PATCH v11 19/21] colo: Use file lock in primary_vm_do_failover() Lukas Straub
2026-03-01 19:16 [PATCH v11 00/21] migration: Add COLO multifd support and COLO migration unit test Lukas Straub
2026-03-01 19:16 ` [PATCH v11 19/21] colo: Use file lock in primary_vm_do_failover() Lukas Straub
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaXt36L664YyBz63@x1.local \
--to=peterx@redhat.com \
--cc=farosas@suse.de \
--cc=lizhijian@fujitsu.com \
--cc=lukasstraub2@web.de \
--cc=qemu-devel@nongnu.org \
--cc=zhangckid@gmail.com \
--cc=zhanghailiang@xfusion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.