From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Dibin Moolakadan Subrahmanian <dibin.moolakadan.subrahmanian@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
uma.shankar@intel.com, swati2.sharma@intel.com
Subject: Re: [PATCH] drm/i915/dmc: Update PIPEDMC interrupt mask
Date: Tue, 10 Mar 2026 11:50:53 +0200 [thread overview]
Message-ID: <aa_pfV7gz8r-QVl3@intel.com> (raw)
In-Reply-To: <20260310083047.2593048-1-dibin.moolakadan.subrahmanian@intel.com>
On Tue, Mar 10, 2026 at 02:00:47PM +0530, Dibin Moolakadan Subrahmanian wrote:
> >From display version 35 onwards PIPEDMC_ATS_FAULT and
> PIPEDMC_GTT_FAULT interrupt bits are no longer defined.
>
> Update the interrupt mask to drop these and
> enable the PIPEDMC_ERROR interrupt.
That's two different things in one patch. Please split
properly.
>
> Signed-off-by: Dibin Moolakadan Subrahmanian <dibin.moolakadan.subrahmanian@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_dmc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
> index c3b411259a0c..e60f1f977070 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -509,6 +509,10 @@ static void pipedmc_clock_gating_wa(struct intel_display *display, bool enable)
>
> static u32 pipedmc_interrupt_mask(struct intel_display *display)
> {
> + if (DISPLAY_VER(display) >= 35)
> + return PIPEDMC_FLIPQ_PROG_DONE |
> + PIPEDMC_ERROR;
> +
> /*
> * FIXME PIPEDMC_ERROR not enabled for now due to LNL pipe B
> * triggering it during the first DC state transition. Figure
> --
> 2.43.0
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2026-03-10 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 8:30 [PATCH] drm/i915/dmc: Update PIPEDMC interrupt mask Dibin Moolakadan Subrahmanian
2026-03-10 8:36 ` ✓ CI.KUnit: success for " Patchwork
2026-03-10 9:16 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-10 9:50 ` Ville Syrjälä [this message]
2026-03-10 11:25 ` ✓ i915.CI.BAT: " Patchwork
2026-03-10 12:36 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-10 18:14 ` ✓ i915.CI.Full: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa_pfV7gz8r-QVl3@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=dibin.moolakadan.subrahmanian@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.