From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4142C4363D for ; Sat, 3 Oct 2020 09:30:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56C36206F8 for ; Sat, 3 Oct 2020 09:30:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="aXk39uWX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725763AbgJCJaU (ORCPT ); Sat, 3 Oct 2020 05:30:20 -0400 Received: from m42-4.mailgun.net ([69.72.42.4]:43572 "EHLO m42-4.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725681AbgJCJaU (ORCPT ); Sat, 3 Oct 2020 05:30:20 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1601717419; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=FzIU36C+hDT4BtAfB8saeMh3Wpo/oBl9snORYDlntFo=; b=aXk39uWX4iT5US5Sr0tpLMOtrQMVd3Ls6tVTG2tH8gDppNGV+Crpzj+TWURXyhlRM580UTGK WZhvU8ffepNICZzyJijY+K9fZlIedt6kUgCdSQNL6UtuCrk5T2WL0btao7OwYizzdq4hd8G6 kT0zv2Dv4zHy9oLVfuZh/b66HYA= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 5f7844aaad37af35ec84938d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 03 Oct 2020 09:30:18 GMT Sender: rmanohar=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D037CC433CA; Sat, 3 Oct 2020 09:30:18 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rmanohar) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4B91FC433C8; Sat, 3 Oct 2020 09:30:18 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 03 Oct 2020 02:30:18 -0700 From: Rajkumar Manoharan To: Johannes Berg Cc: linux-wireless@vger.kernel.org Subject: Re: [PATCH] cfg80211: add support to configure HE MCS for beacon rate In-Reply-To: References: <1600143587-25327-1-git-send-email-rmanohar@codeaurora.org> Message-ID: X-Sender: rmanohar@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-09-18 05:05, Johannes Berg wrote: > On Mon, 2020-09-14 at 21:19 -0700, Rajkumar Manoharan wrote: >> This allows an option to configure a single HE MCS beacon tx rate. > > This breaks the ap_beacon_rate_legacy2 hwsim test but I'm not sure why, > please check. > Ah... Thanks for reporting... Hostapd has to clear VHT/HE rates while setting legacy beacon tx rate. Otherwise the default he_mcs is filled and causing hwsim failure. Posted a fix[1] for review. Rajkumar [1] http://patchwork.ozlabs.org/project/hostap/patch/1601717108-1030-1-git-send-email-rmanohar@codeaurora.org/