From: Cheng-Yang Chou <yphbchou0911@gmail.com>
To: charlie910417@gmail.com, jserv@ccns.ncku.edu.tw, leon@kernel.org,
mbloch@nvidia.com, netdev@vger.kernel.org, saeedm@nvidia.com,
tariqt@nvidia.com
Subject: Re: [PATCH v3] net/mlx5/core: Allocate ttc_params on heap
Date: Tue, 3 Mar 2026 18:36:39 +0800 [thread overview]
Message-ID: <aaa5tyHK5L-btPtd@eric-acer> (raw)
In-Reply-To: <20260226174601.2120282-1-yphbchou0911@gmail.com>
On Fri, Feb 27, 2026 at 01:46:01AM +0800, Cheng-Yang Chou wrote:
> The ttc_params structure is too large to be allocated on the stack,
> triggering warnings for exceeding the 1024-byte frame size limit.
> Consuming excessive stack space risks causing stack overflows.
>
> Allocate the structure dynamically to maintain safe stack boundaries.
>
> Signed-off-by: Po-Ying Chiu <charlie910417@gmail.com>
> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
> Suggested-by: Leon Romanovsky <leon@kernel.org>
> ---
> Changes in v3:
> - Use tabs instead of spaces for indentation
> - Link to v2: https://lore.kernel.org/all/20260226114219.2111793-1-yphbchou0911@gmail.com/
>
> Changes in v2:
> - Use kzalloc_obj() instead of kzalloc() to align with the new memory
> allocation API introduced in v7.0-rc1 (Leon Romanovsky)
> - Link to v1: https://lore.kernel.org/all/20260226092857.1583984-1-yphbchou0911@gmail.com/
>
> .../net/ethernet/mellanox/mlx5/core/en_rep.c | 15 +++++++++----
> .../net/ethernet/mellanox/mlx5/core/en_tc.c | 15 ++++++++++---
> .../mellanox/mlx5/core/lag/port_sel.c | 22 ++++++++++++++-----
> 3 files changed, 39 insertions(+), 13 deletions(-)
Gentle ping.
Please let me know if any changes are needed.
--
Thanks,
Cheng-Yang
next prev parent reply other threads:[~2026-03-03 10:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-26 11:42 [PATCH v2] net/mlx5/core: Allocate ttc_params on heap Cheng-Yang Chou
2026-02-26 17:46 ` [PATCH v3] " Cheng-Yang Chou
2026-03-03 10:36 ` Cheng-Yang Chou [this message]
2026-03-04 7:53 ` Tariq Toukan
2026-03-14 17:30 ` Cheng-Yang Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaa5tyHK5L-btPtd@eric-acer \
--to=yphbchou0911@gmail.com \
--cc=charlie910417@gmail.com \
--cc=jserv@ccns.ncku.edu.tw \
--cc=leon@kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.