Re: [PATCH 2/3] platform/mellanox: mlxbf-tmfifo: Remove unnecessary bool conversion

[Hans de Goede <hdegoede@redhat.com>]

Hi,

On 11/4/23 00:54, Jules Irenge wrote:
> This commit fixes coccinelle warning in macro function
> IS_VRING_DROP() which complains conversion to bool not needed here.
> 
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/mellanox/mlxbf-tmfifo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c b/drivers/platform/mellanox/mlxbf-tmfifo.c
> index ab7d7a1235b8..88472c024680 100644
> --- a/drivers/platform/mellanox/mlxbf-tmfifo.c
> +++ b/drivers/platform/mellanox/mlxbf-tmfifo.c
> @@ -91,7 +91,7 @@ struct mlxbf_tmfifo_vring {
>  /* Check whether vring is in drop mode. */
>  #define IS_VRING_DROP(_r) ({ \
>  	typeof(_r) (r) = (_r); \
> -	(r->desc_head == &r->drop_desc ? true : false); })
> +	r->desc_head == &r->drop_desc; })
>  
>  /* A stub length to drop maximum length packet. */
>  #define VRING_DROP_DESC_MAX_LEN		GENMASK(15, 0)