From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v3 1/2] drm: Add per-plane pixel blend mode property Date: Tue, 14 Aug 2018 11:15:43 +0200 Message-ID: References: <1527856871-3007-1-git-send-email-lowry.li@arm.com> <1527856871-3007-2-git-send-email-lowry.li@arm.com> <20180605090729.GA2686@lowry.li@arm.com> <325674b0-d100-4e38-3963-0e458e6dec80@linux.intel.com> <20180814031102.GA8541@lowry.li@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 81E41893B8 for ; Tue, 14 Aug 2018 09:15:48 +0000 (UTC) In-Reply-To: <20180814031102.GA8541@lowry.li@arm.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lowry Li Cc: David Airlie , Emil Velikov , Liviu Dudau , "Linux-Kernel@Vger. Kernel. Org" , ML dri-devel , Mali DP Maintainers , "Vetter, Daniel" , nd@arm.com List-Id: dri-devel@lists.freedesktop.org T3AgMTQtMDgtMTggb20gMDU6MTEgc2NocmVlZiBMb3dyeSBMaToKPiBPbiBNb24sIEF1ZyAxMywg MjAxOCBhdCAxMjo0OToxM1BNICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPj4gT3Ag MDUtMDYtMTggb20gMTE6MDcgc2NocmVlZiBMb3dyeSBMaToKPj4+IE9uIE1vbiwgSnVuIDA0LCAy MDE4IGF0IDAyOjQ5OjI2UE0gKzAxMDAsIEVtaWwgVmVsaWtvdiB3cm90ZToKPj4+PiBPbiAxIEp1 bmUgMjAxOCBhdCAxMzo0MSwgTG93cnkgTGkgPGxvd3J5LmxpQGFybS5jb20+IHdyb3RlOgo+Pj4+ PiBQaXhlbCBibGVuZCBtb2RlcyByZXByZXNlbnQgdGhlIGFscGhhIGJsZW5kaW5nIGVxdWF0aW9u Cj4+Pj4+IHNlbGVjdGlvbiwgZGVzY3JpYmluZyBob3cgdGhlIHBpeGVscyBmcm9tIHRoZSBjdXJy ZW50Cj4+Pj4+IHBsYW5lIGFyZSBjb21wb3NpdGVkIHdpdGggdGhlIGJhY2tncm91bmQuCj4+Pj4+ Cj4+Pj4+IEFkZCBhIHBpeGVsX2JsZW5kX21vZGUgdG8gZHJtX3BsYW5lX3N0YXRlIGFuZCBhCj4+ Pj4+IGJsZW5kX21vZGVfcHJvcGVydHkgdG8gZHJtX3BsYW5lLCBhbmQgcmVsYXRlZCBzdXBwb3J0 Cj4+Pj4+IGZ1bmN0aW9ucy4KPj4+Pj4KPj4+Pj4gRGVmaW5lcyB0aHJlZSBibGVuZCBtb2RlcyBp biBkcm1fYmxlbmQuaC4KPj4+Pj4KPj4+Pj4gU2lnbmVkLW9mZi1ieTogTG93cnkgTGkgPGxvd3J5 LmxpQGFybS5jb20+Cj4+Pj4+IC0tLQo+Pj4+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMu YyAgICAgICAgfCAgIDQgKysKPj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBl ci5jIHwgICAxICsKPj4+Pj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYmxlbmQuYyAgICAgICAgIHwg MTI2ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwo+Pj4+PiAgaW5jbHVkZS9k cm0vZHJtX2JsZW5kLmggICAgICAgICAgICAgfCAgIDYgKysKPj4+Pj4gIGluY2x1ZGUvZHJtL2Ry bV9wbGFuZS5oICAgICAgICAgICAgIHwgICA1ICsrCj4+Pj4+ICA1IGZpbGVzIGNoYW5nZWQsIDE0 MiBpbnNlcnRpb25zKCspCj4+Pj4+Cj4+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v ZHJtX2F0b21pYy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+Pj4+PiBpbmRleCAw N2ZlZjQyLi4xZDE4Mzg5IDEwMDY0NAo+Pj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0 b21pYy5jCj4+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljLmMKPj4+Pj4gQEAg LTc4NSw2ICs3ODUsOCBAQCBzdGF0aWMgaW50IGRybV9hdG9taWNfcGxhbmVfc2V0X3Byb3BlcnR5 KHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+Pj4+PiAgICAgICAgICAgICAgICAgc3RhdGUtPnNy Y19oID0gdmFsOwo+Pj4+PiAgICAgICAgIH0gZWxzZSBpZiAocHJvcGVydHkgPT0gcGxhbmUtPmFs cGhhX3Byb3BlcnR5KSB7Cj4+Pj4+ICAgICAgICAgICAgICAgICBzdGF0ZS0+YWxwaGEgPSB2YWw7 Cj4+Pj4+ICsgICAgICAgfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBwbGFuZS0+YmxlbmRfbW9kZV9w cm9wZXJ0eSkgewo+Pj4+PiArICAgICAgICAgICAgICAgc3RhdGUtPnBpeGVsX2JsZW5kX21vZGUg PSB2YWw7Cj4+Pj4+ICAgICAgICAgfSBlbHNlIGlmIChwcm9wZXJ0eSA9PSBwbGFuZS0+cm90YXRp b25fcHJvcGVydHkpIHsKPj4+Pj4gICAgICAgICAgICAgICAgIGlmICghaXNfcG93ZXJfb2ZfMih2 YWwgJiBEUk1fTU9ERV9ST1RBVEVfTUFTSykpCj4+Pj4+ICAgICAgICAgICAgICAgICAgICAgICAg IHJldHVybiAtRUlOVkFMOwo+Pj4+PiBAQCAtODUyLDYgKzg1NCw4IEBAIHN0YXRpYyBpbnQgZHJt X2F0b21pY19wbGFuZV9zZXRfcHJvcGVydHkoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4+Pj4+ ICAgICAgICAgICAgICAgICAqdmFsID0gc3RhdGUtPnNyY19oOwo+Pj4+PiAgICAgICAgIH0gZWxz ZSBpZiAocHJvcGVydHkgPT0gcGxhbmUtPmFscGhhX3Byb3BlcnR5KSB7Cj4+Pj4+ICAgICAgICAg ICAgICAgICAqdmFsID0gc3RhdGUtPmFscGhhOwo+Pj4+PiArICAgICAgIH0gZWxzZSBpZiAocHJv cGVydHkgPT0gcGxhbmUtPmJsZW5kX21vZGVfcHJvcGVydHkpIHsKPj4+Pj4gKyAgICAgICAgICAg ICAgICp2YWwgPSBzdGF0ZS0+cGl4ZWxfYmxlbmRfbW9kZTsKPj4+Pj4gICAgICAgICB9IGVsc2Ug aWYgKHByb3BlcnR5ID09IHBsYW5lLT5yb3RhdGlvbl9wcm9wZXJ0eSkgewo+Pj4+PiAgICAgICAg ICAgICAgICAgKnZhbCA9IHN0YXRlLT5yb3RhdGlvbjsKPj4+Pj4gICAgICAgICB9IGVsc2UgaWYg KHByb3BlcnR5ID09IHBsYW5lLT56cG9zX3Byb3BlcnR5KSB7Cj4+Pj4+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f YXRvbWljX2hlbHBlci5jCj4+Pj4+IGluZGV4IDEzMGRhNTEuLjdmNWQ0NjMgMTAwNjQ0Cj4+Pj4+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4+Pj4+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4+Pj4+IEBAIC0zNTE1LDYgKzM1MTUs NyBAQCB2b2lkIGRybV9hdG9taWNfaGVscGVyX3BsYW5lX3Jlc2V0KHN0cnVjdCBkcm1fcGxhbmUg KnBsYW5lKQo+Pj4+PiAgICAgICAgICAgICAgICAgLyogUmVzZXQgdGhlIGFscGhhIHZhbHVlIHRv IGZ1bGx5IG9wYXF1ZSBpZiBpdCBtYXR0ZXJzICovCj4+Pj4+ICAgICAgICAgICAgICAgICBpZiAo cGxhbmUtPmFscGhhX3Byb3BlcnR5KQo+Pj4+PiAgICAgICAgICAgICAgICAgICAgICAgICBwbGFu ZS0+c3RhdGUtPmFscGhhID0gcGxhbmUtPmFscGhhX3Byb3BlcnR5LT52YWx1ZXNbMV07Cj4+Pj4+ ICsgICAgICAgICAgICAgICBwbGFuZS0+c3RhdGUtPnBpeGVsX2JsZW5kX21vZGUgPSBEUk1fTU9E RV9CTEVORF9QUkVNVUxUSTsKPj4+Pj4gICAgICAgICB9Cj4+Pj4+ICB9Cj4+Pj4+ICBFWFBPUlRf U1lNQk9MKGRybV9hdG9taWNfaGVscGVyX3BsYW5lX3Jlc2V0KTsKPj4+Pj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fYmxlbmQuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYmxlbmQu Ywo+Pj4+PiBpbmRleCBhMTZhNzRkLi5hYzZmMTljIDEwMDY0NAo+Pj4+PiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2JsZW5kLmMKPj4+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9ibGVu ZC5jCj4+Pj4+IEBAIC0xMDcsNiArMTA3LDUyIEBACj4+Pj4+ICAgKiAgICAgcGxhbmVzLiBXaXRo b3V0IHRoaXMgcHJvcGVydHkgdGhlIHByaW1hcnkgcGxhbmUgaXMgYWx3YXlzIGJlbG93IHRoZSBj dXJzb3IKPj4+Pj4gICAqICAgICBwbGFuZSwgYW5kIG9yZGVyaW5nIGJldHdlZW4gYWxsIG90aGVy IHBsYW5lcyBpcyB1bmRlZmluZWQuCj4+Pj4+ICAgKgo+Pj4+PiArICogcGl4ZWwgYmxlbmQgbW9k ZToKPj4+Pj4gKyAqICAgICBQaXhlbCBibGVuZCBtb2RlIGlzIHNldCB1cCB3aXRoIGRybV9wbGFu ZV9jcmVhdGVfYmxlbmRfbW9kZV9wcm9wZXJ0eSgpLgo+Pj4+PiArICogICAgIEl0IGFkZHMgYSBi bGVuZCBtb2RlIGZvciBhbHBoYSBibGVuZGluZyBlcXVhdGlvbiBzZWxlY3Rpb24sIGRlc2NyaWJp bmcKPj4+Pj4gKyAqICAgICBob3cgdGhlIHBpeGVscyBmcm9tIHRoZSBjdXJyZW50IHBsYW5lIGFy ZSBjb21wb3NpdGVkIHdpdGggdGhlCj4+Pj4+ICsgKiAgICAgYmFja2dyb3VuZC4KPj4+Pj4gKyAq Cj4+Pj4+ICsgKiAgICAgIFRocmVlIGFscGhhIGJsZW5kaW5nIGVxdWF0aW9ucyBhcmUgZGVmaW5l ZDoKPj4+Pj4gKyAqCj4+Pj4+ICsgKiAgICAgICJOb25lIjoKPj4+Pj4gKyAqICAgICAgICAgICAg ICBCbGVuZCBmb3JtdWxhIHRoYXQgaWdub3JlcyB0aGUgcGl4ZWwgYWxwaGE6Ogo+Pj4+PiArICoK Pj4+Pj4gKyAqICAgICAgICAgICAgICAgICAgICAgIG91dC5yZ2IgPSBwbGFuZV9hbHBoYSAqIGZn LnJnYiArCj4+Pj4+ICsgKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgxIC0gcGxhbmVf YWxwaGEpICogYmcucmdiCj4+Pj4+ICsgKgo+Pj4+PiArICogICAgICAiUHJlLW11bHRpcGxpZWQi Ogo+Pj4+PiArICogICAgICAgICAgICAgIEJsZW5kIGZvcm11bGEgdGhhdCBhc3N1bWVzIHRoZSBw aXhlbCBjb2xvciB2YWx1ZXMKPj4+Pj4gKyAqICAgICAgICAgICAgICBoYXZlIGJlZW4gYWxyZWFk eSBwcmUtbXVsdGlwbGllZCB3aXRoIHRoZSBhbHBoYQo+Pj4+PiArICogICAgICAgICAgICAgIGNo YW5uZWwgdmFsdWVzOjoKPj4+Pj4gKyAqCj4+Pj4+ICsgKiAgICAgICAgICAgICAgICAgICAgICBv dXQucmdiID0gcGxhbmVfYWxwaGEgKiBmZy5yZ2IgKwo+Pj4+PiArICogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoMSAtIChwbGFuZV9hbHBoYSAqIGZnLmFscGhhKSkgKiBiZy5yZ2IKPj4+ Pj4gKyAqCj4+Pj4+ICsgKiAgICAgICJDb3ZlcmFnZSI6Cj4+Pj4+ICsgKiAgICAgICAgICAgICAg QmxlbmQgZm9ybXVsYSB0aGF0IGFzc3VtZXMgdGhlIHBpeGVsIGNvbG9yIHZhbHVlcyBoYXZlIG5v dAo+Pj4+PiArICogICAgICAgICAgICAgIGJlZW4gcHJlLW11bHRpcGxpZWQgYW5kIHdpbGwgZG8g c28gd2hlbiBibGVuZGluZyB0aGVtIHRvIHRoZQo+Pj4+PiArICogICAgICAgICAgICAgIGJhY2tn cm91bmQgY29sb3IgdmFsdWVzOjoKPj4+Pj4gKyAqCj4+Pj4+ICsgKiAgICAgICAgICAgICAgICAg ICAgICBvdXQucmdiID0gcGxhbmVfYWxwaGEgKiBmZy5hbHBoYSAqIGZnLnJnYiArCj4+Pj4+ICsg KiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgxIC0gKHBsYW5lX2FscGhhICogZmcuYWxw aGEpKSAqIGJnLnJnYgo+Pj4+PiArICoKPj4+Pj4gKyAqICAgICAgVXNpbmcgdGhlIGZvbGxvd2lu ZyBzeW1ib2xzOgo+Pj4+PiArICoKPj4+Pj4gKyAqICAgICAgYGBmZy5yZ2JgYDoKPj4+Pj4gKyAq ICAgICAgICAgICAgICBFYWNoIG9mIHRoZSBSR0IgY29tcG9uZW50IHZhbHVlcyBmcm9tIHRoZSBw bGFuZSdzIHBpeGVsCj4+Pj4+ICsgKiAgICAgIGBgZmcuYWxwaGFgYDoKPj4+Pj4gKyAqICAgICAg ICAgICAgICBBbHBoYSBjb21wb25lbnQgdmFsdWUgZnJvbSB0aGUgcGxhbmUncyBwaXhlbC4gSWYg dGhlIHBsYW5lJ3MKPj4+Pj4gKyAqICAgICAgICAgICAgICBwaXhlbCBmb3JtYXQgaGFzIG5vIGFs cGhhIGNvbXBvbmVudCwgdGhlbiB0aGlzIGlzIGFzc3VtZWQgdG8gYmUKPj4+Pj4gKyAqICAgICAg ICAgICAgICAxLjAuIEluIHRoZXNlIGNhc2VzLCB0aGlzIHByb3BlcnR5IGhhcyBubyBlZmZlY3Qs IGFzIGFsbCB0aHJlZQo+Pj4+PiArICogICAgICAgICAgICAgIGVxdWF0aW9ucyBiZWNvbWUgZXF1 aXZhbGVudC4KPj4+Pj4gKyAqICAgICAgYGBiZy5yZ2JgYDoKPj4+Pj4gKyAqICAgICAgICAgICAg ICBFYWNoIG9mIHRoZSBSR0IgY29tcG9uZW50IHZhbHVlcyBmcm9tIHRoZSBiYWNrZ3JvdW5kCj4+ Pj4+ICsgKiAgICAgIGBgcGxhbmVfYWxwaGFgYDoKPj4+Pj4gKyAqICAgICAgICAgICAgICBQbGFu ZSBhbHBoYSB2YWx1ZSBzZXQgYnkgdGhlIHBsYW5lICJhbHBoYSIgcHJvcGVydHkuIElmIHRoZQo+ Pj4+PiArICogICAgICAgICAgICAgIHBsYW5lIGRvZXMgbm90IGV4cG9zZSB0aGUgImFscGhhIiBw cm9wZXJ0eSwgdGhlbiB0aGlzIGlzCj4+Pj4+ICsgKiAgICAgICAgICAgICAgYXNzdW1lZCB0byBi ZSAxLjAKPj4+Pj4gKyAqCj4+Pj4+ICAgKiBOb3RlIHRoYXQgYWxsIHRoZSBwcm9wZXJ0eSBleHRl bnNpb25zIGRlc2NyaWJlZCBoZXJlIGFwcGx5IGVpdGhlciB0byB0aGUKPj4+Pj4gICAqIHBsYW5l IG9yIHRoZSBDUlRDIChlLmcuIGZvciB0aGUgYmFja2dyb3VuZCBjb2xvciwgd2hpY2ggY3VycmVu dGx5IGlzIG5vdAo+Pj4+PiAgICogZXhwb3NlZCBhbmQgYXNzdW1lZCB0byBiZSBibGFjaykuCj4+ Pj4+IEBAIC00NDgsMyArNDk0LDgzIEBAIGludCBkcm1fYXRvbWljX25vcm1hbGl6ZV96cG9zKHN0 cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4+Pj4+ICAgICAgICAgcmV0dXJuIDA7Cj4+Pj4+ICB9Cj4+ Pj4+ICBFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfbm9ybWFsaXplX3pwb3MpOwo+Pj4+PiArCj4+ Pj4+ICsvKioKPj4+Pj4gKyAqIGRybV9wbGFuZV9jcmVhdGVfYmxlbmRfbW9kZV9wcm9wZXJ0eSAt IGNyZWF0ZSBhIG5ldyBibGVuZCBtb2RlIHByb3BlcnR5Cj4+Pj4+ICsgKiBAcGxhbmU6IGRybSBw bGFuZQo+Pj4+PiArICogQHN1cHBvcnRlZF9tb2RlczogYml0bWFzayBvZiBzdXBwb3J0ZWQgbW9k ZXMsIG11c3QgaW5jbHVkZQo+Pj4+PiArICogICAgICAgICAgICAgICAgICBCSVQoRFJNX01PREVf QkxFTkRfUFJFTVVMVEkpLiBDdXJyZW50IERSTSBhc3N1bXB0aW9uIGlzCj4+Pj4+ICsgKiAgICAg ICAgICAgICAgICAgIHRoYXQgYWxwaGEgaXMgcHJlbXVsdGlwbGllZCwgYW5kIG9sZCB1c2Vyc3Bh Y2UgY2FuIGJyZWFrIGlmCj4+Pj4+ICsgKiAgICAgICAgICAgICAgICAgIHRoZSBwcm9wZXJ0eSBk ZWZhdWx0cyB0byBjb3ZlcmFnZS4KPj4+Pj4gKyAqCj4+Pj4gVGhhbmtzIGZvciB0aGUgZXhwbGFu YXRpb24gTG93cnkuCj4+Pj4gU2lnaCwgb2xkIHVzZXJzcGFjZSA6LVwKPj4+Pgo+Pj4+IE9uZSBw ZWRhbnRpYyBzdWdnZXN0aW9uIHMvZGVmYXVsdHMgdG8gY292ZXJhZ2UvZGVmYXVsdHMgdG8gYW55 dGhpbmcgZWxzZS8KPj4+PiBTaW5jZSBkZWZhdWx0aW5nIHRvICJub25lIiBvciBhbnkgZnV0dXJl IGJsZW5kIG1vZGUgaXMgYWxzbyBhIG5vLWdvLgo+Pj4+Cj4+Pj4gSSB3b3VsZG4ndCBib3RoZXIg cmVzZW5kaW5nIHNvbGVseSBmb3IgXl4uIFBlcmhhcHMgc3F1YXNoIGxvY2FsbHkKPj4+PiBiZWZv cmUgbWVyZ2luZz8KPj4+Pgo+Pj4+IFdpdGggdGhhdCwgdGhlIHBhdGNoIGlzCj4+Pj4gUmV2aWV3 ZWQtYnk6IEVtaWwgVmVsaWtvdiA8ZW1pbC52ZWxpa292QGNvbGxhYm9yYS5jb20+Cj4+Pj4KPj4+ PiAtRW1pbAo+Pj4gSGkgRW1pbCwKPj4+Cj4+PiBUaGFua3MgYSBsb3QgZm9yIHlvdXIgcmV2aWV3 IGFuZCB3aWxsIGNoYW5nZSB0aGF0Lgo+PiBQaW5nPyBBbnkgdXBkYXRlcz8KPj4KPj4gfk1hYXJ0 ZW4KPiBIaSBNYWFydGVuLAo+Cj4gU28gZmFyIHRoZSBtZXJnZSByZXF1ZXN0IG9uIHVzZXIgc3Bh Y2UgcGF0Y2ggaGFzIGJlZW4gdmVyaWZpZWQgYnkgSm9obgo+IFN0dWx0ei4gVGhlIGNvbW1lbnRz IGZyb20gU2VhbiBoYXMgYmVlbiBmaXhlZCBhbmQgbm93IHdlIGFyZSB3YWl0aW5nIHRoZQo+IHJl dmlld2VkLXRhZyBmcm9tIFNlYW4uIE9uY2UgaXQgbWVyZ2VkLCB3ZSdsbCBzZW5kIGEgbmV3IGtl cm5lbCBwYXRjaCB0bwo+IHJldmlldy4KPgpIZXksCgpJbiBnZW5lcmFsIHRoZSBrZXJuZWwgcGF0 Y2ggc2hvdWxkIGJlIG1lcmdlZCBmaXJzdCwgYmVjYXVzZSB1c2Vyc3BhY2UgY2Fubm90IHJlbHkg b24gdGhlIGJlaGF2aW9yIHVudGlsIHRoZSBuZXh0IC1yYzEgdGhhdCBpbnRlZ3JhdGVzIGl0LgpI b3dldmVyLCBpbiBvcmRlciB0byBtZXJnZSB0aGUga2VybmVsIHBhdGNoLCBhIHVzZXJzcGFjZSBw cm9vZiBvZiBjb25jZXB0IGZvciB2YWxpZGF0aW9uIGlzIG5lZWRlZCBmaXJzdC4gU2luY2UgeW91 J3JlIGNsb3NlIHRvIG1lcmdpbmcsCkkgd291bGQgc2F5IHRoZSB1c2Vyc3BhY2UgcmVxdWlyZW1l bnQgaXMgc2F0aXNmaWVkLiBJdCdzIHNhZmUgdG8gc2VuZCB0aGUga2VybmVsIHBhdGNoLiA6KQoK fk1hYXJ0ZW4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 405EFC46464 for ; Tue, 14 Aug 2018 09:15:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C08AE21729 for ; Tue, 14 Aug 2018 09:15:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C08AE21729 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731370AbeHNMCG (ORCPT ); Tue, 14 Aug 2018 08:02:06 -0400 Received: from mga09.intel.com ([134.134.136.24]:14770 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728101AbeHNMCF (ORCPT ); Tue, 14 Aug 2018 08:02:05 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Aug 2018 02:15:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,237,1531810800"; d="scan'208";a="66021292" Received: from sneaga-mobl.ger.corp.intel.com (HELO [10.252.51.111]) ([10.252.51.111]) by orsmga006.jf.intel.com with ESMTP; 14 Aug 2018 02:15:44 -0700 Subject: Re: [PATCH v3 1/2] drm: Add per-plane pixel blend mode property To: Lowry Li Cc: Emil Velikov , Liviu Dudau , Gustavo Padovan , "Vetter, Daniel" , Sean Paul , David Airlie , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , ML dri-devel , "Linux-Kernel@Vger. Kernel. Org" , Brian Starkey , Mali DP Maintainers , nd@arm.com References: <1527856871-3007-1-git-send-email-lowry.li@arm.com> <1527856871-3007-2-git-send-email-lowry.li@arm.com> <20180605090729.GA2686@lowry.li@arm.com> <325674b0-d100-4e38-3963-0e458e6dec80@linux.intel.com> <20180814031102.GA8541@lowry.li@arm.com> From: Maarten Lankhorst Message-ID: Date: Tue, 14 Aug 2018 11:15:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180814031102.GA8541@lowry.li@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 14-08-18 om 05:11 schreef Lowry Li: > On Mon, Aug 13, 2018 at 12:49:13PM +0200, Maarten Lankhorst wrote: >> Op 05-06-18 om 11:07 schreef Lowry Li: >>> On Mon, Jun 04, 2018 at 02:49:26PM +0100, Emil Velikov wrote: >>>> On 1 June 2018 at 13:41, Lowry Li wrote: >>>>> Pixel blend modes represent the alpha blending equation >>>>> selection, describing how the pixels from the current >>>>> plane are composited with the background. >>>>> >>>>> Add a pixel_blend_mode to drm_plane_state and a >>>>> blend_mode_property to drm_plane, and related support >>>>> functions. >>>>> >>>>> Defines three blend modes in drm_blend.h. >>>>> >>>>> Signed-off-by: Lowry Li >>>>> --- >>>>> drivers/gpu/drm/drm_atomic.c | 4 ++ >>>>> drivers/gpu/drm/drm_atomic_helper.c | 1 + >>>>> drivers/gpu/drm/drm_blend.c | 126 ++++++++++++++++++++++++++++++++++++ >>>>> include/drm/drm_blend.h | 6 ++ >>>>> include/drm/drm_plane.h | 5 ++ >>>>> 5 files changed, 142 insertions(+) >>>>> >>>>> diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c >>>>> index 07fef42..1d18389 100644 >>>>> --- a/drivers/gpu/drm/drm_atomic.c >>>>> +++ b/drivers/gpu/drm/drm_atomic.c >>>>> @@ -785,6 +785,8 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, >>>>> state->src_h = val; >>>>> } else if (property == plane->alpha_property) { >>>>> state->alpha = val; >>>>> + } else if (property == plane->blend_mode_property) { >>>>> + state->pixel_blend_mode = val; >>>>> } else if (property == plane->rotation_property) { >>>>> if (!is_power_of_2(val & DRM_MODE_ROTATE_MASK)) >>>>> return -EINVAL; >>>>> @@ -852,6 +854,8 @@ static int drm_atomic_plane_set_property(struct drm_plane *plane, >>>>> *val = state->src_h; >>>>> } else if (property == plane->alpha_property) { >>>>> *val = state->alpha; >>>>> + } else if (property == plane->blend_mode_property) { >>>>> + *val = state->pixel_blend_mode; >>>>> } else if (property == plane->rotation_property) { >>>>> *val = state->rotation; >>>>> } else if (property == plane->zpos_property) { >>>>> diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c >>>>> index 130da51..7f5d463 100644 >>>>> --- a/drivers/gpu/drm/drm_atomic_helper.c >>>>> +++ b/drivers/gpu/drm/drm_atomic_helper.c >>>>> @@ -3515,6 +3515,7 @@ void drm_atomic_helper_plane_reset(struct drm_plane *plane) >>>>> /* Reset the alpha value to fully opaque if it matters */ >>>>> if (plane->alpha_property) >>>>> plane->state->alpha = plane->alpha_property->values[1]; >>>>> + plane->state->pixel_blend_mode = DRM_MODE_BLEND_PREMULTI; >>>>> } >>>>> } >>>>> EXPORT_SYMBOL(drm_atomic_helper_plane_reset); >>>>> diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c >>>>> index a16a74d..ac6f19c 100644 >>>>> --- a/drivers/gpu/drm/drm_blend.c >>>>> +++ b/drivers/gpu/drm/drm_blend.c >>>>> @@ -107,6 +107,52 @@ >>>>> * planes. Without this property the primary plane is always below the cursor >>>>> * plane, and ordering between all other planes is undefined. >>>>> * >>>>> + * pixel blend mode: >>>>> + * Pixel blend mode is set up with drm_plane_create_blend_mode_property(). >>>>> + * It adds a blend mode for alpha blending equation selection, describing >>>>> + * how the pixels from the current plane are composited with the >>>>> + * background. >>>>> + * >>>>> + * Three alpha blending equations are defined: >>>>> + * >>>>> + * "None": >>>>> + * Blend formula that ignores the pixel alpha:: >>>>> + * >>>>> + * out.rgb = plane_alpha * fg.rgb + >>>>> + * (1 - plane_alpha) * bg.rgb >>>>> + * >>>>> + * "Pre-multiplied": >>>>> + * Blend formula that assumes the pixel color values >>>>> + * have been already pre-multiplied with the alpha >>>>> + * channel values:: >>>>> + * >>>>> + * out.rgb = plane_alpha * fg.rgb + >>>>> + * (1 - (plane_alpha * fg.alpha)) * bg.rgb >>>>> + * >>>>> + * "Coverage": >>>>> + * Blend formula that assumes the pixel color values have not >>>>> + * been pre-multiplied and will do so when blending them to the >>>>> + * background color values:: >>>>> + * >>>>> + * out.rgb = plane_alpha * fg.alpha * fg.rgb + >>>>> + * (1 - (plane_alpha * fg.alpha)) * bg.rgb >>>>> + * >>>>> + * Using the following symbols: >>>>> + * >>>>> + * ``fg.rgb``: >>>>> + * Each of the RGB component values from the plane's pixel >>>>> + * ``fg.alpha``: >>>>> + * Alpha component value from the plane's pixel. If the plane's >>>>> + * pixel format has no alpha component, then this is assumed to be >>>>> + * 1.0. In these cases, this property has no effect, as all three >>>>> + * equations become equivalent. >>>>> + * ``bg.rgb``: >>>>> + * Each of the RGB component values from the background >>>>> + * ``plane_alpha``: >>>>> + * Plane alpha value set by the plane "alpha" property. If the >>>>> + * plane does not expose the "alpha" property, then this is >>>>> + * assumed to be 1.0 >>>>> + * >>>>> * Note that all the property extensions described here apply either to the >>>>> * plane or the CRTC (e.g. for the background color, which currently is not >>>>> * exposed and assumed to be black). >>>>> @@ -448,3 +494,83 @@ int drm_atomic_normalize_zpos(struct drm_device *dev, >>>>> return 0; >>>>> } >>>>> EXPORT_SYMBOL(drm_atomic_normalize_zpos); >>>>> + >>>>> +/** >>>>> + * drm_plane_create_blend_mode_property - create a new blend mode property >>>>> + * @plane: drm plane >>>>> + * @supported_modes: bitmask of supported modes, must include >>>>> + * BIT(DRM_MODE_BLEND_PREMULTI). Current DRM assumption is >>>>> + * that alpha is premultiplied, and old userspace can break if >>>>> + * the property defaults to coverage. >>>>> + * >>>> Thanks for the explanation Lowry. >>>> Sigh, old userspace :-\ >>>> >>>> One pedantic suggestion s/defaults to coverage/defaults to anything else/ >>>> Since defaulting to "none" or any future blend mode is also a no-go. >>>> >>>> I wouldn't bother resending solely for ^^. Perhaps squash locally >>>> before merging? >>>> >>>> With that, the patch is >>>> Reviewed-by: Emil Velikov >>>> >>>> -Emil >>> Hi Emil, >>> >>> Thanks a lot for your review and will change that. >> Ping? Any updates? >> >> ~Maarten > Hi Maarten, > > So far the merge request on user space patch has been verified by John > Stultz. The comments from Sean has been fixed and now we are waiting the > reviewed-tag from Sean. Once it merged, we'll send a new kernel patch to > review. > Hey, In general the kernel patch should be merged first, because userspace cannot rely on the behavior until the next -rc1 that integrates it. However, in order to merge the kernel patch, a userspace proof of concept for validation is needed first. Since you're close to merging, I would say the userspace requirement is satisfied. It's safe to send the kernel patch. :) ~Maarten