From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 672ED366046; Tue, 3 Mar 2026 14:00:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772546416; cv=none; b=U4Bs3q6Ktna2DHJ/QNYk3ogIzoG1mi5WnDBGJVKJBk7v3LpjNDLw7WJ83j3IjR7WzMlVU81IHjuX/ED92Ud/pRNHs3QGNFMgcGfEPCWtVjXo5CO/HKrUWTTC2z3eKef4DMCYfJjfte2aroVCQEevIg6H+8+mNyKtP2POYGtATbQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772546416; c=relaxed/simple; bh=6cVtm8XqyQSVMwAybnkNYIPTy2c7NROxpTQLDmXGUDw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MVY4yWlxwoI6NnxOQbDik1/p7sI9zKx/ToLtAsNBtoY3MgE4B31VF4EGBDuGLwLC5moWXN1HVHH+JgkkqqKsmijAj7oJTNjWJNf3R+QRkWLuBcW2J1NVBk29md9BzoxD6PlFojnXHCTF8cfqyXT7zd0/D0ar9pAWVwwYangXt8c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=2ANHMPvU; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="2ANHMPvU" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oEZ/VbvFt7cbfXL60uAzuqwL1Xkzmb3tbb5L5pK1U5I=; b=2ANHMPvUqrwVZI/9ItBiSdTN6F l8UfE7UMSvuHVZaJWhK09McBQCC5Aai6wPynwg24bukYeaGzQiK2R02Dq4Op8tWnLUmkN7XZ4ajfM Le9GGPICxIH2eRNnZgTpAzJLkRC2JC1BgOkZOOC4aPxulPKDiAeWNkWlYYiPws1+XvyX4ORTgwCM5 U8CK5pP5X5qGQXNTHXXptzr7rmd2nNzFK6HNJZiuSvla56S2Wqhn5KBNWjoA9mRrXVtgSFTmyfqZY Owt+6ulyfJRIOIinFxUHBEz425U0gcsijCxEc2D7tW+/wVqapcxIPHte6W40vmHC4FO8ERdb3AHRo q5JRoAUg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxQHV-0000000FH1T-2Wa9; Tue, 03 Mar 2026 13:59:25 +0000 Date: Tue, 3 Mar 2026 05:59:25 -0800 From: Christoph Hellwig To: Jeff Layton Cc: Christoph Hellwig , "Darrick J. Wong" , Theodore Tso , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dan Williams , Matthew Wilcox , Eric Biggers , Muchun Song , Oscar Salvador , David Hildenbrand , David Howells , Paulo Alcantara , Andreas Dilger , Jan Kara , Jaegeuk Kim , Chao Yu , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Steve French , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Alexander Aring , Ryusuke Konishi , Viacheslav Dubeyko , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Ilya Dryomov , Alex Markuze , Jan Harkes , coda@cs.cmu.edu, Nicolas Pitre , Tyler Hicks , Amir Goldstein , John Paul Adrian Glaubitz , Yangtao Li , Mikulas Patocka , David Woodhouse , Richard Weinberger , Dave Kleikamp , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Anders Larsen , Zhihao Cheng , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Sumit Semwal , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Martin Schiller , Eric Paris , Joerg Reuter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Oliver Hartkopp , Marc Kleine-Budde , David Ahern , Neal Cardwell , Steffen Klassert , Herbert Xu , Remi Denis-Courmont , Marcelo Ricardo Leitner , Xin Long , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, audit@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro Message-ID: References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> <20260303012556.GA6520@macsyma-wired.lan> <20260303042546.GF13868@frogsfrogsfrogs> <33228005140684201de2ca0c157441d3b6a06413.camel@kernel.org> <19e4e79a59dcfc4c61c8cf263af345d0d7026fc8.camel@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19e4e79a59dcfc4c61c8cf263af345d0d7026fc8.camel@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, Mar 03, 2026 at 08:43:15AM -0500, Jeff Layton wrote: > On Tue, 2026-03-03 at 05:37 -0800, Christoph Hellwig wrote: > > On Tue, Mar 03, 2026 at 05:53:39AM -0500, Jeff Layton wrote: > > > Like I said to Ted, this is just temporary scaffolding for the change. > > > The PRIino macro is removed in the end. Given that, perhaps you can > > > overlook the bikeshed's color in this instance? > > > > So why add it in the first place? > > Bisectability. The first version I did of this would have broken the > ability to bisect properly across these changes. I don't love the > "churn" here either, but this should be cleanly bisectable. What do you need to bisect in format string changes? Splitting every variable type change outside of the main i_ino out - sure. But bisecting that "change to u64 in ext4" really broke ext4 and not "change to u64" is not very useful. Commits should do one well defined thing. Adding a weird transition layer for a format thing that just gets dropped is not one well defined thing. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DD8AEC1454 for ; Tue, 3 Mar 2026 14:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=11p6LrcD4lmhHPmXlodBPcnNW6HdqOudVDwwcv79scI=; b=d5nVPGItXqtSTCpi0ZibFjzfUW mkL+uYiXYg5wAEIqiu/oiKgDnA2pkSNFUwYgaHesxTY+kmrGC4oAeej8yquLLE8e1Oe3oLR+05ANQ Co/sEhW75TB1LFw5ldzUuYB9Ch3yGAQiKdrP/29BOHWirYtAUqCmSxTaT6L6hQoizZhc=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vxQIX-0001ZC-4w; Tue, 03 Mar 2026 14:00:29 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vxQIW-0001Z1-6p; Tue, 03 Mar 2026 14:00:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oEZ/VbvFt7cbfXL60uAzuqwL1Xkzmb3tbb5L5pK1U5I=; b=EVaPtbzeUui9vCDZrQhtqVWrLK pzTrNs4tBwwj8id7KT7WqRlC29c/YTrI+HH/JcckhK6frzzNtMCzSB0ILh5ija4tOv9H01M9Cf+Q+ 5ePS/fc7XkGAK+LtLS0WkXu29TFnRy3ePPMz/+ftWfWd45ubKJRIiniFRM7w8Wmu8L3Q=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oEZ/VbvFt7cbfXL60uAzuqwL1Xkzmb3tbb5L5pK1U5I=; b=h2zGCX0V3CVE+p/YAqIp65njQa KIo2XHfv7+6vA0r1gKbr0RcF3Sj6MdrV7Si0fZNsfL/9M9cZ23v0aw6If6uvFH7VIjCIn+QI98I7/ VZGBCM0pz6LUI1JjsNH4B6+AgjAyTKppL+5Mh/irITiT5CZ0X45QcstJG5JUP4augEG8=; Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vxQIV-00072C-Nw; Tue, 03 Mar 2026 14:00:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oEZ/VbvFt7cbfXL60uAzuqwL1Xkzmb3tbb5L5pK1U5I=; b=2ANHMPvUqrwVZI/9ItBiSdTN6F l8UfE7UMSvuHVZaJWhK09McBQCC5Aai6wPynwg24bukYeaGzQiK2R02Dq4Op8tWnLUmkN7XZ4ajfM Le9GGPICxIH2eRNnZgTpAzJLkRC2JC1BgOkZOOC4aPxulPKDiAeWNkWlYYiPws1+XvyX4ORTgwCM5 U8CK5pP5X5qGQXNTHXXptzr7rmd2nNzFK6HNJZiuSvla56S2Wqhn5KBNWjoA9mRrXVtgSFTmyfqZY Owt+6ulyfJRIOIinFxUHBEz425U0gcsijCxEc2D7tW+/wVqapcxIPHte6W40vmHC4FO8ERdb3AHRo q5JRoAUg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxQHV-0000000FH1T-2Wa9; Tue, 03 Mar 2026 13:59:25 +0000 Date: Tue, 3 Mar 2026 05:59:25 -0800 From: Christoph Hellwig To: Jeff Layton Message-ID: References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> <20260303012556.GA6520@macsyma-wired.lan> <20260303042546.GF13868@frogsfrogsfrogs> <33228005140684201de2ca0c157441d3b6a06413.camel@kernel.org> <19e4e79a59dcfc4c61c8cf263af345d0d7026fc8.camel@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <19e4e79a59dcfc4c61c8cf263af345d0d7026fc8.camel@kernel.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1vxQIV-00072C-Nw Subject: Re: [f2fs-dev] [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Latchesar Ionkov , nvdimm@lists.linux.dev, Paulo Alcantara , "Darrick J. Wong" , Anders Larsen , dri-devel@lists.freedesktop.org, linux-sctp@vger.kernel.org, linux-hams@vger.kernel.org, Sumit Semwal , Mike Marshall , linux-xfs@vger.kernel.org, Fan Wu , Xin Long , ceph-devel@vger.kernel.org, James Morris , Tyler Hicks , Christoph Hellwig , devel@lists.orangefs.org, Shyam Prasad N , Martin Schiller , Jesper Dangaard Brouer , Jan Harkes , Willem de Bruijn , Arnaldo Carvalho de Melo , linux-fscrypt@vger.kernel.org, Alexander Viro , Ronnie Sahlberg , John Paul Adrian Glaubitz , David Hildenbrand , Eric Van Hensbergen , Magnus Karlsson , Christian Brauner , Dmitry Kasatkin , Stephen Smalley , linux-kernel@vger.kernel.org, Eric Paris , linux-perf-users@vger.kernel.org, Chuck Lever , Masami Hiramatsu , Jiri Olsa , Jan Kara , Alex Deucher , linux-media@vger.kernel.org, Trond Myklebust , Mark Rutland , Dave Kleikamp , Mimi Zohar , Oleg Nesterov , Eric Dumazet , Johan Hedberg , Simona Vetter , linux-cifs@vger.kernel.org, Kuniyuki Iwashima , linux-nilfs@vger.kernel.org, Paul Moore , John Fastabend , Remi Denis-Courmont , linux-trace-kernel@vger.kernel.org, Olga Kornievskaia , Maciej Fijalkowski , Yangtao Li , selinux@vger.kernel.org, v9fs@lists.linux.dev, linux-can@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Casey Schaufler , netfs@lists.linux.dev, Jaegeuk Kim , fsverity@lists.linux.dev, Theodore Tso , Nicolas Pitre , Muchun Song , Roberto Sassu , "David S. Miller" , Anna Schumaker , linux-integrity@vger.kernel.org, Marcelo Ricardo Leitner , Luiz Augusto von Dentz , Alex Markuze , Martin Brandenburg , Alexander Shishkin , ocfs2-devel@lists.linux.dev, Alexei Starovoitov , linux-mtd@lists.infradead.org, amd-gfx@lists.freedesktop.org, Marc Dionne , Neal Cardwell , linux-afs@lists.infradead.org, Ian Kent , Naohiro Aota , Eric Biggers , Daniel Borkmann , Miklos Szeredi , Matthew Wilcox , coda@cs.cmu.edu, Stanislav Fomichev , Viacheslav Dubeyko , NeilBrown , Ilya Dryomov , Paolo Abeni , jfs-discussion@lists.sourceforge.net, "Serge E. Hallyn" , Amir Goldstein , James Clark , autofs@vger.kernel.org, Steven Rostedt , Damien Le Moal , Mathieu Desnoyers , Dan Williams , Oscar Salvador , Konstantin Komarov , linux-nfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, samba-technical@lists.samba.org, Ondrej Mosnacek , Steve French , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, bpf@vger.kernel.org, ntfs3@lists.linux.dev, Christian =?iso-8859-1?Q?K=F6nig?= , Ian Rogers , Alexander Aring , Jan Kara , Peter Zijlstra , Dominique Martinet , Christian Schoenebeck , ecryptfs@vger.kernel.org, linux-unionfs@vger.kernel.org, David Howells , Joseph Qi , Andreas Dilger , Mikulas Patocka , linux-f2fs-devel@lists.sourceforge.net, David Airlie , Steffen Klassert , Eric Snowberg , Herbert Xu , linux-x25@vger.kernel.org, linux-bluetooth@vger.kernel.org, Richard Weinberger , Mark Fasheh , Dai Ngo , Ingo Molnar , Jakub Kicinski , Salah Triki , Marcel Holtmann , Joerg Reuter , codalist@telemann.coda.cs.cmu.edu, Simon Horman , apparmor@lists.ubuntu.com, Tom Talpey , Bharath SM , Marc Kleine-Budde , "Tigran A. Aivazian" , David Sterba , Namhyung Kim , Ryusuke Konishi , John Johansen , Luis de Bethencourt , Oliver Hartkopp , David Ahern , Adrian Hunter , audit@vger.kernel.org, linux-security-module@vger.kernel.org, Johannes Thumshirn , David Woodhouse , Joel Becker Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Mar 03, 2026 at 08:43:15AM -0500, Jeff Layton wrote: > On Tue, 2026-03-03 at 05:37 -0800, Christoph Hellwig wrote: > > On Tue, Mar 03, 2026 at 05:53:39AM -0500, Jeff Layton wrote: > > > Like I said to Ted, this is just temporary scaffolding for the change. > > > The PRIino macro is removed in the end. Given that, perhaps you can > > > overlook the bikeshed's color in this instance? > > > > So why add it in the first place? > > Bisectability. The first version I did of this would have broken the > ability to bisect properly across these changes. I don't love the > "churn" here either, but this should be cleanly bisectable. What do you need to bisect in format string changes? Splitting every variable type change outside of the main i_ino out - sure. But bisecting that "change to u64 in ext4" really broke ext4 and not "change to u64" is not very useful. Commits should do one well defined thing. Adding a weird transition layer for a format thing that just gets dropped is not one well defined thing. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17616EC1451 for ; Tue, 3 Mar 2026 13:59:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ypA2OUIxS0Fdgx/jl0yjZ63LWnMlIWKK++IhzZF+d1E=; b=izblqfLJY7U1/P jfIXQgG9MU6BE96aqUv0+HeReRXyzvEastiABJRtq1XosT3VGChFK6BvINBzcCSWDlJA1yDoOtg4i V2FbCGAbpXdXeSnFnC5zo2N5VzpxUhnmTWGiVR4LeLx5BfnpROoCn6wrOVGv0hMS4VSjB6P45ZTIV J49xqkXAxOEiKh69kBxSZR7RaDdmtzAhn7dtrMJl9l1IURC4yO1hDEP33cnkLnJKh2B8X4tIgVhsV VmQH6tLezKe2In02dGndByzBdnelTnf2AThEPwe1hfqk6Pyz2KyA3vRoxzcYo2kCHxPIDN/NqR0T0 oqHyQ/w8Sdf10PLhgjvw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxQHb-0000000FH28-1oDa; Tue, 03 Mar 2026 13:59:31 +0000 Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vxQHV-0000000FH1T-2Wa9; Tue, 03 Mar 2026 13:59:25 +0000 Date: Tue, 3 Mar 2026 05:59:25 -0800 From: Christoph Hellwig To: Jeff Layton Cc: Christoph Hellwig , "Darrick J. Wong" , Theodore Tso , Alexander Viro , Christian Brauner , Jan Kara , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Dan Williams , Matthew Wilcox , Eric Biggers , Muchun Song , Oscar Salvador , David Hildenbrand , David Howells , Paulo Alcantara , Andreas Dilger , Jan Kara , Jaegeuk Kim , Chao Yu , Trond Myklebust , Anna Schumaker , Chuck Lever , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Steve French , Ronnie Sahlberg , Shyam Prasad N , Bharath SM , Alexander Aring , Ryusuke Konishi , Viacheslav Dubeyko , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Ilya Dryomov , Alex Markuze , Jan Harkes , coda@cs.cmu.edu, Nicolas Pitre , Tyler Hicks , Amir Goldstein , John Paul Adrian Glaubitz , Yangtao Li , Mikulas Patocka , David Woodhouse , Richard Weinberger , Dave Kleikamp , Konstantin Komarov , Mark Fasheh , Joel Becker , Joseph Qi , Mike Marshall , Martin Brandenburg , Miklos Szeredi , Anders Larsen , Zhihao Cheng , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Fan Wu , Stephen Smalley , Ondrej Mosnacek , Casey Schaufler , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Sumit Semwal , Eric Dumazet , Kuniyuki Iwashima , Paolo Abeni , Willem de Bruijn , "David S. Miller" , Jakub Kicinski , Simon Horman , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Martin Schiller , Eric Paris , Joerg Reuter , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Oliver Hartkopp , Marc Kleine-Budde , David Ahern , Neal Cardwell , Steffen Klassert , Herbert Xu , Remi Denis-Courmont , Marcelo Ricardo Leitner , Xin Long , Magnus Karlsson , Maciej Fijalkowski , Stanislav Fomichev , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, nvdimm@lists.linux.dev, fsverity@lists.linux.dev, linux-mm@kvack.org, netfs@lists.linux.dev, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-nilfs@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@telemann.coda.cs.cmu.edu, ecryptfs@vger.kernel.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, netdev@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-xfs@vger.kernel.org, linux-hams@vger.kernel.org, linux-x25@vger.kernel.org, audit@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-can@vger.kernel.org, linux-sctp@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 001/110] vfs: introduce kino_t typedef and PRIino format macro Message-ID: References: <20260302-iino-u64-v2-0-e5388800dae0@kernel.org> <20260302-iino-u64-v2-1-e5388800dae0@kernel.org> <20260303012556.GA6520@macsyma-wired.lan> <20260303042546.GF13868@frogsfrogsfrogs> <33228005140684201de2ca0c157441d3b6a06413.camel@kernel.org> <19e4e79a59dcfc4c61c8cf263af345d0d7026fc8.camel@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <19e4e79a59dcfc4c61c8cf263af345d0d7026fc8.camel@kernel.org> X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, Mar 03, 2026 at 08:43:15AM -0500, Jeff Layton wrote: > On Tue, 2026-03-03 at 05:37 -0800, Christoph Hellwig wrote: > > On Tue, Mar 03, 2026 at 05:53:39AM -0500, Jeff Layton wrote: > > > Like I said to Ted, this is just temporary scaffolding for the change. > > > The PRIino macro is removed in the end. Given that, perhaps you can > > > overlook the bikeshed's color in this instance? > > > > So why add it in the first place? > > Bisectability. The first version I did of this would have broken the > ability to bisect properly across these changes. I don't love the > "churn" here either, but this should be cleanly bisectable. What do you need to bisect in format string changes? Splitting every variable type change outside of the main i_ino out - sure. But bisecting that "change to u64 in ext4" really broke ext4 and not "change to u64" is not very useful. Commits should do one well defined thing. Adding a weird transition layer for a format thing that just gets dropped is not one well defined thing. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/