From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E235DC433F5 for ; Wed, 8 Dec 2021 13:03:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233975AbhLHNHU convert rfc822-to-8bit (ORCPT ); Wed, 8 Dec 2021 08:07:20 -0500 Received: from mail4.swissbit.com ([176.95.1.100]:39764 "EHLO mail4.swissbit.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232257AbhLHNHU (ORCPT ); Wed, 8 Dec 2021 08:07:20 -0500 Received: from mail4.swissbit.com (localhost [127.0.0.1]) by DDEI (Postfix) with ESMTP id 65F3C122D74; Wed, 8 Dec 2021 14:03:47 +0100 (CET) Received: from mail4.swissbit.com (localhost [127.0.0.1]) by DDEI (Postfix) with ESMTP id 52B431212FB; Wed, 8 Dec 2021 14:03:47 +0100 (CET) X-TM-AS-ERS: 10.149.2.84-127.5.254.253 X-TM-AS-SMTP: 1.0 ZXguc3dpc3NiaXQuY29t Y2xvZWhsZUBoeXBlcnN0b25lLmNvbQ== X-DDEI-TLS-USAGE: Used Received: from ex.swissbit.com (SBDEEX02.sbitdom.lan [10.149.2.84]) by mail4.swissbit.com (Postfix) with ESMTPS; Wed, 8 Dec 2021 14:03:47 +0100 (CET) Received: from sbdeex02.sbitdom.lan (10.149.2.84) by sbdeex02.sbitdom.lan (10.149.2.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.14; Wed, 8 Dec 2021 14:03:46 +0100 Received: from sbdeex02.sbitdom.lan ([fe80::e0eb:ade8:2d90:1f74]) by sbdeex02.sbitdom.lan ([fe80::e0eb:ade8:2d90:1f74%8]) with mapi id 15.02.0986.014; Wed, 8 Dec 2021 14:03:46 +0100 From: =?iso-8859-1?Q?Christian_L=F6hle?= To: "linux-kernel@vger.kernel.org" , "linux-mmc@vger.kernel.org" , Ulf Hansson , =?iso-8859-1?Q?Christian_L=F6hle?= CC: "johan@kernel.org" , "sudeep.holla@arm.com" , "linux@dominikbrodowski.net" Subject: Re: [PATCH] mmc: bus: Log bus width info when attaching card Thread-Topic: [PATCH] mmc: bus: Log bus width info when attaching card Thread-Index: AQHX7DLvbfJedhQ2P06N1hRDzW4jFKwoj1Ci Date: Wed, 8 Dec 2021 13:03:46 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, de-DE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.154.1.4] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-TMASE-Version: DDEI-5.1-8.6.1018-26576.007 X-TMASE-Result: 10--0.005000-10.000000 X-TMASE-MatchedRID: LVkZzMT5mErUL3YCMmnG4glbhYSnc4eqAgvM6h73BtqZLRO16GOkkipW pWaEQSv6yRqCtVa3YnUGNK8lZNdEETQdOVb9/jgP9u1rQ4BgXPIBDya2JbH/+rTxVectWz+o2Uw BLM8az1RD6DWt+2Yy8Lh3m/0ECTO27yClTVv2c3aqFx2c/3V5cTmVJJLME0WY5PvoRjNp0nvP6y uf4c2Uy0EPIKaT97viLyVaVKT0PhEsaaYlMvaOHAPZZctd3P4BKQNhMboqZloRxZBQI0dbZ83qh pIE26kvgSLH1kq78w6ui0EVZK4raGgwIvLATTKBC24oEZ6SpSkj80Za3RRg8HgKtONKpYWx+RYv e4FJSen6Wcr/wwk63Kbvtk6/mg2Z1810qjhCn6c= X-TMASE-SNAP-Result: 1.821001.0001-0-1-22:0,33:0,34:0-0 X-TMASE-INERTIA: 0-0;;;; X-TMASE-XGENCLOUD: a9228e58-01b9-4e3d-8002-b488d583455d-0-0-200-0 Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Might seem unecessary to print the bus width and a bit confusing, but it is the only 'bus info' that is not printed in that line. So I suggest adding it. Regards, Christian From: Christian Löhle Sent: Wednesday, December 8, 2021 2:02 PM To: linux-kernel@vger.kernel.org; linux-mmc@vger.kernel.org; Ulf Hansson; Christian Löhle Cc: johan@kernel.org; sudeep.holla@arm.com; linux@dominikbrodowski.net Subject: [PATCH] mmc: bus: Log bus width info when attaching card   Add info about bus width of the attached card to the bring-up message For both MMC and SD cards the bus width that is used might not be obvious to a user. For MMC this might be 1, 4 or 8, for SD only 1 and 4. In both cases this would be a restriction by the host (setup). Like using an MMC in an SD slot or an eMMC to SD adapter. Signed-off-by: Christian Loehle ---  drivers/mmc/core/bus.c | 5 +++--  1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c index f6b7a9c5bbff..71a675dcd9b7 100644 --- a/drivers/mmc/core/bus.c +++ b/drivers/mmc/core/bus.c @@ -358,7 +358,7 @@ int mmc_add_card(struct mmc_card *card)                          mmc_card_ddr52(card) ? "DDR " : "",                          type);          } else { -               pr_info("%s: new %s%s%s%s%s%s card at address %04x\n", +               pr_info("%s: new %s%s%s%s%s%s %u-bit card at address %04x\n",                          mmc_hostname(card->host),                          mmc_card_uhs(card) ? "ultra high speed " :                          (mmc_card_hs(card) ? "high speed " : ""), @@ -366,7 +366,8 @@ int mmc_add_card(struct mmc_card *card)                          (mmc_card_hs200(card) ? "HS200 " : ""),                          mmc_card_hs400es(card) ? "Enhanced strobe " : "",                          mmc_card_ddr52(card) ? "DDR " : "", -                       uhs_bus_speed_mode, type, card->rca); +                       uhs_bus_speed_mode, type, +                       1<host->ios.bus_width, card->rca);          }    #ifdef CONFIG_DEBUG_FS -- 2.34.1 = Hyperstone GmbH | Reichenaustr. 39a | 78467 Konstanz Managing Director: Dr. Jan Peter Berns. Commercial register of local courts: Freiburg HRB381782