All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Michał Grzelak" <michal.grzelak@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/overlay: Fix oops on unload
Date: Tue, 3 Mar 2026 19:17:51 +0200	[thread overview]
Message-ID: <aacXv1odTUPZpQZW@intel.com> (raw)
In-Reply-To: <67e4ef68-268c-57ad-1abd-5c07cefd6270@intel.com>

On Tue, Mar 03, 2026 at 11:25:55AM +0100, Michał Grzelak wrote:
> On Tue, 3 Mar 2026, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Apparently I failed to test the unload case properly and
> > thus didn't notice that the i915_overlay_is_active() needs
> > i915->overlay after fetch_and_zero() already cleared it.
> > Stop using fetch_and_zero() and only clear the pointer at
> > the end to avoid the oops.
> >
> > Fixes: 38d9a352c45e ("drm/i915/overlay: Extract i915_overlay_is_active()")
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Reviewed-by: Michał Grzelak <michal.grzelak@intel.com>

Thanks. Pushed.

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2026-03-03 17:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 10:14 [PATCH] drm/i915/overlay: Fix oops on unload Ville Syrjala
2026-03-03 10:25 ` Michał Grzelak
2026-03-03 17:17   ` Ville Syrjälä [this message]
2026-03-03 11:01 ` ✓ CI.KUnit: success for " Patchwork
2026-03-03 11:51 ` ✓ Xe.CI.BAT: " Patchwork
2026-03-03 12:08 ` ✓ i915.CI.BAT: " Patchwork
2026-03-03 20:14 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aacXv1odTUPZpQZW@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=michal.grzelak@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.