From: Jens Axboe <axboe@kernel.dk>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-block@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/2] mm: move filemap_range_needs_writeback() into header
Date: Fri, 3 Dec 2021 12:09:38 -0700 [thread overview]
Message-ID: <aaccdffc-876d-ab24-787c-09725ca3d929@kernel.dk> (raw)
In-Reply-To: <Yapeosr1ByRBEdgT@casper.infradead.org>
On 12/3/21 11:14 AM, Matthew Wilcox wrote:
> On Fri, Dec 03, 2021 at 11:01:14AM -0700, Jens Axboe wrote:
>> On 12/3/21 10:57 AM, Jens Axboe wrote:
>>>> I'm happy with this, if you just move it to pagemap.h
>>>
>>> OK, I'll try it out.
>>
>> Wasn't too bad at all, actually just highlighted that I missed removing
>> the previous declaration of filemap_range_needs_writeback() in fs.h
>> I'll do a full compile and test, but this seems sane.
>>
>> commit 63c6b3846b77041d239d5b5b5a907b5c82a21c4c
>> Author: Jens Axboe <axboe@kernel.dk>
>> Date: Thu Oct 28 08:47:05 2021 -0600
>>
>> mm: move filemap_range_needs_writeback() into header
>>
>> No functional changes in this patch, just in preparation for efficiently
>> calling this light function from the block O_DIRECT handling.
>>
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Great, thanks for the review Willy!
--
Jens Axboe
next prev parent reply other threads:[~2021-12-03 19:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-03 15:38 [PATCHSET 0/2] Avoid unnecessary indirect calls for bdev dio Jens Axboe
2021-12-03 15:38 ` [PATCH 1/2] mm: move filemap_range_needs_writeback() into header Jens Axboe
2021-12-03 16:16 ` Matthew Wilcox
2021-12-03 16:24 ` Jens Axboe
2021-12-03 16:31 ` Jens Axboe
2021-12-03 16:35 ` Jens Axboe
2021-12-03 16:38 ` Jens Axboe
2021-12-03 17:46 ` Matthew Wilcox
2021-12-03 17:57 ` Jens Axboe
2021-12-03 18:01 ` Jens Axboe
2021-12-03 18:14 ` Matthew Wilcox
2021-12-03 19:09 ` Jens Axboe [this message]
2021-12-03 15:38 ` [PATCH 2/2] block: move direct_IO into our own read_iter handler Jens Axboe
2021-12-06 6:58 ` Christoph Hellwig
2021-12-06 16:33 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaccdffc-876d-ab24-787c-09725ca3d929@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.