All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh@kernel.org>,
	Daniel Scally <djrscally@gmail.com>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Danilo Krummrich <dakr@kernel.org>,
	Claudiu Manoil <claudiu.manoil@nxp.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH RFC net-next v5 10/10] net: gianfar: Use device_get_child_node_count_named()
Date: Mon, 3 Mar 2025 14:13:30 +0200	[thread overview]
Message-ID: <aacffceb-e9e8-412a-a624-568e6b10d586@gmail.com> (raw)
In-Reply-To: <Z8WXqgxgFQC8b8vC@smile.fi.intel.com>

On 03/03/2025 13:51, Andy Shevchenko wrote:
> On Mon, Mar 03, 2025 at 01:34:49PM +0200, Matti Vaittinen wrote:

> 
> What about the second loop (in gfar_of_init)?
> I mean perhaps we want to have fwnode_for_each_named_child_node()
> and its device variant that may be also reused in the IIO code and here.
> 

I agree the fwnode_for_each_named_child_node() would be useful. I think 
I said that already during the previous review rounds. There is plenty 
of code which could be converted to use it.

This, however, is far more than I am willing to do in the context of a 
simple IIO driver addition. The "BD79124 ADC suupport" is already now 10 
patches, 2 of which are directly related to it.

I propose adding the for_each_named_child_node() as a separate series 
with bunch of users appended. That's be plenty of beans to count for 
those who like following the statistics :)

Yours,
	-- Matti

  reply	other threads:[~2025-03-03 12:13 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03 11:30 [PATCH v5 00/10] Support ROHM BD79124 ADC Matti Vaittinen
2025-03-03 11:31 ` [PATCH v5 01/10] dt-bindings: ROHM BD79124 ADC/GPO Matti Vaittinen
2025-03-03 11:31 ` [PATCH v5 02/10] property: Add functions to count named child nodes Matti Vaittinen
2025-03-03 11:50   ` Heikki Krogerus
2025-03-03 12:00     ` Andy Shevchenko
2025-03-03 11:59   ` Andy Shevchenko
2025-03-10  6:23     ` Matti Vaittinen
2025-03-10  8:23       ` Andy Shevchenko
2025-03-03 11:32 ` [PATCH v5 03/10] iio: adc: add helpers for parsing ADC nodes Matti Vaittinen
2025-03-04  9:25   ` David Lechner
2025-03-04 12:07     ` Andy Shevchenko
2025-03-05 10:54     ` Matti Vaittinen
2025-03-08 16:29       ` Jonathan Cameron
2025-03-10  7:41         ` Matti Vaittinen
2025-03-10 19:25           ` Jonathan Cameron
2025-03-03 11:32 ` [PATCH v5 04/10] iio: adc: rzg2l_adc: Use adc-helpers Matti Vaittinen
2025-03-08 16:33   ` Jonathan Cameron
2025-03-03 11:33 ` [PATCH v5 05/10] iio: adc: sun20i-gpadc: " Matti Vaittinen
2025-03-08 16:35   ` Jonathan Cameron
2025-03-03 11:33 ` [PATCH v5 06/10] iio: adc: ti-ads7924 Drop unnecessary function parameters Matti Vaittinen
2025-03-08 16:36   ` Jonathan Cameron
2025-03-03 11:33 ` [PATCH v5 07/10] iio: adc: Support ROHM BD79124 ADC Matti Vaittinen
2025-03-08 16:44   ` Jonathan Cameron
2025-03-10  8:46     ` Matti Vaittinen
2025-03-10 19:26       ` Jonathan Cameron
2025-03-03 11:34 ` [PATCH v5 08/10] MAINTAINERS: Add IIO ADC helpers Matti Vaittinen
2025-03-03 11:34 ` [PATCH v5 09/10] MAINTAINERS: Add ROHM BD79124 ADC/GPO Matti Vaittinen
2025-03-03 11:34 ` [PATCH RFC net-next v5 10/10] net: gianfar: Use device_get_child_node_count_named() Matti Vaittinen
2025-03-03 11:51   ` Andy Shevchenko
2025-03-03 12:13     ` Matti Vaittinen [this message]
2025-03-03 12:24       ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aacffceb-e9e8-412a-a624-568e6b10d586@gmail.com \
    --to=mazziesaccount@gmail.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=claudiu.manoil@nxp.com \
    --cc=dakr@kernel.org \
    --cc=davem@davemloft.net \
    --cc=djrscally@gmail.com \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=kuba@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.