From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2AEDEF34C5E for ; Mon, 13 Apr 2026 15:25:34 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wCJ8t-0005fu-6Q; Mon, 13 Apr 2026 11:24:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCJ8U-0005Tp-6E; Mon, 13 Apr 2026 11:23:39 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wCJ8Q-0000RS-Gr; Mon, 13 Apr 2026 11:23:37 -0400 Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63DElSQ93250375; Mon, 13 Apr 2026 15:23:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=sbQkLv Q8n8AOekiigmrceRIJmk74sUCteDBJw8HUasM=; b=UfmGr6UYgeZoGLTYa5p5X/ 5JbQZty6Mpf6j4VL7oVkPlsNs5JjDLA+ipEimIvNO/5kvuq6AsQ3jBndY14LjrwG wRB2WxgGAYlSpONUndg/jqG6G2JA7kkMLFB68CzsZxzlnqRl8DrqnpWBeY+xAiPy zFQNvVUvzDyCFjOK5gqkSv3hef0ptcj/pTNeu+4mk1NCx0mShjplNYW3L04aTX/6 SNnE/z9GESjNAwxbeucl16q1qCB29H4mA87wOKjX5UvU/2d6ZFSj4fknnGrhoPrp vddH5nf0p6J6roxJ8PYgeduY0duU9EKmKfsV0oIgqyDpYjZSrIr7PF7+Iv350xmw == Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dfdxwyxbh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Apr 2026 15:23:31 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 63DEQZmL025643; Mon, 13 Apr 2026 15:23:30 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dg2ujdhex-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 13 Apr 2026 15:23:30 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 63DFNSrd32113320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 13 Apr 2026 15:23:28 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7FCF858061; Mon, 13 Apr 2026 15:23:28 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BC13E5803F; Mon, 13 Apr 2026 15:23:27 +0000 (GMT) Received: from [9.61.12.51] (unknown [9.61.12.51]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 13 Apr 2026 15:23:27 +0000 (GMT) Message-ID: Date: Mon, 13 Apr 2026 11:23:27 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] hw/vfio/ap: Callbacks for migration of guests with pass-through access to AP devices To: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= , qemu-devel@nongnu.org Cc: qemu-s390x@nongnu.org, mjrosato@linux.ibm.com, jjherne@linux.ibm.com, pasic@linux.ibm.com, farman@linux.ibm.com, borntraeger@linux.ibm.com, alex@shazbot.org, cohuck@redhat.com References: <20260409141352.997844-1-akrowiak@linux.ibm.com> <20260409141352.997844-3-akrowiak@linux.ibm.com> Content-Language: en-US From: Anthony Krowiak In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEzMDE1MCBTYWx0ZWRfX859zhbUSApMA bGWz5q1AY6jsrCndDYeoDGevqw4jle4RrLajdzdhjzvFMDZhhumTmZl6TjP5L69Lx/C4LJDxSKn psEzbakiu472c8/VL8ugIw8CURBEiuvNBNKxWXCH7ZGreToHiUI3p8qVpiby621lfhsROjBvx4s MSvbPiXN8wSsIK7po+T9f9H+qv1VecSdkr+VjKQ8XPg7+aviQSPYkzLcM7LjeAW7EFKg9AgldKr mtuRPUznHjgbkmcCS6iY2i2d0Drq7GLPLsn/anSBBgCISuVVZJNxvzqkFh5y3bFmJmsKkrl4USz VTboJJNJZmrImx4Xf8woJK3LGIcI/EFM47t4tyX2aXEBCONpUMBxkDbW16QHYwy0J7cBpVgOWwC BoEyvksWTDL78zCptv8GbMMir45sNdnQpmCG3S5KWIJrByKQCHvG1Fh7/izbkJ9Mrowl6vucFCH YRdVdmvDv3nbqfvineA== X-Proofpoint-ORIG-GUID: -wpZ3ZjxJy6mROSnbX6Jw9oGo1rj-QiW X-Authority-Analysis: v=2.4 cv=TId1jVla c=1 sm=1 tr=0 ts=69dd0a73 cx=c_pps a=AfN7/Ok6k8XGzOShvHwTGQ==:117 a=AfN7/Ok6k8XGzOShvHwTGQ==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VnNF1IyMAAAA:8 a=EJE7A_Tmek1c15OkdScA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: -wpZ3ZjxJy6mROSnbX6Jw9oGo1rj-QiW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-13_03,2026-04-13_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0 phishscore=0 suspectscore=0 priorityscore=1501 impostorscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604130150 Received-SPF: pass client-ip=148.163.158.5; envelope-from=akrowiak@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 4/10/26 4:19 AM, Cédric Le Goater wrote: > On 4/9/26 16:13, Anthony Krowiak wrote: >> From: Anthony  Krowiak >> >> Implements the callbacks used by the VFIO migration framework to migrate >> guests with pass-through access to s390 crypto devices. >> >> Signed-off-by: Anthony Krowiak >> --- >>   hw/vfio/ap.c | 43 +++++++++++++++++++++++++++++++++++++++---- >>   1 file changed, 39 insertions(+), 4 deletions(-) >> >> diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c >> index fd68983702..49947b18c3 100644 >> --- a/hw/vfio/ap.c >> +++ b/hw/vfio/ap.c >> @@ -32,6 +32,7 @@ >>   #include "hw/s390x/ap-bridge.h" >>   #include "system/address-spaces.h" >>   #include "qom/object.h" >> +#include "vfio-migration-internal.h" >>     #define TYPE_VFIO_AP_DEVICE      "vfio-ap" >>   @@ -47,6 +48,7 @@ static const VMStateDescription vmstate_ap_device >> = { >>       .name = "vfio-ap-device", >>       .version_id = 1, >>       .minimum_version_id = 1, >> +    .unmigratable = 0, > > unneeded. > >>       .fields = (const VMStateField[]) { >>           VMSTATE_END_OF_LIST() >>       }, >> @@ -66,17 +68,44 @@ static void __attribute__((constructor)) >> vfio_ap_global_init(void) >>       qemu_mutex_init(&cfg_chg_events_lock); >>   } >>   +static int vfio_ap_save_config(VFIODevice *vdev, QEMUFile *f, >> Error **errp) >> +{ >> +    VFIOAPDevice *vapdev = container_of(vdev, VFIOAPDevice, vdev); >> + >> +    return vmstate_save_state(f, &vmstate_ap_device, vapdev, NULL, >> errp); >> +} >> + >> +static int vfio_ap_load_config(VFIODevice *vdev, QEMUFile *f) >> +{ >> +    VFIOAPDevice *vapdev = container_of(vdev, VFIOAPDevice, vdev); >> +    Error *err = NULL; >> +    int ret; >> + >> +    ret = vmstate_load_state(f, &vmstate_ap_device, vapdev, 1, &err); >> +    if (ret) { >> +        error_report_err(err); >> +    } >> + >> +    return ret; >> +} >> + >> +static Object *vfio_ap_get_object(VFIODevice *vbasedev) >> +{ >> +    VFIOAPDevice *vdev = container_of(vbasedev, VFIOAPDevice, vdev); >> + >> +    return OBJECT(vdev); >> +} >> + >>   static void vfio_ap_compute_needs_reset(VFIODevice *vdev) >>   { >>       vdev->needs_reset = false; >>   } >>   -/* >> - * We don't need vfio_hot_reset_multi and vfio_eoi operations for >> - * vfio-ap device now. >> - */ >>   struct VFIODeviceOps vfio_ap_ops = { >>       .vfio_compute_needs_reset = vfio_ap_compute_needs_reset, >> +    .vfio_save_config = vfio_ap_save_config, >> +    .vfio_load_config = vfio_ap_load_config, >> +    .vfio_get_object = vfio_ap_get_object, >>   }; >>     static void vfio_ap_req_notifier_handler(void *opaque) >> @@ -251,6 +280,10 @@ static void vfio_ap_realize(DeviceState *dev, >> Error **errp) >>           goto error; >>       } >>   +    if (!vfio_migration_realize(vbasedev, errp)) { >> +        goto error; >> +    } >> + >>       if (!vfio_ap_register_irq_notifier(vapdev, >> VFIO_AP_REQ_IRQ_INDEX, &err)) { >>           /* >>            * Report this error, but do not make it a failing condition. >> @@ -287,6 +320,8 @@ static void vfio_ap_unrealize(DeviceState *dev) >>     static const Property vfio_ap_properties[] = { >>       DEFINE_PROP_STRING("sysfsdev", VFIOAPDevice, vdev.sysfsdev), >> +    DEFINE_PROP_ON_OFF_AUTO("enable-migration", VFIOAPDevice, >> +                            vdev.enable_migration, ON_OFF_AUTO_ON), > > Why not ON_OFF_AUTO_AUTO ? This would enable migration only if kernel > has migration support. If not, the VM would still start but migration > would be blocked. I made this change and migration failed on the destination host with the following error message: error: Requested operation is not valid: cannot migrate domain: 62177883-f1bb-47f0-914d-32a22e3a8804: VFIO device doesn't support device and IOMMU dirty tracking This despite having the following property defined: DEFINE_PROP_ON_OFF_AUTO("x-device-dirty-page-tracking", VFIOAPDevice, vdev.device_dirty_page_tracking, ON_OFF_AUTO_ON) > > thanks, > > C. > > >>   #ifdef CONFIG_IOMMUFD >>       DEFINE_PROP_LINK("iommufd", VFIOAPDevice, vdev.iommufd, >>                        TYPE_IOMMUFD_BACKEND, IOMMUFDBackend *), >