From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 508D0C001DC for ; Thu, 27 Jul 2023 05:43:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229822AbjG0Fn4 (ORCPT ); Thu, 27 Jul 2023 01:43:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232680AbjG0FnQ (ORCPT ); Thu, 27 Jul 2023 01:43:16 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8501E4228 for ; Wed, 26 Jul 2023 22:41:55 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-686ed1d2594so581956b3a.2 for ; Wed, 26 Jul 2023 22:41:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1690436458; x=1691041258; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yTNp0sYgD5zMdnjd5nivhzfUxDOUpHBvlbZBBUuBSK8=; b=Do6o4dH6SqtgInZupQNgE3LGRebmjvQq9ntW2BM+eF/Fn4qI7L4SSBZz4SecjUCEFm 3F+5gqWeNjsBAAJ+atklVaHFRcTGG9V4GZOr8MJ9jAcpIMdvTVC2bRvYnqXz4vuEErHj 17Fw3zufiIbDMR63WQ2uJub4pY2s31+l7Z8nAvGAVcKoesI7gT5MFJw5GZjFUtV2U+S1 hMlTBuPftFbUIlUkSwirMEFA3kTW6tIGz6YxdqyGSe80a9CvKLlYq+xRDjDvU9m8yk2h 2/ekTdctVvPa5HP2Suf51o50NcC+0bqD7DDvVp9jWz8MO3a4EtqA1g2E/wayY7zKJMjW 9Atw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690436458; x=1691041258; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yTNp0sYgD5zMdnjd5nivhzfUxDOUpHBvlbZBBUuBSK8=; b=DouP1g9RJ/7buTspz+QP7GqXT3NidDnW6vRecMILC3neFiABP9nAmpH2611Xqp/2z/ pMjsdvO/9+fDs3p54oDynX0XbWyMfUifMr3ZQwQmxmp0fjSy0DkhsoXSHmdUVGQsOBmG ILbyZudgXI0Sk2Ve15jhrkY+hfISIBMaiEe9FJ1gHgrPElIh8iI2w4Y34ksySFVGu7UJ NusXY7YZPyiZpUZx3Fw7NjbTzbjOuC51d05EB5eqsSI0DLmPJJJafrexNkSpw+lmFy1W xH6+3npFvx5PhVfPTqtqaG3tly+QeLnNIhR5ZJCFFX26JfHlVcwFhXQ7PmzsCdeirehA /AKw== X-Gm-Message-State: ABy/qLZ0/KOZ6xLN5tTJ+aCpk/3aa/Ax4suqR6d9NXfD7xatPPEz56HK 0StLCRWACKc/jzwdddAULQ+obw== X-Google-Smtp-Source: APBJJlEgwKoaKppLi57A68jn58J5UBv4vce3uoS3HBVYjj8iEbftSlHAHvZKgDA4UyD8gQuxYPMfHg== X-Received: by 2002:a05:6a00:2d8e:b0:682:616a:f910 with SMTP id fb14-20020a056a002d8e00b00682616af910mr5155408pfb.20.1690436458474; Wed, 26 Jul 2023 22:40:58 -0700 (PDT) Received: from [10.0.2.15] ([82.78.167.79]) by smtp.gmail.com with ESMTPSA id 17-20020aa79111000000b00682a16f0b00sm538227pfh.210.2023.07.26.22.40.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 22:40:58 -0700 (PDT) Message-ID: Date: Thu, 27 Jul 2023 08:40:46 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 12/61] mmc: sdhci-of-at91: Convert to platform remove callback returning void Content-Language: en-US To: Yangtao Li , Adrian Hunter , Eugen Hristev , Ulf Hansson , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230726040041.26267-1-frank.li@vivo.com> <20230726040041.26267-12-frank.li@vivo.com> From: claudiu beznea In-Reply-To: <20230726040041.26267-12-frank.li@vivo.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 26.07.2023 06:59, Yangtao Li wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Cc: Uwe Kleine-König > Signed-off-by: Yangtao Li Reviewed-by: Claudiu Beznea > --- > drivers/mmc/host/sdhci-of-at91.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c > index cd0134580a90..af5bc0caf29b 100644 > --- a/drivers/mmc/host/sdhci-of-at91.c > +++ b/drivers/mmc/host/sdhci-of-at91.c > @@ -443,7 +443,7 @@ static int sdhci_at91_probe(struct platform_device *pdev) > return ret; > } > > -static int sdhci_at91_remove(struct platform_device *pdev) > +static void sdhci_at91_remove(struct platform_device *pdev) > { > struct sdhci_host *host = platform_get_drvdata(pdev); > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > @@ -461,8 +461,6 @@ static int sdhci_at91_remove(struct platform_device *pdev) > clk_disable_unprepare(gck); > clk_disable_unprepare(hclock); > clk_disable_unprepare(mainck); > - > - return 0; > } > > static struct platform_driver sdhci_at91_driver = { > @@ -473,7 +471,7 @@ static struct platform_driver sdhci_at91_driver = { > .pm = &sdhci_at91_dev_pm_ops, > }, > .probe = sdhci_at91_probe, > - .remove = sdhci_at91_remove, > + .remove_new = sdhci_at91_remove, > }; > > module_platform_driver(sdhci_at91_driver); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B8309C001DC for ; Thu, 27 Jul 2023 05:41:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=izlATXwfOoTTUVV/flpZxLrLfSAYqNIzS/rm0nbsUxg=; b=ThAyyrn4QUvrlE zEsbLCDcx5GneA8lnX6xWhjIBUvnfX5wNpFwJId0t8lkuFPq6dSHCrjhjX+xNLEbzkbaKIdTpjGL8 UAfwpBqitJM59hxxdmFadb317HfcH8cyc7vRiOlxeyP2KGhbjJ6ZzyPQI8ZQMNFLxzWAizWwUWnKB LlIOT0cpNcY+1nFgEtbALzqS+vn9r9F/I9yudLsSe6a0XB8o/SeXYpREcx7U366WS+OX4FSSQbg1M IVeqnjDF13iwPwNnoDWK8Cnb3T/C8Jna0bpaj1fg6zpvyoZKraI3mM2SHqCzckkZS13N9u2/N9OSu Ao91wK/YYb1ySIoFFPGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qOtkG-00CERA-0d; Thu, 27 Jul 2023 05:41:04 +0000 Received: from mail-pf1-x430.google.com ([2607:f8b0:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qOtkD-00CEQU-0A for linux-arm-kernel@lists.infradead.org; Thu, 27 Jul 2023 05:41:02 +0000 Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-686ed1d2594so581955b3a.2 for ; Wed, 26 Jul 2023 22:40:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1690436458; x=1691041258; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=yTNp0sYgD5zMdnjd5nivhzfUxDOUpHBvlbZBBUuBSK8=; b=Do6o4dH6SqtgInZupQNgE3LGRebmjvQq9ntW2BM+eF/Fn4qI7L4SSBZz4SecjUCEFm 3F+5gqWeNjsBAAJ+atklVaHFRcTGG9V4GZOr8MJ9jAcpIMdvTVC2bRvYnqXz4vuEErHj 17Fw3zufiIbDMR63WQ2uJub4pY2s31+l7Z8nAvGAVcKoesI7gT5MFJw5GZjFUtV2U+S1 hMlTBuPftFbUIlUkSwirMEFA3kTW6tIGz6YxdqyGSe80a9CvKLlYq+xRDjDvU9m8yk2h 2/ekTdctVvPa5HP2Suf51o50NcC+0bqD7DDvVp9jWz8MO3a4EtqA1g2E/wayY7zKJMjW 9Atw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690436458; x=1691041258; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yTNp0sYgD5zMdnjd5nivhzfUxDOUpHBvlbZBBUuBSK8=; b=eNku8Hr+DzyPAJOrGmohd5+Mv3K1jSfLCFY9EzwFoiBgmA5F+pNSdJ1S/fZPMXfPrG lZnckHHq3u6EbPCk5AlvD6Y8p5fyzB4QyIB2n0jthOnpPBlYlSFfS8Rt5YI3vscV/hqY +U+kzxEaGDI5YPYVU8HDBvsdcz2BvGfw7ptPQrm8dmA/NwRcy0ibYR4drQPrNUuKQFPj kVjM1aTzGvGlqXXANUuMFq3eqlxwWcXBVnHd/5/f5rM+fFvO1zQGoC54pihvRuey37Ba bngCH7XMyOEmrt14x+s64iNcMnVLwWQUyKEjdGK9Xdpt+eh2ckMGdWhkhqlhrdHjJ64h /mnA== X-Gm-Message-State: ABy/qLawYkoQ26qGJtDeNzcFiy9sm4d6AmwOI47fq+RoyQSO6KaBy3H/ OyH2rOLVDVmtO/Gc3hmGdK3KTf1D0IctDxX6m6Zsfk2p X-Google-Smtp-Source: APBJJlEgwKoaKppLi57A68jn58J5UBv4vce3uoS3HBVYjj8iEbftSlHAHvZKgDA4UyD8gQuxYPMfHg== X-Received: by 2002:a05:6a00:2d8e:b0:682:616a:f910 with SMTP id fb14-20020a056a002d8e00b00682616af910mr5155408pfb.20.1690436458474; Wed, 26 Jul 2023 22:40:58 -0700 (PDT) Received: from [10.0.2.15] ([82.78.167.79]) by smtp.gmail.com with ESMTPSA id 17-20020aa79111000000b00682a16f0b00sm538227pfh.210.2023.07.26.22.40.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 22:40:58 -0700 (PDT) Message-ID: Date: Thu, 27 Jul 2023 08:40:46 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 12/61] mmc: sdhci-of-at91: Convert to platform remove callback returning void Content-Language: en-US To: Yangtao Li , Adrian Hunter , Eugen Hristev , Ulf Hansson , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea Cc: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230726040041.26267-1-frank.li@vivo.com> <20230726040041.26267-12-frank.li@vivo.com> From: claudiu beznea In-Reply-To: <20230726040041.26267-12-frank.li@vivo.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230726_224101_093556_2E736AB6 X-CRM114-Status: GOOD ( 24.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAyNi4wNy4yMDIzIDA2OjU5LCBZYW5ndGFvIExpIHdyb3RlOgo+IFRoZSAucmVtb3ZlKCkg Y2FsbGJhY2sgZm9yIGEgcGxhdGZvcm0gZHJpdmVyIHJldHVybnMgYW4gaW50IHdoaWNoIG1ha2Vz Cj4gbWFueSBkcml2ZXIgYXV0aG9ycyB3cm9uZ2x5IGFzc3VtZSBpdCdzIHBvc3NpYmxlIHRvIGRv IGVycm9yIGhhbmRsaW5nIGJ5Cj4gcmV0dXJuaW5nIGFuIGVycm9yIGNvZGUuIEhvd2V2ZXIgdGhl IHZhbHVlIHJldHVybmVkIGlzIChtb3N0bHkpIGlnbm9yZWQKPiBhbmQgdGhpcyB0eXBpY2FsbHkg cmVzdWx0cyBpbiByZXNvdXJjZSBsZWFrcy4gVG8gaW1wcm92ZSBoZXJlIHRoZXJlIGlzIGEKPiBx dWVzdCB0byBtYWtlIHRoZSByZW1vdmUgY2FsbGJhY2sgcmV0dXJuIHZvaWQuIEluIHRoZSBmaXJz dCBzdGVwIG9mIHRoaXMKPiBxdWVzdCBhbGwgZHJpdmVycyBhcmUgY29udmVydGVkIHRvIC5yZW1v dmVfbmV3KCkgd2hpY2ggYWxyZWFkeSByZXR1cm5zCj4gdm9pZC4KPiAKPiBUcml2aWFsbHkgY29u dmVydCB0aGlzIGRyaXZlciBmcm9tIGFsd2F5cyByZXR1cm5pbmcgemVybyBpbiB0aGUgcmVtb3Zl Cj4gY2FsbGJhY2sgdG8gdGhlIHZvaWQgcmV0dXJuaW5nIHZhcmlhbnQuCj4gCj4gQ2M6IFV3ZSBL bGVpbmUtS8O2bmlnIDx1LmtsZWluZS1rb2VuaWdAcGVuZ3V0cm9uaXguZGU+Cj4gU2lnbmVkLW9m Zi1ieTogWWFuZ3RhbyBMaSA8ZnJhbmsubGlAdml2by5jb20+CgpSZXZpZXdlZC1ieTogQ2xhdWRp dSBCZXpuZWEgPGNsYXVkaXUuYmV6bmVhQHR1eG9uLmRldj4KCj4gLS0tCj4gICBkcml2ZXJzL21t Yy9ob3N0L3NkaGNpLW9mLWF0OTEuYyB8IDYgKystLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMiBp bnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21t Yy9ob3N0L3NkaGNpLW9mLWF0OTEuYyBiL2RyaXZlcnMvbW1jL2hvc3Qvc2RoY2ktb2YtYXQ5MS5j Cj4gaW5kZXggY2QwMTM0NTgwYTkwLi5hZjViYzBjYWYyOWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9tbWMvaG9zdC9zZGhjaS1vZi1hdDkxLmMKPiArKysgYi9kcml2ZXJzL21tYy9ob3N0L3NkaGNp LW9mLWF0OTEuYwo+IEBAIC00NDMsNyArNDQzLDcgQEAgc3RhdGljIGludCBzZGhjaV9hdDkxX3By b2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICAJcmV0dXJuIHJldDsKPiAgIH0K PiAgIAo+IC1zdGF0aWMgaW50IHNkaGNpX2F0OTFfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZp Y2UgKnBkZXYpCj4gK3N0YXRpYyB2b2lkIHNkaGNpX2F0OTFfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9y bV9kZXZpY2UgKnBkZXYpCj4gICB7Cj4gICAJc3RydWN0IHNkaGNpX2hvc3QJKmhvc3QgPSBwbGF0 Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKPiAgIAlzdHJ1Y3Qgc2RoY2lfcGx0Zm1faG9zdAkqcGx0 Zm1faG9zdCA9IHNkaGNpX3ByaXYoaG9zdCk7Cj4gQEAgLTQ2MSw4ICs0NjEsNiBAQCBzdGF0aWMg aW50IHNkaGNpX2F0OTFfcmVtb3ZlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gICAJ Y2xrX2Rpc2FibGVfdW5wcmVwYXJlKGdjayk7Cj4gICAJY2xrX2Rpc2FibGVfdW5wcmVwYXJlKGhj bG9jayk7Cj4gICAJY2xrX2Rpc2FibGVfdW5wcmVwYXJlKG1haW5jayk7Cj4gLQo+IC0JcmV0dXJu IDA7Cj4gICB9Cj4gICAKPiAgIHN0YXRpYyBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIHNkaGNpX2F0 OTFfZHJpdmVyID0gewo+IEBAIC00NzMsNyArNDcxLDcgQEAgc3RhdGljIHN0cnVjdCBwbGF0Zm9y bV9kcml2ZXIgc2RoY2lfYXQ5MV9kcml2ZXIgPSB7Cj4gICAJCS5wbQk9ICZzZGhjaV9hdDkxX2Rl dl9wbV9vcHMsCj4gICAJfSwKPiAgIAkucHJvYmUJCT0gc2RoY2lfYXQ5MV9wcm9iZSwKPiAtCS5y ZW1vdmUJCT0gc2RoY2lfYXQ5MV9yZW1vdmUsCj4gKwkucmVtb3ZlX25ldwk9IHNkaGNpX2F0OTFf cmVtb3ZlLAo+ICAgfTsKPiAgIAo+ICAgbW9kdWxlX3BsYXRmb3JtX2RyaXZlcihzZGhjaV9hdDkx X2RyaXZlcik7CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1hcm0ta2VybmVsCg==