From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>, Helen Koike <koike@igalia.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-dev@igalia.com
Subject: Re: [PATCH] netfilter: nf_tables: fix use-after-free on ops->dev
Date: Wed, 4 Mar 2026 14:38:57 +0100 [thread overview]
Message-ID: <aag18YM3g0sS7wXW@strlen.de> (raw)
In-Reply-To: <aaglAU8E48EF1m-_@orbyte.nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> > And *THIS* looks buggy.
> > Shouldn't that simply be:
> > if (!match || ops)
> > continue;
FWIW I can't get the reproducer to trigger a splat with this change.
I've fed this to syzbot to double-check.
> You're right, the 'changename' check in NETDEV_REGISTER is not needed
> because even if not changing names one should skip if already
> registered. Actually, this indicates a bug unless handling
> NETDEV_CHANGENAME. Maybe add a WARN_ON_ONCE()?
Well, it does trigger, afaics.
next prev parent reply other threads:[~2026-03-04 13:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-02 21:26 [PATCH] netfilter: nf_tables: fix use-after-free on ops->dev Helen Koike
2026-03-02 23:08 ` Pablo Neira Ayuso
2026-03-03 14:33 ` Helen Koike
2026-03-04 5:32 ` Florian Westphal
2026-03-04 12:26 ` Phil Sutter
2026-03-04 13:38 ` Florian Westphal [this message]
2026-03-04 14:59 ` Helen Koike
2026-03-04 12:49 ` Phil Sutter
2026-03-04 13:28 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aag18YM3g0sS7wXW@strlen.de \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=kernel-dev@igalia.com \
--cc=koike@igalia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.