From: Kiryl Shutsemau <kas@kernel.org>
To: Usama Arif <usamaarif642@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
npache@redhat.com, david@kernel.org, ziy@nvidia.com,
linux-mm@kvack.org, matthew.brost@intel.com,
joshua.hahnjy@gmail.com, hannes@cmpxchg.org, rakie.kim@sk.com,
byungchul@sk.com, gourry@gourry.net,
ying.huang@linux.alibaba.com, apopple@nvidia.com,
riel@surriel.com, shakeel.butt@linux.dev,
linux-kernel@vger.kernel.org, kernel-team@meta.com,
Usama Arif <usama.arif@linux.dev>
Subject: Re: [PATCH] mm/migrate_device: fix folio refcount leak on folio_split_unmapped failure
Date: Wed, 4 Mar 2026 14:00:42 +0000 [thread overview]
Message-ID: <aag4xM8wCAqTmco0@thinkstation> (raw)
In-Reply-To: <20260304120132.3973445-1-usamaarif642@gmail.com>
On Wed, Mar 04, 2026 at 04:01:32AM -0800, Usama Arif wrote:
> From: Usama Arif <usama.arif@linux.dev>
>
> migrate_vma_split_unmapped_folio() takes an extra reference via
> folio_get() before calling folio_split_unmapped(). On success, the
> split consumes this reference: __folio_freeze_and_split_unmapped()
> expects the +1 in its folio_ref_freeze() check, and distributes it
> across the resulting sub-folios via folio_ref_unfreeze(...+1), which
> are later balanced by folio_put() calls in __migrate_device_finalize().
Without this explanation folio_get() looks very random. And I still
can't say I understand reference management for the folios here.
Who takes reference for the folio if it !THP that gets return in the
_finalize()?
Can we get reference for THP and !THP at the same spot?
I think we should avoid spacial-casing THP where possible.
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2026-03-04 14:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 12:01 [PATCH] mm/migrate_device: fix folio refcount leak on folio_split_unmapped failure Usama Arif
2026-03-04 14:00 ` Kiryl Shutsemau [this message]
2026-03-04 15:17 ` Zi Yan
2026-03-04 21:48 ` Balbir Singh
2026-03-04 21:54 ` Zi Yan
2026-03-04 22:02 ` Matthew Brost
2026-03-04 22:09 ` Balbir Singh
2026-03-04 23:28 ` Usama Arif
2026-03-05 6:09 ` Mika Penttilä
2026-03-05 11:44 ` Usama Arif
2026-03-05 12:09 ` Mika Penttilä
2026-03-05 16:36 ` Usama Arif
2026-03-05 16:39 ` Zi Yan
2026-03-05 17:00 ` Usama Arif
2026-03-05 17:32 ` Zi Yan
2026-03-06 10:47 ` Usama Arif
2026-03-05 22:04 ` Balbir Singh
2026-03-06 10:51 ` Usama Arif
2026-03-04 15:25 ` Joshua Hahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aag4xM8wCAqTmco0@thinkstation \
--to=kas@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=apopple@nvidia.com \
--cc=byungchul@sk.com \
--cc=david@kernel.org \
--cc=gourry@gourry.net \
--cc=hannes@cmpxchg.org \
--cc=joshua.hahnjy@gmail.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matthew.brost@intel.com \
--cc=npache@redhat.com \
--cc=rakie.kim@sk.com \
--cc=riel@surriel.com \
--cc=shakeel.butt@linux.dev \
--cc=usama.arif@linux.dev \
--cc=usamaarif642@gmail.com \
--cc=ying.huang@linux.alibaba.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.