Re: [Buildroot] [PATCH 1/2] package/openscap: fix dependencies doc

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

On Wed, Mar 04, 2026 at 09:22:39AM +0100, Alexis Lothoré wrote:
> The comment displayed in menuconfig for openscap when we are lacking
> dependencies is currently broken: it should be an or of inverted
> expected values.
> 
> Update the comment for openscap when it is missing some dependency.
> 
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
> ---
>  package/openscap/Config.in | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/package/openscap/Config.in b/package/openscap/Config.in
> index 317055c75327..b5f809315c91 100644
> --- a/package/openscap/Config.in
> +++ b/package/openscap/Config.in
> @@ -19,6 +19,5 @@ config BR2_PACKAGE_OPENSCAP
>  	  https://www.open-scap.org/
>  	  https://github.com/OpenSCAP/openscap
>  
> -comment "openscap needs a toolchain w/ dynamic library"
> -	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS
> -	depends on BR2_STATIC_LIBS
> +comment "openscap needs libgpg-error and a toolchain w/ dynamic library"
> +	depends on !BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS || BR2_STATIC_LIBS

Sorry, but the existing comment is correct. We want to show the
comment when we're on an architecture that we can support, but the
toolchain lacks some features.

So as far as I can see the existing code is correct, and your patch
changes it to be incorrect :-/

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot