From: Andi Kleen <ak@linux.intel.com>
To: Vlastimil Babka <vbabka@suse.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
"David Hildenbrand (Arm)" <david@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Subject: Re: [PATCH v3] smaps: Report PMD page size for pure PMD mappings
Date: Wed, 4 Mar 2026 11:13:13 -0800 [thread overview]
Message-ID: <aaiESWyCYikx6s9e@tassilo> (raw)
In-Reply-To: <101ac423-252d-4ef8-a07c-34f5d59820f5@suse.com>
On Wed, Mar 04, 2026 at 06:29:09PM +0100, Vlastimil Babka wrote:
> Why do you keep not CCing people from v1/v2 discussions? David said that
> already on v2. It seems rather rude to me.
>
> On 3/3/26 9:15 PM, Andi Kleen wrote:
> > When a smaps mapping is only PMD mappings report the
> > PMD page size for MMUPageSize instead of the base page size.
> >
> > This is a revised version of an earlier patch that tried
> > to report multiple page sizes, but there were many objections
> > mainly centered around compatibility for mixed page size
> > reporting. This patch side steps all of this by
> > only handling the non mixed case in the simplest possible way.
> > It also avoids a problem introduced with v2 that page sizes
> > for mappings with no pages were incorrectly reported.
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> Will this be useful in practice or just confusing? There can be e.g.
It might have saved me some wasted time.
I found the current situation confusing!
> misaligned mappings, or other reasons why there won't be 100% THP
> coverage. This all or nothing value (IIUC) seems inferior to the
s/nothing/4K like what's there today/
Yes probably multiple page sizes would be better, but I'm not reopening
that discussion now.
> counters we have that say how much is pmd mapped, so I'm not really sure
> it's worth changing this.
The other counters still exist of course.
I don't see how there can be confusion if we report the correct page
size if the mapping is only that page size vs a page size that is not
used at all.
-Andi
next prev parent reply other threads:[~2026-03-04 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 20:15 [PATCH v3] smaps: Report PMD page size for pure PMD mappings Andi Kleen
2026-03-04 17:29 ` Vlastimil Babka
2026-03-04 19:13 ` Andi Kleen [this message]
2026-03-04 19:20 ` David Hildenbrand (Arm)
2026-03-05 10:33 ` Lorenzo Stoakes (Oracle)
-- strict thread matches above, loose matches on Subject: below --
2026-03-04 6:52 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aaiESWyCYikx6s9e@tassilo \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=vbabka@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.