All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: shivamkalra98@zohomail.in
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Uladzislau Rezki <urezki@gmail.com>,
	linux-mm@kvack.org,  linux-kernel@vger.kernel.org,
	Danilo Krummrich <dakr@kernel.org>
Subject: Re: [PATCH v2 1/2] mm/vmalloc: extract vmalloc_free_pages() helper from vfree()
Date: Wed, 4 Mar 2026 21:44:59 +0000	[thread overview]
Message-ID: <aain23Jm2EFsuqDN@google.com> (raw)
In-Reply-To: <20260304-vmalloc-shrink-v2-1-28c291d60100@zohomail.in>

On Wed, Mar 04, 2026 at 08:23:15PM +0530, Shivam Kalra via B4 Relay wrote:
> From: Shivam Kalra <shivamkalra98@zohomail.in>
> 
> Extract the page-freeing loop and NR_VMALLOC stat accounting from
> vfree() into a reusable vmalloc_free_pages() helper. The helper operates
> on a range [start, end) of pages from a vm_struct, making it suitable
> for both full free (vfree) and partial free (upcoming vrealloc shrink).
> 
> No functional change.
> 
> Signed-off-by: Shivam Kalra <shivamkalra98@zohomail.in>

> -		/*
> -		 * High-order allocs for huge vmallocs are split, so
> -		 * can be freed as an array of order-0 allocations
> -		 */
> -		if (!(vm->flags & VM_MAP_PUT_PAGES))
> -			mod_lruvec_page_state(page, NR_VMALLOC, -1);

Any reason this comment was dropped?

Alice


  reply	other threads:[~2026-03-04 21:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 14:53 [PATCH v2 0/2] mm/vmalloc: free unused pages on vrealloc() shrink Shivam Kalra
2026-03-04 14:53 ` Shivam Kalra via B4 Relay
2026-03-04 14:53 ` [PATCH v2 1/2] mm/vmalloc: extract vmalloc_free_pages() helper from vfree() Shivam Kalra
2026-03-04 14:53   ` Shivam Kalra via B4 Relay
2026-03-04 21:44   ` Alice Ryhl [this message]
2026-03-05  8:10     ` Shivam Kalra
2026-03-11 17:33   ` Uladzislau Rezki
2026-03-04 14:53 ` [PATCH v2 2/2] mm/vmalloc: free unused pages on vrealloc() shrink Shivam Kalra
2026-03-04 14:53   ` Shivam Kalra via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aain23Jm2EFsuqDN@google.com \
    --to=aliceryhl@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=dakr@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=shivamkalra98@zohomail.in \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.