From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51124F3D331 for ; Thu, 5 Mar 2026 16:56:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B445A10E102; Thu, 5 Mar 2026 16:56:42 +0000 (UTC) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 0E6D310E102 for ; Thu, 5 Mar 2026 16:56:41 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 330981691 for ; Thu, 5 Mar 2026 08:56:34 -0800 (PST) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 25FD83F8C6 for ; Thu, 5 Mar 2026 08:56:39 -0800 (PST) Date: Thu, 5 Mar 2026 16:54:38 +0000 From: Liviu Dudau To: Akash Goel Cc: boris.brezillon@collabora.com, steven.price@arm.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, nd@arm.com Subject: Re: [PATCH] drm/panthor: Correct the order of arguments passed to gem_sync Message-ID: References: <20260305110723.2871733-1-akash.goel@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260305110723.2871733-1-akash.goel@arm.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Mar 05, 2026 at 11:07:23AM +0000, Akash Goel wrote: > This commit corrects the order of arguments passed to panthor_gem_sync() > function, called when the SYNC_WAIT condition has to be evaluated for a > blocked GPU queue. > > Fixes: cd2c9c3015e6 (drm/panthor: Add flag to map GEM object Write-Back Cacheable) > Signed-off-by: Akash Goel Reviewed-by: Liviu Dudau Pushed to drm-misc-fixes. Best regards, Liviu > --- > drivers/gpu/drm/panthor/panthor_sched.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_sched.c b/drivers/gpu/drm/panthor/panthor_sched.c > index bd703a2904a1..a70f1db0764e 100644 > --- a/drivers/gpu/drm/panthor/panthor_sched.c > +++ b/drivers/gpu/drm/panthor/panthor_sched.c > @@ -893,14 +893,15 @@ panthor_queue_get_syncwait_obj(struct panthor_group *group, struct panthor_queue > > out_sync: > /* Make sure the CPU caches are invalidated before the seqno is read. > - * drm_gem_shmem_sync() is a NOP if map_wc=true, so no need to check > + * panthor_gem_sync() is a NOP if map_wc=true, so no need to check > * it here. > */ > - panthor_gem_sync(&bo->base.base, queue->syncwait.offset, > + panthor_gem_sync(&bo->base.base, > + DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE, > + queue->syncwait.offset, > queue->syncwait.sync64 ? > sizeof(struct panthor_syncobj_64b) : > - sizeof(struct panthor_syncobj_32b), > - DRM_PANTHOR_BO_SYNC_CPU_CACHE_FLUSH_AND_INVALIDATE); > + sizeof(struct panthor_syncobj_32b)); > > return queue->syncwait.kmap + queue->syncwait.offset; > > -- > 2.25.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯