From: Peter Xu <peterx@redhat.com>
To: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Cc: "BALATON Zoltan" <balaton@eik.bme.hu>,
qemu-devel@nongnu.org, "Paolo Bonzini" <pbonzini@redhat.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v6 5/8] memory: Factor out common ram region initialization
Date: Thu, 5 Mar 2026 11:56:09 -0500 [thread overview]
Message-ID: <aam1qabqTPDEf6CV@x1.local> (raw)
In-Reply-To: <420d013c-8cf3-447a-84b0-58f0f0f04a87@rsg.ci.i.u-tokyo.ac.jp>
On Thu, Mar 05, 2026 at 10:57:19AM +0900, Akihiko Odaki wrote:
> But looking at the code, the functions generating errors (e.g.,
> qemu_ram_alloc()) return values that indicate failures (NULL), so I now
> think we should use the first pattern I cited (i.e., check the returned
> value instead of err) and remove the err variable and error_propagate()
> altogether instead of factoring them out with
> memory_region_error_propagate() or ERRP_GUARD().
I agree, this looks better.
--
Peter Xu
next prev parent reply other threads:[~2026-03-05 16:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 21:47 [PATCH v6 0/8] memory: Remove most _nomigrate variants BALATON Zoltan
2026-03-03 21:47 ` [PATCH v6 1/8] hw/display/{cg3.tcx}: Do not use memory_region_init_rom_nomigrate() BALATON Zoltan
2026-03-03 21:47 ` [PATCH v6 2/8] memory: Remove memory_region_init_rom_nomigrate() BALATON Zoltan
2026-03-03 21:47 ` [PATCH v6 3/8] sun4m,sun4u,tcx: Do not use memory_region_init_ram_nomigrate() BALATON Zoltan
2026-03-03 21:47 ` [PATCH v6 4/8] system/memory: Reduce memory_region_init_ram_nomigrate() usage BALATON Zoltan
2026-03-03 21:47 ` [PATCH v6 5/8] memory: Factor out common ram region initialization BALATON Zoltan
2026-03-04 5:46 ` Akihiko Odaki
2026-03-04 11:38 ` BALATON Zoltan
2026-03-05 1:57 ` Akihiko Odaki
2026-03-05 16:56 ` Peter Xu [this message]
2026-03-03 21:47 ` [PATCH v6 6/8] memory: Add internal memory_region_register_ram function BALATON Zoltan
2026-03-03 21:47 ` [PATCH v6 7/8] memory: Shorten memory_region_init_ram_device_ptr and memory_region_init_rom_device BALATON Zoltan
2026-03-03 21:47 ` [PATCH v6 8/8] memory: Factor out more common ram region initialization BALATON Zoltan
2026-03-04 19:06 ` [PATCH v6 0/8] memory: Remove most _nomigrate variants Peter Xu
2026-03-04 23:39 ` BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aam1qabqTPDEf6CV@x1.local \
--to=peterx@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=jcmvbkbc@gmail.com \
--cc=kraxel@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=odaki@rsg.ci.i.u-tokyo.ac.jp \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.