From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Michael Tretter <m.tretter@pengutronix.de>
Cc: Lee Jones <lee@kernel.org>, Pavel Machek <pavel@kernel.org>,
linux-leds@vger.kernel.org, kernel@pengutronix.de,
Thorsten Schmelzer <tschmelzer@topcon.com>
Subject: Re: [PATCH] leds: led-class: detect brightness conversion base from string
Date: Thu, 5 Mar 2026 14:55:42 +0100 [thread overview]
Message-ID: <aamLXuyzEiqJGDtu@black.igk.intel.com> (raw)
In-Reply-To: <20260123-leds-class-convert-brightness-value-v1-1-ae9d3ae4224b@pengutronix.de>
On Fri, Jan 23, 2026 at 10:57:26AM +0100, Michael Tretter wrote:
> From: Thorsten Schmelzer <tschmelzer@topcon.com>
>
> sysfs-class-led doesn't specify the number format for the brightness,
> but the class only accepts base 10 numbers.
>
> Use the automatic base detection of kstrtoul and accept the brightness
> as hex value as well.
This obviously brings a regression.
Previously the 000000000000100 is 100, now it's 64.
While I don't care much (I even like the change), I have to point this out.
The correct fix is to update documentation.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-03-05 13:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 9:57 [PATCH] leds: led-class: detect brightness conversion base from string Michael Tretter
2026-02-05 15:48 ` (subset) " Lee Jones
2026-03-05 13:55 ` Andy Shevchenko [this message]
2026-03-06 11:32 ` Lee Jones
2026-03-06 15:11 ` Andy Shevchenko
2026-03-10 9:23 ` Lee Jones
2026-03-10 16:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aamLXuyzEiqJGDtu@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=kernel@pengutronix.de \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=pavel@kernel.org \
--cc=tschmelzer@topcon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.